Skip to content

Commit 4988157

Browse files
author
Release Manager
committed
gh-37286: sagemath-standard: fix manifest This PR fixes two issues with the manifest for sagemath-standard: - src/MANIFEST.in: don't include stuff outside src/sage The use of `global-include <PATTERN>` is inconvenient since it will include any file matching the pattern anywhere; replace it with `recursive-include sage <PATTERN>` which is what we really mean. - sagemath-standard/setup.py: workaround setuptools_scm The workaround already there is not good for setuptools_scm >= 8. Implement a more robust workaround (should work for any version of setuptools_scm but I have not tested, so I did not remove the old workaround -- it's harmless to apply both). ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: #37286 Reported by: Gonzalo Tornaría Reviewer(s):
2 parents 99fd4f4 + ac629c5 commit 4988157

File tree

2 files changed

+6
-1
lines changed

2 files changed

+6
-1
lines changed

pkgs/sagemath-standard/setup.py

Lines changed: 5 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -24,6 +24,11 @@
2424
except ImportError:
2525
pass
2626

27+
# Different workaround: disable `walk_revctrl` in setuptools
28+
# This is needed for setuptools_scm >= 8, should work for any version
29+
import setuptools.command.egg_info
30+
setuptools.command.egg_info.walk_revctrl = lambda: ()
31+
2732
#########################################################
2833
### Set source directory
2934
#########################################################

src/MANIFEST.in

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
include VERSION.txt
22

3-
global-include *.pxi *.pxd *.h *.hpp
3+
recursive-include sage *.pxi *.pxd *.h *.hpp
44

55
prune sage/ext/interpreters # In particular, __init__.py must not be present in the distribution; or sage_setup.autogen.interpreters.rebuild will not generate the code
66
prune sage_setup

0 commit comments

Comments
 (0)