gh-36851: various details in group (ruff and pycodestyle)
    
This is fixing some E221 and some suggestions of ruff in the `groups`
folder

### 📝 Checklist

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
    
URL: #36851
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe

Author: Release Manager

src/sage/groups/abelian_gps/abelian_group.py

@@ -1387,11 +1387,11 @@ def number_of_subgroups(self, order=None):
         sylow_types = defaultdict(list)
         for p, e in primary_factors:
             sylow_types[p].append(e)
-        subgroups_orders_kwds = dict()
+        subgroups_orders_kwds = {}
 
         if order is None:
             for p, p_exps in sylow_types.items():
-                subgroups_orders_kwds[p] = dict(max_sum=sum(p_exps))
+                subgroups_orders_kwds[p] = {'max_sum': sum(p_exps)}
         else:
             order = Integer(order)
             if order < 1:
@@ -1403,7 +1403,7 @@ def number_of_subgroups(self, order=None):
             for p in (set(sylow_types) - set(order_exps)):
                 del sylow_types[p]
             for p in sylow_types:
-                subgroups_orders_kwds[p] = dict(n=order_exps[p])
+                subgroups_orders_kwds[p] = {'n': order_exps[p]}
 
         result = Integer(1)
         for p, p_exps in sylow_types.items():

src/sage/groups/abelian_gps/abelian_group_morphism.py

@@ -133,8 +133,8 @@ def _libgap_(self):
             sage: libgap(phi)
             [ f1, f2 ] -> [ f1*f4, f2 ]
         """
-        G  = libgap(self.domain())
-        H  = libgap(self.codomain())
+        G = libgap(self.domain())
+        H = libgap(self.codomain())
         in_G = [libgap(g) for g in self.domaingens]
         in_H = [libgap(h) for h in self.codomaingens]
         return G.GroupHomomorphismByImages(H, in_G, in_H)

src/sage/groups/additive_abelian/qmodnz.py

@@ -180,7 +180,7 @@ def some_elements(self):
             sage: len(L)
             92
         """
-        return list(set(self(x) for x in QQ.some_elements()))
+        return list({self(x) for x in QQ.some_elements()})
 
     def random_element(self):
         r"""

src/sage/groups/affine_gps/group_element.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 r"""
 Elements of Affine Groups
 

src/sage/groups/artin.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 """
 Artin Groups
 

src/sage/groups/braid.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 """
 Braid groups
 
@@ -2068,7 +2067,7 @@ def reverse(self):
             sage: br.is_conjugated(b)
             False
         """
-        t = [i for i in self.Tietze()]
+        t = list(self.Tietze())
         t.reverse()
         return self.parent()(tuple(t))
 
@@ -2842,7 +2841,7 @@ def _links_gould_representation(self, symbolics=False):
             # quantum trace operator on two fold tensor space
             E = mu.parent().one()
             mu2 = E.tensor_product(mu)
-            return tuple([[R, RI], mu2])
+            return ([R, RI], mu2)
 
         from sage.matrix.matrix_space import MatrixSpace
         Ed = MatrixSpace(BR, d, d, sparse=sparse).one()

src/sage/groups/conjugacy_classes.py

@@ -1,4 +1,3 @@
-# -*- coding: utf-8 -*-
 r"""
 Conjugacy classes of groups
 

src/sage/groups/cubic_braid.py

@@ -868,7 +868,7 @@ def degrees(self):
             raise TypeError('not a finite reflection group')
         if self.strands() > 5:
             raise TypeError('not a finite reflection group')
-        d_table = {1: tuple(), 2: (3,), 3: (4, 6),
+        d_table = {1: (), 2: (3,), 3: (4, 6),
                    4: (6, 9, 12), 5: (12, 18, 24, 30)}
         return tuple(Integer(deg) for deg in d_table[self.strands()])
 
@@ -887,7 +887,7 @@ def codegrees(self):
             raise TypeError('not a finite reflection group')
         if self.strands() > 5:
             raise TypeError('not a finite reflection group')
-        d_table = {1: tuple(), 2: (0,), 3: (0, 2),
+        d_table = {1: (), 2: (0,), 3: (0, 2),
                    4: (0, 3, 6), 5: (0, 6, 12, 18)}
         return tuple(Integer(deg) for deg in d_table[self.strands()])
 

src/sage/groups/finitely_presented.py

@@ -263,7 +263,7 @@ def __reduce__(self):
             (Finitely presented group < a, b, c | a*b*c*a^-1*c^-1*b^-1, a*b*c*b^-1*a^-1*c^-1 >,
              ((1, 2, 3),))
         """
-        return (self.parent(), tuple([self.Tietze()]))
+        return (self.parent(), (self.Tietze(),))
 
     def _repr_(self):
         """
@@ -1830,7 +1830,7 @@ def characteristic_varieties(self, ring=QQ, matrix_ideal=None, groebner=False):
         S = R.polynomial_ring()
         K = R.base_ring()
         id_rels = R.ideal(rels)
-        res = dict()
+        res = {}
         bound = n + 1
         for j in range(bound + 1):
             J = id_rels + A.fitting_ideal(j)
@@ -1847,7 +1847,7 @@ def characteristic_varieties(self, ring=QQ, matrix_ideal=None, groebner=False):
             return res
         if R.ngens() == 1:
             res = {j: gcd(S(p) for p in res[j].gens()) for j in range(bound + 1)}
-            char_var = dict()
+            char_var = {}
             strict = True
             j = 0
             while strict and j <= bound:
@@ -1862,7 +1862,7 @@ def characteristic_varieties(self, ring=QQ, matrix_ideal=None, groebner=False):
                         strict = False
                 j += 1
             return char_var
-        char_var = dict()
+        char_var = {}
         strict = True
         j = 0
         while strict and j <= bound:

src/sage/groups/fqf_orthogonal.py

@@ -549,7 +549,7 @@ def orbits(G, L):
     # separating the different primes here would speed things up
     b_cand = [[b for b in B if b.q() == a.q() and b.order() == a.order()] for a in A.smith_form_gens()]
 
-    G = B.orthogonal_group(tuple())
+    G = B.orthogonal_group(())
     ambient = G.ambient()
     waiting = [[]]
     while len(waiting) > 0: