Skip to content

Commit 551d007

Browse files
committed
return fraction-field elements in .rational_maps() and .x_rational_map()
1 parent 84f02af commit 551d007

File tree

1 file changed

+13
-7
lines changed

1 file changed

+13
-7
lines changed

src/sage/schemes/elliptic_curves/weierstrass_morphism.py

Lines changed: 13 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -528,6 +528,8 @@ def __init__(self, E=None, urst=None, F=None):
528528

529529
self._mpoly_ring = PolynomialRing(base_ring, ['x','y'])
530530
self._poly_ring = PolynomialRing(base_ring, ['x'])
531+
self._xyfield = self._mpoly_ring.fraction_field()
532+
self._xfield = self._poly_ring.fraction_field()
531533

532534
self._domain = E
533535
self._codomain = F
@@ -773,14 +775,16 @@ def rational_maps(self):
773775
sage: w(P).xy() == (f(P.xy()), g(P.xy()))
774776
True
775777
776-
TESTS::
778+
TESTS:
779+
780+
Check for :trac:`34811`::
777781
778782
sage: iso.rational_maps()[0].parent()
779-
Multivariate Polynomial Ring in x, y over Rational Field
783+
Fraction Field of Multivariate Polynomial Ring in x, y over Rational Field
780784
sage: iso.rational_maps()[1].parent()
781-
Multivariate Polynomial Ring in x, y over Rational Field
785+
Fraction Field of Multivariate Polynomial Ring in x, y over Rational Field
782786
"""
783-
return tuple(baseWI.__call__(self, self._mpoly_ring.gens()))
787+
return tuple(baseWI.__call__(self, self._xyfield.gens()))
784788

785789
def x_rational_map(self):
786790
"""
@@ -800,12 +804,14 @@ def x_rational_map(self):
800804
sage: iso.x_rational_map() == iso.rational_maps()[0]
801805
True
802806
803-
TESTS::
807+
TESTS:
808+
809+
Check for :trac:`34811`::
804810
805811
sage: iso.x_rational_map().parent()
806-
Univariate Polynomial Ring in x over Rational Field
812+
Fraction Field of Univariate Polynomial Ring in x over Rational Field
807813
"""
808-
x, = self._poly_ring.gens()
814+
x, = self._xfield.gens()
809815
return (x - self.r) / self.u**2
810816

811817
def kernel_polynomial(self):

0 commit comments

Comments
 (0)