You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gh-40415: Remove precisely the prefix instead of strip
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes#12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes#12345". -->
Hello,
I am a first time contributor, still navigating the `sage` huge
codebase. Please let me know if I am not aware of something.
This PR resolves a few occurrences of the error
[B005](https://docs.astral.sh/ruff/rules/strip-with-multi-characters/)
from `ruff`.
It looks pretty clear to me that that intent of the code is to remove
precisely these prefixes rather than, for example, removing all the
leading occurrences of the letters d, e, f, a, u, l, t. I think the
example in the docs of `ruff` illustrates quite well the difference.
Tested with `ruff check src/sage --select B005`
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - #12345: short description why this is a dependency -->
<!-- - #34567: ... -->
URL: #40415
Reported by: Trinh Quoc Anh
Reviewer(s): Frédéric Chapoton
0 commit comments