Skip to content

Commit 5b90f22

Browse files
author
Release Manager
committed
gh-36239: Disable more packages with various --disable-foo combinations Prune more leaf packages with `--disable-doc`, `--disable-notebook`, `--disable-r`, and combinations thereof. URL: #36239 Reported by: Michael Orlitzky Reviewer(s): Matthias Köppe
2 parents 01a8322 + c59c407 commit 5b90f22

File tree

1 file changed

+25
-9
lines changed

1 file changed

+25
-9
lines changed

configure.ac

Lines changed: 25 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -507,21 +507,15 @@ AC_ARG_ENABLE([cvxopt],
507507
AC_ARG_ENABLE([notebook],
508508
AS_HELP_STRING([--disable-notebook],
509509
[disable build of the Jupyter notebook and related packages]), [
510-
for pkg in notebook nbconvert beautifulsoup4 sagenb_export nbformat nbclient terminado send2trash prometheus_client mistune pandocfilters bleach defusedxml jsonschema jupyter_jsmol argon2_cffi webencodings tinycss2; do
511-
AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
512-
done
513-
])
514-
515-
AS_IF([test "$SAGE_ENABLE_notebook" = no -a "$SAGE_ENABLE_sagelib" = no], [
516-
for pkg in jupyter_client ipykernel ipython zeromq pyzmq; do
510+
for pkg in notebook nbconvert beautifulsoup4 sagenb_export nbformat nbclient terminado send2trash prometheus_client mistune pandocfilters bleach defusedxml jsonschema jupyter_jsmol argon2_cffi argon2_cffi_bindings webencodings tinycss2 soupsieve fastjsonschema; do
517511
AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
518512
done
519513
])
520514

521515
AC_ARG_ENABLE([r],
522516
AS_HELP_STRING([--disable-r],
523517
[disable build of the R package and related packages]), [
524-
for pkg in r rpy2 r_jupyter tzlocal; do
518+
for pkg in r rpy2 r_jupyter tzlocal pytz_deprecation_shim; do
525519
AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
526520
done
527521
])
@@ -530,7 +524,7 @@ AC_ARG_ENABLE([doc],
530524
AS_HELP_STRING([--disable-doc],
531525
[disable build of the Sage documentation and packages depending on it]), [
532526
dnl Disable packages needed for docbuilding
533-
for pkg in sage_docbuild alabaster babel snowballstemmer imagesize sphinx sphinxcontrib_devhelp sphinxcontrib_jsmath sphinxcontrib_serializinghtml sphinxcontrib_applehelp sphinxcontrib_htmlhelp sphinxcontrib_qthelp sphinxcontrib_websupport jupyter_sphinx furo sphinx_copybutton mathjax; do
527+
for pkg in sage_docbuild alabaster babel snowballstemmer imagesize sphinx sphinxcontrib_devhelp sphinxcontrib_jsmath sphinxcontrib_serializinghtml sphinxcontrib_applehelp sphinxcontrib_htmlhelp sphinxcontrib_qthelp sphinxcontrib_websupport jupyter_sphinx furo sphinx_copybutton mathjax sphinx_basic_ng; do
534528
AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
535529
done
536530
AS_VAR_IF([enableval], [no], [dnl Disable the docbuild by disabling the install tree for documentation
@@ -546,6 +540,28 @@ AC_ARG_ENABLE([sagelib],
546540
done
547541
])
548542

543+
544+
dnl Handle combinations of --disable-foo flags that may enable us to
545+
dnl prune even more dependencies.
546+
AS_IF([test "$SAGE_ENABLE_notebook" = no -a "$SAGE_ENABLE_sagelib" = no], [
547+
for pkg in jupyter_client ipykernel ipython zeromq pyzmq; do
548+
AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
549+
done
550+
])
551+
AS_IF([test "$SAGE_ENABLE_r" = no -a "$SAGE_ENABLE_sage_docbuild" = no], [
552+
dnl pytz is needed only by rpy2 and babel, and babel is already
553+
dnl disabled by --disable-doc.
554+
for pkg in pytz; do
555+
AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
556+
done
557+
])
558+
AS_IF([test "$SAGE_ENABLE_r" = no -a "$SAGE_ENABLE_notebook" = no], [
559+
dnl These two are dependencies of both rpy2 and some notebook stuff
560+
for pkg in cffi pycparser; do
561+
AS_VAR_SET([SAGE_ENABLE_$pkg], [$enableval])
562+
done
563+
])
564+
549565
dnl Packages that require a special override to use the SPKG
550566
dnl when the system package is not usable.
551567
AS_VAR_SET([sage_use_system_gcc], [force])

0 commit comments

Comments
 (0)