Skip to content

Commit 60169d0

Browse files
author
Release Manager
committed
gh-40914: make "num_cusps_of_width" an alias using the name "n_cusps_of_width" instead see also #40887 ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. URL: #40914 Reported by: Frédéric Chapoton Reviewer(s): Martin Rubey
2 parents 6f0b82f + e76bc5f commit 60169d0

File tree

1 file changed

+23
-12
lines changed

1 file changed

+23
-12
lines changed

src/sage/modular/etaproducts.py

Lines changed: 23 additions & 12 deletions
Original file line numberDiff line numberDiff line change
@@ -84,7 +84,7 @@ def EtaGroup(level):
8484

8585
class EtaGroupElement(Element):
8686

87-
def __init__(self, parent, rdict):
87+
def __init__(self, parent, rdict) -> None:
8888
r"""
8989
Create an eta product object. Usually called implicitly via
9090
EtaGroup_class.__call__ or the EtaProduct factory function.
@@ -419,7 +419,7 @@ class EtaGroup_class(UniqueRepresentation, Parent):
419419
True
420420
"""
421421

422-
def __init__(self, level):
422+
def __init__(self, level) -> None:
423423
r"""
424424
Create the group of eta products of a given level, which must be a
425425
positive integer.
@@ -662,7 +662,7 @@ def EtaProduct(level, dic) -> EtaGroupElement:
662662
return EtaGroup(level)(dic)
663663

664664

665-
def num_cusps_of_width(N, d) -> Integer:
665+
def n_cusps_of_width(N, d) -> Integer:
666666
r"""
667667
Return the number of cusps on `X_0(N)` of width ``d``.
668668
@@ -674,13 +674,21 @@ def num_cusps_of_width(N, d) -> Integer:
674674
675675
EXAMPLES::
676676
677-
sage: from sage.modular.etaproducts import num_cusps_of_width
678-
sage: [num_cusps_of_width(18,d) for d in divisors(18)]
677+
sage: from sage.modular.etaproducts import n_cusps_of_width
678+
sage: [n_cusps_of_width(18,d) for d in divisors(18)]
679679
[1, 1, 2, 2, 1, 1]
680-
sage: num_cusps_of_width(4,8)
680+
sage: n_cusps_of_width(4,8)
681681
Traceback (most recent call last):
682682
...
683683
ValueError: N and d must be positive integers with d|N
684+
685+
TESTS:
686+
687+
The old method name is kept as an alias::
688+
689+
sage: from sage.modular.etaproducts import num_cusps_of_width
690+
sage: [num_cusps_of_width(6,d) for d in divisors(6)]
691+
[1, 1, 1, 1]
684692
"""
685693
N = ZZ(N)
686694
d = ZZ(d)
@@ -690,9 +698,12 @@ def num_cusps_of_width(N, d) -> Integer:
690698
return euler_phi(d.gcd(N // d))
691699

692700

701+
num_cusps_of_width = n_cusps_of_width
702+
703+
693704
def AllCusps(N) -> list:
694705
r"""
695-
Return a list of CuspFamily objects corresponding to the cusps of
706+
Return a list of :class:`CuspFamily` objects corresponding to the cusps of
696707
`X_0(N)`.
697708
698709
INPUT:
@@ -714,7 +725,7 @@ def AllCusps(N) -> list:
714725

715726
c = []
716727
for d in divisors(N):
717-
n = num_cusps_of_width(N, d)
728+
n = n_cusps_of_width(N, d)
718729
if n == 1:
719730
c.append(CuspFamily(N, d))
720731
elif n > 1:
@@ -728,7 +739,7 @@ class CuspFamily(SageObject):
728739
r"""
729740
A family of elliptic curves parametrising a region of `X_0(N)`.
730741
"""
731-
def __init__(self, N, width, label=None):
742+
def __init__(self, N, width, label=None) -> None:
732743
r"""
733744
Create the cusp of width d on X_0(N) corresponding to the family
734745
of Tate curves `(\CC_p/q^d, \langle \zeta q\rangle)`.
@@ -751,9 +762,9 @@ def __init__(self, N, width, label=None):
751762
self._width = width
752763
if N % width:
753764
raise ValueError("bad width")
754-
if num_cusps_of_width(N, width) > 1 and label is None:
755-
raise ValueError("there are %s > 1 cusps of width %s on X_0(%s): specify a label" % (num_cusps_of_width(N, width), width, N))
756-
if num_cusps_of_width(N, width) == 1 and label is not None:
765+
if n_cusps_of_width(N, width) > 1 and label is None:
766+
raise ValueError("there are %s > 1 cusps of width %s on X_0(%s): specify a label" % (n_cusps_of_width(N, width), width, N))
767+
if n_cusps_of_width(N, width) == 1 and label is not None:
757768
raise ValueError("there is only one cusp of width %s on X_0(%s): no need to specify a label" % (width, N))
758769
self.label = label
759770

0 commit comments

Comments
 (0)