Skip to content

Commit 6252db6

Browse files
author
Release Manager
committed
gh-35741: `sage.combinat`: Split some Cython modules (modularization fixes) <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> Some basic modules of `sage.combinat` (`.permutation`, `.combination`, etc.) are needed in the distribution **sagemath-categories** (as of #35095). We make them importable (by splitting a Cython module into several parts and by using lazy imports) and separately testable (using `# optional` doctest directives). Likewise, split the parts of `sage.combinat.posets.hasse_cython` that need the FLINT library out as a separate module (this is for the package **sagemath-graphs** in #35095) <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> - Split out from #35564 - Part of #29705 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35741 Reported by: Matthias Köppe Reviewer(s): David Coudert
2 parents 81075d6 + fe07439 commit 6252db6

11 files changed

+599
-572
lines changed

src/doc/en/reference/combinat/module_list.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -291,6 +291,7 @@ Comprehensive Module List
291291
sage/combinat/rsk
292292
sage/combinat/schubert_polynomial
293293
sage/combinat/set_partition
294+
sage/combinat/set_partition_iterator
294295
sage/combinat/set_partition_ordered
295296
sage/combinat/sf/all
296297
sage/combinat/sf/character

src/sage/combinat/combinat_cython.pxd

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,4 @@ from sage.libs.gmp.all cimport mpz_t
22

33
cdef mpz_stirling_s2(mpz_t s, unsigned long n, unsigned long k)
44

5-
cdef list from_word(list w, list base_set)
6-
75
cdef list convert(Py_ssize_t* f, Py_ssize_t n)
8-

0 commit comments

Comments
 (0)