Trac #34947: sage.{rings,modules,geometry}: Replace imports from sage.*.all for namespace packages

Using `./sage -fiximports` from #34945.

Also remove trailing whitespace in the affected files.

Part of Meta-ticket #32414

URL: https://trac.sagemath.org/34947
Reported by: mkoeppe
Ticket author(s): Alex Chandler
Reviewer(s): Travis Scrimshaw, Matthias Koeppe

Author: Release Manager

src/sage/geometry/cone.py

@@ -205,7 +205,8 @@
 from copy import copy
 from warnings import warn
 
-from sage.arith.all import gcd, lcm
+from sage.arith.misc import GCD as gcd
+from sage.arith.functions import lcm
 from sage.combinat.posets.posets import FinitePoset
 from sage.geometry.point_collection import PointCollection
 from sage.geometry.polyhedron.constructor import Polyhedron

src/sage/geometry/hyperplane_arrangement/library.py

@@ -22,7 +22,7 @@
 from sage.combinat.combinat import stirling_number2
 from sage.combinat.root_system.cartan_type import CartanType
 from sage.combinat.root_system.root_system import RootSystem
-from sage.arith.all import binomial
+from sage.arith.misc import binomial
 from sage.rings.polynomial.polynomial_ring import polygen
 
 from sage.geometry.hyperplane_arrangement.arrangement import HyperplaneArrangements

src/sage/geometry/integral_points.pyx

@@ -22,7 +22,8 @@ from sage.rings.integer_ring import ZZ
 from sage.rings.rational_field import QQ
 from sage.rings.real_mpfr import RR
 from sage.rings.integer cimport Integer
-from sage.arith.all import gcd, lcm
+from sage.arith.misc import GCD as gcd
+from sage.arith.functions import lcm
 from sage.combinat.permutation import Permutation
 from sage.misc.misc_c import prod
 from sage.modules.free_module import FreeModule

src/sage/geometry/lattice_polytope.py

@@ -103,7 +103,7 @@
 #                  https://www.gnu.org/licenses/
 # ****************************************************************************
 
-from sage.arith.all import gcd
+from sage.arith.misc import GCD as gcd
 from sage.combinat.posets.posets import FinitePoset
 from sage.env import POLYTOPE_DATA_DIR
 from sage.geometry.cone import _ambient_space_point, integral_length

src/sage/geometry/point_collection.pyx

@@ -955,23 +955,23 @@ def read_palp_point_collection(f, lattice=None, permutation=False):
     Read and return a point collection from an opened file.
 
     Data must be in PALP format:
-   
+
         * the first input line starts with two integers `m` and `n`, the number
           of points and the number of components of each;
-    
+
         * the rest of the first line may contain a permutation;
-    
+
         * the next `m` lines contain `n` numbers each.
-        
+
     .. NOTE::
-    
+
         If `m` < `n`, it is assumed (for compatibility with PALP) that the
         matrix is transposed, i.e. that each column is a point.
 
     INPUT:
 
     - ``f`` -- an opened file with PALP output.
-    
+
     - ``lattice`` -- the lattice for points. If not given, the
       :class:`toric lattice <sage.geometry.toric_lattice.ToricLatticeFactory>`
       `M` of dimension `n` will be used.

src/sage/geometry/polyhedron/generating_function.py

@@ -1492,7 +1492,7 @@ def generate_mods(equations):
             sage: _TransformMod.generate_mods([(0, 1, 1, -2)])
             ({0: (2, 0), 1: (2, 0)}, {0: (2, 1), 1: (2, 1)})
         """
-        from sage.arith.all import lcm
+        from sage.arith.functions import lcm
         from sage.matrix.constructor import matrix
         from sage.rings.integer_ring import ZZ
         from sage.rings.rational_field import QQ

src/sage/geometry/triangulation/element.py

@@ -878,7 +878,7 @@ def normal_cone(self):
             raise NotImplementedError('Only base rings ZZ and QQ are supported')
         from ppl import Constraint_System, Linear_Expression, C_Polyhedron
         from sage.matrix.constructor import matrix
-        from sage.arith.all import lcm
+        from sage.arith.functions import lcm
         pc = self.point_configuration()
         cs = Constraint_System()
         for facet in self.interior_facets():

src/sage/modules/fg_pid/fgp_element.py

@@ -448,7 +448,7 @@ def additive_order(self):
         from sage.rings.infinity import infinity
         from sage.rings.finite_rings.integer_mod import Mod
         from sage.rings.integer import Integer
-        from sage.arith.all import lcm
+        from sage.arith.functions import lcm
         n = Integer(1)
         for i, a in enumerate(I):
             if a == 0:

src/sage/modules/fg_pid/fgp_morphism.py

@@ -510,7 +510,7 @@ def __init__(self, X, Y, category=None):
                 from sage.categories.modules_with_basis import ModulesWithBasis
                 category = ModulesWithBasis(X.base_ring())
             else:
-                from sage.categories.all import Modules
+                from sage.categories.modules import Modules
                 category = Modules(X.base_ring())
         Homset.__init__(self, X, Y, category)
 

src/sage/modules/filtered_vector_space.py

@@ -108,7 +108,11 @@
 #                  https://www.gnu.org/licenses/
 # ***************************************************************************
 
-from sage.rings.all import QQ, ZZ, RDF, RR, Integer
+from sage.rings.rational_field import QQ
+from sage.rings.integer_ring import ZZ
+from sage.rings.real_double import RDF
+from sage.rings.real_mpfr import RR
+from sage.rings.integer import Integer
 from sage.rings.infinity import InfinityRing, infinity, minus_infinity
 from sage.categories.fields import Fields
 from sage.modules.free_module import FreeModule_ambient_field, VectorSpace