Skip to content

Commit 6ab9c83

Browse files
author
Release Manager
committed
gh-36325: Refactor Drinfeld modules subclasses <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> The goal of this PR is to refactor the Drinfeld modules subclasses. In particular, we rename `FiniteDrinfeldModule` into `DrinfeldModule_finite` and we create a new class named `DrinfeldModule_charzero`. The second class denotes a Drinfeld module which is defined over a ring of $\mathbb{F}_q[T]$-characteristic zero. More conceptually, we propose the following structure: ``` DrinfeldModule - DrinfeldModule_finite - DrinfeldModule_charzero ``` The user will only have to interact with the metaclass `DrinfeldModule`. This refactorisation ensures that the exponential, the logarithm and the Goss polynomials methods always works as these are not defined in the finite case (and thus removes the required check). In the near future, we plan to implement `DrinfeldModule_charzero_rank_one` as a subclass of `DrinfeldModule_charzero` and implement their associated $A$-lattice. CC: @kryzar @xcaruso @ymusleh ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> <!-- Feel free to remove irrelevant items. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #36325 Reported by: David Ayotte Reviewer(s): David Ayotte, Xavier Caruso
2 parents 1943799 + d90340e commit 6ab9c83

File tree

4 files changed

+446
-358
lines changed

4 files changed

+446
-358
lines changed

src/doc/en/reference/drinfeld_modules/index.rst

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -12,6 +12,7 @@ Drinfeld modules
1212
:maxdepth: 2
1313

1414
sage/rings/function_field/drinfeld_modules/drinfeld_module
15+
sage/rings/function_field/drinfeld_modules/charzero_drinfeld_module
1516
sage/rings/function_field/drinfeld_modules/finite_drinfeld_module
1617

1718
Morphisms and isogenies

0 commit comments

Comments
 (0)