Skip to content

Commit 6c78a66

Browse files
committed
remove entirely the legacy class EuclideanDomain
1 parent 439065e commit 6c78a66

File tree

4 files changed

+4
-37
lines changed

4 files changed

+4
-37
lines changed

src/sage/rings/abc.pyx

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
"""
22
Abstract base classes for rings
33
"""
4-
from sage.rings.ring import EuclideanDomain
4+
from sage.rings.ring import IntegralDomain
55

66

77
class NumberField_quadratic(Field):
@@ -419,7 +419,7 @@ class Order:
419419
pass
420420

421421

422-
class pAdicRing(EuclideanDomain):
422+
class pAdicRing(IntegralDomain):
423423
r"""
424424
Abstract base class for :class:`~sage.rings.padics.generic_nodes.pAdicRingGeneric`.
425425

src/sage/rings/all.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,7 @@
1616

1717
# Ring base classes
1818
from sage.rings.ring import (Ring, Field, CommutativeRing, IntegralDomain,
19-
DedekindDomain, PrincipalIdealDomain, EuclideanDomain)
19+
DedekindDomain, PrincipalIdealDomain)
2020

2121
# Ring element base classes
2222
from sage.structure.element import (CommutativeAlgebraElement,

src/sage/rings/ring.pxd

Lines changed: 0 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,6 @@ cdef class DedekindDomain(IntegralDomain):
2323
cdef class PrincipalIdealDomain(IntegralDomain):
2424
pass
2525

26-
cdef class EuclideanDomain(PrincipalIdealDomain):
27-
pass
28-
2926
cdef class Field(PrincipalIdealDomain):
3027
pass
3128

src/sage/rings/ring.pyx

Lines changed: 1 addition & 31 deletions
Original file line numberDiff line numberDiff line change
@@ -29,7 +29,6 @@ The class inheritance hierarchy is:
2929
3030
Subclasses of :class:`PrincipalIdealDomain` are
3131
32-
- :class:`EuclideanDomain`
3332
- :class:`Field`
3433
3534
- :class:`~sage.rings.finite_rings.finite_field_base.FiniteField`
@@ -77,7 +76,6 @@ from sage.categories.rings import Rings
7776
from sage.categories.commutative_rings import CommutativeRings
7877
from sage.categories.integral_domains import IntegralDomains
7978
from sage.categories.principal_ideal_domains import PrincipalIdealDomains
80-
from sage.categories.euclidean_domains import EuclideanDomains
8179

8280
_Rings = Rings()
8381
_CommutativeRings = CommutativeRings()
@@ -1639,7 +1637,7 @@ cdef class IntegralDomain(CommutativeRing):
16391637
This method is used by all the abstract subclasses of
16401638
:class:`IntegralDomain`, like :class:`NoetherianRing`,
16411639
:class:`PrincipalIdealDomain`, :class:`DedekindDomain`,
1642-
:class:`EuclideanDomain`, :class:`Field`, ... in order to
1640+
:class:`Field`, ... in order to
16431641
avoid cascade calls Field.__init__ ->
16441642
PrincipalIdealDomain.__init__ -> IntegralDomain.__init__ ->
16451643
...
@@ -1654,10 +1652,6 @@ cdef class IntegralDomain(CommutativeRing):
16541652
sage: F.category()
16551653
Category of principal ideal domains
16561654
1657-
sage: F = EuclideanDomain(QQ)
1658-
sage: F.category()
1659-
Category of euclidean domains
1660-
16611655
sage: F = Field(QQ)
16621656
sage: F.category()
16631657
Category of fields
@@ -1676,9 +1670,6 @@ cdef class IntegralDomain(CommutativeRing):
16761670
sage: PrincipalIdealDomain._default_category
16771671
Category of principal ideal domains
16781672
1679-
sage: EuclideanDomain._default_category
1680-
Category of euclidean domains
1681-
16821673
sage: Field._default_category
16831674
Category of fields
16841675
@@ -2071,27 +2062,6 @@ cdef class PrincipalIdealDomain(IntegralDomain):
20712062
from sage.rings.ideal import Ideal_pid
20722063
return Ideal_pid
20732064

2074-
cdef class EuclideanDomain(PrincipalIdealDomain):
2075-
"""
2076-
Generic Euclidean domain class.
2077-
2078-
This class is deprecated. Please use the
2079-
:class:`~sage.categories.euclidean_domains.EuclideanDomains`
2080-
category instead.
2081-
"""
2082-
_default_category = EuclideanDomains()
2083-
2084-
def parameter(self):
2085-
"""
2086-
Return an element of degree 1.
2087-
2088-
EXAMPLES::
2089-
2090-
sage: R.<x>=QQ[]
2091-
sage: R.parameter()
2092-
x
2093-
"""
2094-
raise NotImplementedError
20952065

20962066
cpdef bint _is_Field(x) except -2:
20972067
"""

0 commit comments

Comments
 (0)