Skip to content

Commit 72c6188

Browse files
author
Release Manager
committed
gh-39513: Show test failures of ci-meson as annotations Follow-up to #36938 and #37738 , this PR shows the test failures of ci-meson.yml workflow as GitHub annotations, which has the advantage that you don't need to scroll through the whole log to view the failed tests. (actually I just search for `Failed examples`, but this is not foolproof) Previously only build.yml got this feature. There's a disadvantage, then the file and line numbers are no longer shown in the downloaded log file, instead only `[error]` is shown (but this is trivially fixable by printing the format in both old and new ways when `--format github` is passed). I think if everyone views the annotations instead of reading the raw log anyway, it shouldn't matter too much. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. (no functionality change) - [ ] I have updated the documentation and checked the documentation preview. (no documentation change) ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #39513 Reported by: user202729 Reviewer(s): Tobias Diez
2 parents 4f4c120 + 763521d commit 72c6188

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/ci-meson.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -81,7 +81,7 @@ jobs:
8181
run: |
8282
# We don't install sage_setup, so don't try to test it
8383
rm -R ./src/sage_setup/
84-
./sage -t --all -p4
84+
./sage -t --all -p4 --format github
8585
8686
- name: Upload log
8787
uses: actions/[email protected]

0 commit comments

Comments
 (0)