Skip to content

Commit 75813df

Browse files
committed
add some -> tuple annotations
1 parent 28b7af0 commit 75813df

File tree

6 files changed

+40
-39
lines changed

6 files changed

+40
-39
lines changed

src/sage/algebras/lie_algebras/lie_algebra.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -953,7 +953,7 @@ def _an_element_(self):
953953
return self.lie_algebra_generators()[self._indices.an_element()]
954954

955955
# Do we want this to return lie_algebra_generators()? Perhaps in the category?
956-
# def gens(self):
956+
# def gens(self) -> tuple:
957957
# """
958958
# Return a tuple whose entries are the generators for this
959959
# object, in some order.

src/sage/algebras/lie_conformal_algebras/finitely_freely_generated_lca.py

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -6,21 +6,19 @@
66
77
- Reimundo Heluani (2019-08-09): Initial implementation.
88
"""
9-
10-
#******************************************************************************
9+
# ****************************************************************************
1110
# Copyright (C) 2019 Reimundo Heluani <[email protected]>
1211
#
1312
# This program is free software: you can redistribute it and/or modify
1413
# it under the terms of the GNU General Public License as published by
1514
# the Free Software Foundation, either version 2 of the License, or
1615
# (at your option) any later version.
17-
# http://www.gnu.org/licenses/
18-
#*****************************************************************************
19-
20-
from sage.misc.cachefunc import cached_method
16+
# https://www.gnu.org/licenses/
17+
# ***************************************************************************
2118
from sage.categories.lie_conformal_algebras import LieConformalAlgebras
2219
from .freely_generated_lie_conformal_algebra import \
23-
FreelyGeneratedLieConformalAlgebra
20+
FreelyGeneratedLieConformalAlgebra
21+
from sage.misc.cachefunc import cached_method
2422

2523

2624
class FinitelyFreelyGeneratedLCA(FreelyGeneratedLieConformalAlgebra):
@@ -33,7 +31,7 @@ class FinitelyFreelyGeneratedLCA(FreelyGeneratedLieConformalAlgebra):
3331
"""
3432
def __init__(self, R, index_set=None, central_elements=None, category=None,
3533
element_class=None, prefix=None, names=None, latex_names=None,
36-
**kwds):
34+
**kwds) -> None:
3735
"""
3836
Initialize ``self``.
3937
@@ -53,7 +51,8 @@ def __init__(self, R, index_set=None, central_elements=None, category=None,
5351
raise TypeError("index_set must be a finite set")
5452

5553
super().__init__(R,
56-
index_set=index_set, central_elements=central_elements,
54+
index_set=index_set,
55+
central_elements=central_elements,
5756
category=category, element_class=element_class,
5857
prefix=prefix, **kwds)
5958
self._ngens = len(self._generators)
@@ -88,7 +87,7 @@ def _an_element_(self):
8887
"""
8988
return self.sum(self.gens())
9089

91-
def ngens(self):
90+
def ngens(self) -> int:
9291
"""
9392
The number of generators of this Lie conformal algebra.
9493
@@ -102,7 +101,7 @@ def ngens(self):
102101
return self._ngens
103102

104103
@cached_method
105-
def gens(self):
104+
def gens(self) -> tuple:
106105
"""
107106
The generators for this Lie conformal algebra.
108107
@@ -126,13 +125,14 @@ def gens(self):
126125
return self.lie_conformal_algebra_generators()
127126

128127
@cached_method
129-
def central_elements(self):
128+
def central_elements(self) -> tuple:
130129
"""
131130
The central elements of this Lie conformal algebra.
132131
133132
EXAMPLES::
134133
135-
sage: R = lie_conformal_algebras.NeveuSchwarz(QQ); R.central_elements()
134+
sage: R = lie_conformal_algebras.NeveuSchwarz(QQ)
135+
sage: R.central_elements()
136136
(C,)
137137
"""
138138
return tuple(FreelyGeneratedLieConformalAlgebra.central_elements(self))

src/sage/algebras/weyl_algebra.py

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1530,10 +1530,11 @@ def polynomial_gens(self):
15301530
True
15311531
"""
15321532
from sage.sets.non_negative_integers import NonNegativeIntegers
1533-
return Family(NonNegativeIntegers(), lambda x: self.gen(x), name=self.variable_names()[0])
1533+
return Family(NonNegativeIntegers(), lambda x: self.gen(x),
1534+
name=self.variable_names()[0])
15341535

15351536
@cached_method
1536-
def gens(self):
1537+
def gens(self) -> tuple:
15371538
"""
15381539
Return the algebra generators of ``self``.
15391540

src/sage/modular/abvar/homology.py

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -138,10 +138,11 @@ def __richcmp__(self, other, op):
138138
return richcmp((self.abelian_variety(), self.base_ring()),
139139
(other.abelian_variety(), other.base_ring()), op)
140140

141-
def _repr_(self):
141+
def _repr_(self) -> str:
142142
"""
143-
Return string representation of ``self``. This must be defined in the
144-
derived class.
143+
Return string representation of ``self``.
144+
145+
This must be defined in the derived class.
145146
146147
EXAMPLES::
147148
@@ -154,7 +155,7 @@ def _repr_(self):
154155
"""
155156
raise NotImplementedError("please override this in the derived class")
156157

157-
def gens(self):
158+
def gens(self) -> tuple:
158159
"""
159160
Return generators of ``self``.
160161

src/sage/modules/fg_pid/fgp_module.py

Lines changed: 16 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -1198,21 +1198,20 @@ def gens_vector(self, x, reduce=False):
11981198
11991199
We create a derived class and overwrite :meth:`gens`::
12001200
1201-
sage: from sage.modules.fg_pid.fgp_module import FGP_Module_class
1202-
sage: W = ZZ^3
1203-
sage: V = W.span(matrix.diagonal([1/6, 1/3, 1/12]))
1204-
sage: class FGP_with_gens(FGP_Module_class):
1205-
....: def __init__(self, V, W, gens):
1206-
....: FGP_Module_class.__init__(self, V, W)
1207-
....: self._gens = tuple([self(g) for g in gens])
1208-
....: def gens(self):
1209-
....: return self._gens
1210-
sage: gens = [(1/2, 0, 0), (0, 0, 1/4), (1/3, 0, 0), (0, 1/3, 0), (0, 0, 2/3)]
1211-
sage: gens = [V(g) for g in gens]
1212-
sage: D = FGP_with_gens(V, W, gens)
1213-
sage: D.gens()
1214-
((0, 3, 0), (0, 0, 3), (0, 4, 0), (1, 2, 0), (0, 0, 8))
1215-
1201+
sage: from sage.modules.fg_pid.fgp_module import FGP_Module_class
1202+
sage: W = ZZ^3
1203+
sage: V = W.span(matrix.diagonal([1/6, 1/3, 1/12]))
1204+
sage: class FGP_with_gens(FGP_Module_class):
1205+
....: def __init__(self, V, W, gens):
1206+
....: FGP_Module_class.__init__(self, V, W)
1207+
....: self._gens = tuple([self(g) for g in gens])
1208+
....: def gens(self) -> tuple:
1209+
....: return self._gens
1210+
sage: gens = [(1/2, 0, 0), (0, 0, 1/4), (1/3, 0, 0), (0, 1/3, 0), (0, 0, 2/3)]
1211+
sage: gens = [V(g) for g in gens]
1212+
sage: D = FGP_with_gens(V, W, gens)
1213+
sage: D.gens()
1214+
((0, 3, 0), (0, 0, 3), (0, 4, 0), (1, 2, 0), (0, 0, 8))
12161215
12171216
We create some element of ``D``::
12181217
@@ -1620,7 +1619,7 @@ def _hom_general(self, im_gens, check=True):
16201619
EXAMPLES::
16211620
16221621
sage: class SillyModule(sage.modules.fg_pid.fgp_module.FGP_Module_class):
1623-
....: def gens(self):
1622+
....: def gens(self) -> tuple:
16241623
....: return tuple(flatten([[x,x] for x in self.smith_form_gens()]))
16251624
sage: A = SillyModule(ZZ**1, span([[3]], ZZ))
16261625
sage: A.gen(0)
@@ -1662,7 +1661,7 @@ def _hom_from_smith(self, im_smith_gens, check=True):
16621661
EXAMPLES::
16631662
16641663
sage: class SillyModule(sage.modules.fg_pid.fgp_module.FGP_Module_class):
1665-
....: def gens(self):
1664+
....: def gens(self) -> tuple:
16661665
....: return tuple(flatten([[x,x] for x in self.smith_form_gens()]))
16671666
sage: A = SillyModule(ZZ**1, span([[3]], ZZ))
16681667
sage: A.gen(0)

src/sage/schemes/elliptic_curves/ell_finite_field.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -705,7 +705,7 @@ def cardinality_pari(self):
705705
return Integer(self.__pari__().ellcard())
706706

707707
@cached_method
708-
def gens(self):
708+
def gens(self) -> tuple:
709709
r"""
710710
Return points which generate the abelian group of points on
711711
this elliptic curve.
@@ -800,7 +800,7 @@ def gens(self):
800800
self._order = ZZ(card)
801801
pts = tuple(self.point(list(P)) for P in pts)
802802
if len(pts) >= 1:
803-
pts[0]._order = ZZ(ords[0]) # PARI documentation: "P is of order d_1"
803+
pts[0]._order = ZZ(ords[0]) # PARI documentation: "P is of order d_1"
804804
return pts
805805

806806
def __iter__(self):

0 commit comments

Comments
 (0)