Skip to content

Commit 771546f

Browse files
author
Release Manager
committed
Trac #33046: gap spkg creates absolute symlinks
In `gap/spkg-install` two absolute symlinks are created; this confuses packagers and relocation. The current ticket replaces them by relative symlinks. All the paths involved are hardcoded in this file (even `SAGE_BIN`), so nothing external can affect it. URL: https://trac.sagemath.org/33046 Reported by: tornaria Ticket author(s): Gonzalo Tornaría Reviewer(s): Matthias Koeppe
2 parents be94896 + 521a9ec commit 771546f

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

build/pkgs/gap/spkg-install.in

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -80,8 +80,8 @@ chmod +x "$SAGE_DESTDIR$SAGE_BIN/gap"
8080

8181
# Create symlinks under $GAP_ROOT for these executables, as they are expected
8282
# (especially when building kernel packages) to exist
83-
ln -sf "$SAGE_BIN/gap-bin" "$DESTDIR_GAP_ROOT/gap"
84-
ln -sf "$SAGE_BIN/gac" "$DESTDIR_GAP_ROOT/gac"
83+
ln -sf "../../bin/gap-bin" "$DESTDIR_GAP_ROOT/gap"
84+
ln -sf "../../bin/gac" "$DESTDIR_GAP_ROOT/gac"
8585

8686
# Fix the $GAP_ROOT/bin/<arch>/src symlink to be relative (otherwise it links
8787
# to the actual path of the sources GAP was compiled from)

0 commit comments

Comments
 (0)