PR #35891: fix more issues

Author: dcoudert

src/sage/algebras/fusion_rings/f_matrix.py

@@ -1726,11 +1726,11 @@ def _partition_eqns(self, eqns=None, verbose=True):
         if eqns is None:
             eqns = self.ideal_basis
         graph = self.equations_graph(eqns)
-        partition = {tuple(c): [] for c in graph.connected_components()}
+        partition = {tuple(c): [] for c in graph.connected_components(sort=True)}
         for eq_tup in eqns:
-            partition[tuple(graph.connected_component_containing_vertex(variables(eq_tup)[0]))].append(eq_tup)
+            partition[tuple(graph.connected_component_containing_vertex(variables(eq_tup)[0], sort=True))].append(eq_tup)
         if verbose:
-            print("Partitioned {} equations into {} components of size:".format(len(eqns), len(graph.connected_components())))
+            print("Partitioned {} equations into {} components of size:".format(len(eqns), graph.connected_components_number()))
             print(graph.connected_components_sizes())
         return partition
 

src/sage/geometry/polyhedron/base_QQ.py

@@ -1180,7 +1180,7 @@ class functions of the acting group. A character `\rho` is effective if
             True
             sage: Hstar = p3.Hstar_function(S3)                         # optional - pynormaliz
             sage: Hlin  = p3.Hstar_function(S3,                         # optional - pynormaliz
-            ....:                           output='Hstar_as_lin_comb')]
+            ....:                           output='Hstar_as_lin_comb')
             sage: p3.is_effective(Hstar, Hlin)                          # optional - pynormaliz
             True
 
@@ -1242,7 +1242,7 @@ class functions of the acting group. A character `\rho` is effective if
             sage: p2 = Polyhedron(vertices=[[0], [1/2]],                     # optional - pynormaliz
             ....:                 backend='normaliz')
             sage: Hstar    = p2.Hstar_function()                             # optional - pynormaliz
-            sage: Hstarlin = p2.Hstar_function(output='Hstar_as_lin_comb')]  # optional - pynormaliz
+            sage: Hstarlin = p2.Hstar_function(output='Hstar_as_lin_comb')   # optional - pynormaliz
             sage: p1._is_effective_normaliz(Hstar, Hstarlin)                 # optional - pynormaliz
             Traceback (most recent call last):
             ...

src/sage/matroids/linear_matroid.pyx

@@ -578,7 +578,7 @@ cdef class LinearMatroid(BasisExchangeMatroid):
             sage: M.representation(lift_map=lift_map('sru'))                            # optional - sage.rings.finite_rings
             [     1      0      0      1      0      1      1      1]
             [     0      1      0 -z + 1      1      0      0      1]
-            [     0      0      1      0     -z      z      1      0]
+            [     0      0      1      0      1      -1 z - 1      0]
         """
         cdef LeanMatrix A
         if order is None:

src/sage/matroids/matroid.pyx

@@ -6104,8 +6104,8 @@ cdef class Matroid(SageObject):
         entries = [(e, f, (e, f)) for e in basis for f in self._fundamental_cocircuit(basis, e).difference([e])]
         G = Graph(entries)
         T = set()
-        for C in G.connected_components():
-            T.update(G.subgraph(C).min_spanning_tree())
+        for C in G.connected_components_subgraphs():
+            T.update(C.min_spanning_tree())
         for edge in T:
             e,f = edge[2]
             A.set(bdx[e],idx[f], 1)

src/sage/matroids/utilities.py

@@ -391,8 +391,8 @@ def spanning_forest(M):
         G.add_edge(x + m, y)
     T = []
     # find spanning tree in each component
-    for component in G.connected_components():
-        spanning_tree = kruskal(G.subgraph(component))
+    for component in G.connected_components_subgraphs():
+        spanning_tree = kruskal(component)
         for (x, y, z) in spanning_tree:
             if x < m:
                 t = x
@@ -543,9 +543,9 @@ def lift_cross_ratios(A, lift_map=None):
         [0 6 3 6 0]
         sage: Z = lift_cross_ratios(A, to_sixth_root_of_unity)                          # optional - sage.graphs sage.rings.finite_rings sage.rings.number_field
         sage: Z                                                                         # optional - sage.graphs sage.rings.finite_rings sage.rings.number_field
-        [ 1  0  1  1  1]
-        [ 1  1  0  0  z]
-        [ 0 -1  z  1  0]
+        [     1      0      1      1      1]
+        [-z + 1      1      0      0      1]
+        [     0     -1      1 -z + 1      0]
         sage: M = LinearMatroid(reduced_matrix=A)                                       # optional - sage.graphs sage.rings.finite_rings
         sage: sorted(M.cross_ratios())                                                  # optional - sage.graphs sage.rings.finite_rings
         [3, 5]
@@ -568,8 +568,8 @@ def lift_cross_ratios(A, lift_map=None):
     G = Graph([((r, 0), (c, 1), (r, c)) for r, c in A.nonzero_positions()])
     # write the entries of (a scaled version of) A as products of cross ratios of A
     T = set()
-    for C in G.connected_components():
-        T.update(G.subgraph(C).min_spanning_tree())
+    for C in G.connected_components_subgraphs():
+        T.update(C.min_spanning_tree())
     # - fix a tree of the support graph G to units (= empty dict, product of 0 terms)
     F = {entry[2]: dict() for entry in T}
     W = set(G.edge_iterator()) - set(T)

src/sage/schemes/curves/zariski_vankampen.py

@@ -815,8 +815,9 @@ def geometric_basis(G, E, p):
             q = EC[-i]
             connecting_path = list(reversed(EC[-i:]))
             break
+    I_cc_q = set(I.connected_component_containing_vertex(q, sort=False))
     distancequotients = [(E.distance(q, v)**2 / I.distance(q, v), v) for v in E
-                         if v in I.connected_component_containing_vertex(q) and not v == q]
+                         if v in I_cc_q and not v == q]
     r = max(distancequotients)[1]
     cutpath = I.shortest_path(q, r)
     Gcut = copy(G)

src/sage/tests/books/computational-mathematics-with-sagemath/lp_doctest.py

@@ -221,7 +221,7 @@
 Sage example in ./lp.tex, line 906::
 
   sage: while not h.is_connected():
-  ....:     S = h.connected_components()[0]
+  ....:     S = h.connected_components(sort=False)[0]
   ....:     p.add_constraint(
   ....:            p.sum( B(u,v) for u,v
   ....:                 in g.edge_boundary(S, labels = False))

src/sage/topology/simplicial_complex.py

@@ -4078,7 +4078,7 @@ def connected_component(self, simplex=None):
             v = self.vertices()[0]
         else:
             v = simplex[0]
-        vertices = self.graph().connected_component_containing_vertex(v)
+        vertices = self.graph().connected_component_containing_vertex(v, sort=False)
         facets = [f for f in self.facets() if f.is_face(Simplex(vertices))]
         return SimplicialComplex(facets)
 

src/sage/topology/simplicial_set_constructions.py

@@ -1497,7 +1497,7 @@ def __init__(self, maps=None, vertex_name=None):
             for x in domain.n_cells(n):
                 edges.extend([[(x,-1), (f(x),i)] for (i,f) in enumerate(maps)])
             G = Graph([vertices, edges], format='vertices_and_edges')
-            data[n] = [set(_) for _ in G.connected_components()]
+            data[n] = [set(_) for _ in G.connected_components(sort=False)]
         # data is now a dictionary indexed by dimension, and data[n]
         # consists of sets of n-simplices of the domain and the
         # codomains, each set an equivalence class of n-simplices