Skip to content

Commit 7f85dca

Browse files
author
Release Manager
committed
gh-37328: remove "known bug" marker for #6413 from doctest The long-standing issue #6413 was resolved in #37096, but there is still one `# known bug` marker for it in `src/sage/schemes/elliptic_curves/hom_scalar.py`. Let's remove it. (Incidentally, the claimed output for the invocation that used to not work was slightly wrong, too.) URL: #37328 Reported by: Lorenz Panny Reviewer(s):
2 parents 721030b + d3433cf commit 7f85dca

File tree

1 file changed

+19
-4
lines changed

1 file changed

+19
-4
lines changed

src/sage/schemes/elliptic_curves/hom_scalar.py

Lines changed: 19 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -81,16 +81,31 @@
8181
sage: zero(E.random_point())
8282
(0 : 1 : 0)
8383
84-
Due to a bug (:trac:`6413`), retrieving multiplication-by-`m` maps
85-
when `m` is divisible by the characteristic currently fails::
84+
Retrieving multiplication-by-`m` maps when `m` is divisible by the
85+
characteristic also works (since :issue:`37096`)::
8686
8787
sage: E = EllipticCurve(GF(7), [1,0])
8888
sage: phi = E.scalar_multiplication(7); phi
8989
Scalar-multiplication endomorphism [7] of Elliptic Curve defined by y^2 = x^3 + x over Finite Field of size 7
90-
sage: phi.rational_maps() # known bug -- #6413
91-
(x^49, y^49)
90+
sage: phi.rational_maps()
91+
(x^49, -y^49)
9292
sage: phi.x_rational_map()
9393
x^49
94+
sage: psi = E.scalar_multiplication(-2); psi
95+
Scalar-multiplication endomorphism [-2] of Elliptic Curve defined by y^2 = x^3 + x over Finite Field of size 7
96+
sage: chi = E.scalar_multiplication(-14); chi
97+
Scalar-multiplication endomorphism [-14] of Elliptic Curve defined by y^2 = x^3 + x over Finite Field of size 7
98+
sage: chi == psi * phi
99+
True
100+
sage: chi.rational_maps()
101+
((x^196 - 2*x^98 + 1)/(-3*x^147 - 3*x^49),
102+
(-x^294*y^49 + 2*x^196*y^49 - 2*x^98*y^49 + y^49)/(-x^294 - 2*x^196 - x^98))
103+
sage: chi.x_rational_map()
104+
(2*x^196 + 3*x^98 + 2)/(x^147 + x^49)
105+
sage: chi.rational_maps() == tuple(f(*phi.rational_maps()) for f in psi.rational_maps())
106+
True
107+
sage: chi.x_rational_map() == psi.x_rational_map()(phi.x_rational_map())
108+
True
94109
95110
::
96111

0 commit comments

Comments
 (0)