Commit 8497e52
Release Manager
gh-40495: remove `unset TERM` when initializing non-interactive sage
<!-- ^ Please provide a concise and informative title. -->
<!-- ^ Don't put issue numbers in the title, do this in the PR
description below. -->
<!-- ^ For example, instead of "Fixes #12345" use "Introduce new method
to calculate 1 + 2". -->
<!-- v Describe your changes below in detail. -->
<!-- v Why is this change required? What problem does it solve? -->
<!-- v If this PR resolves an open issue, please link to it here. For
example, "Fixes #12345". -->
Sage unsets the environment variable `TERM`, which disables colored
output by default. This behavior also causes error for packages that
depend on `curses.setupterm` because `curses.setupterm` raises an error
when `TERM` is unset.
`pwntools` is also affected by this issue.
#39334
3-manifolds/Sage_macOS#78
The original issue #12263 is 13
years ago and has been [resolved](https://bugs.python.org/issue19884)
since python 3.5.
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. -->
- [x] The title is concise and informative.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation and checked the documentation
preview.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on. For example,
-->
<!-- - #12345: short description why this is a dependency -->
<!-- - #34567: ... -->
URL: #40495
Reported by: unprintable123
Reviewer(s):
1 file changed
+0
-2
lines changed| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
578 | 578 | | |
579 | 579 | | |
580 | 580 | | |
581 | | - | |
582 | 581 | | |
583 | 582 | | |
584 | 583 | | |
| |||
1116 | 1115 | | |
1117 | 1116 | | |
1118 | 1117 | | |
1119 | | - | |
1120 | 1118 | | |
1121 | 1119 | | |
1122 | 1120 | | |
0 commit comments