Skip to content

Commit 880ee64

Browse files
author
Release Manager
committed
gh-39278: Meson: build groups even without gap `group.pyx` compiles fine also without gap installed. <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #39278 Reported by: Tobias Diez Reviewer(s): Dima Pasechnik
2 parents 5069f3f + 47a5173 commit 880ee64

File tree

1 file changed

+5
-1
lines changed

1 file changed

+5
-1
lines changed

src/sage/groups/meson.build

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -38,13 +38,17 @@ extension_data = {
3838
}
3939

4040
foreach name, pyx : extension_data
41+
deps = [py_dep, gmp]
42+
if name == 'libgap_wrapper'
43+
deps += [gap]
44+
endif
4145
py.extension_module(
4246
name,
4347
sources: pyx,
4448
subdir: 'sage/groups',
4549
install: true,
4650
include_directories: [inc_cpython],
47-
dependencies: [py_dep, gmp, gap],
51+
dependencies: deps,
4852
)
4953
endforeach
5054

0 commit comments

Comments
 (0)