You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gh-35773: Document that GLPK/exact can be inexact
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes#12345", use "Add a new method to
multiply two integers" -->
### 📚 Description
The GLPK/exact linear programming (LP) backend isn't exact because
rationals are converted to doubles to be passed to the backend. This
means that, despite solving LPs exactly over the rationals, the solver
can silently solve a rounded version of your LP. For example,
coefficients of 1/3 are handled incorrectly as they are rounded to some
0.3333333ish number that fits in a double-precision float.
This PR simply expands the relevant documentation to explain more
carefully that this can lead to problems. Fixes#35727.
The modified files lie in the ```src/``` subdirectory, are changes
required to files with the same relative path under such as
```/build/pkgs/sagemath_environment/...```,
```build/pkgs/sagemath_repl/...```, and ```pkgs/sagemath-repl/...```?
<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes#12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: #35773
Reported by: Ewan Davies
Reviewer(s): Ewan Davies, Matthias Köppe
0 commit comments