You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
gh-35855: Extend MAX_MODULUS of matrix_modn_dense_double.pyx
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes#12345", use "Add a new method to
multiply two integers" -->
### 📚 Description
<!-- Describe your changes here in detail. -->
Assign to `MAX_MODULUS` of `matrix_modn_dense_double.pyx` the actual
limit for LinBox `Modular<double>` (Givaro's `maxCardinality`)
<!-- Why is this change required? What problem does it solve? -->
It allows better speed performances for matrices over the integers mod
N, for N having 24 to 27 bits.
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes#12345". -->
Fixes#35806
<!-- If your change requires a documentation PR, please link it
appropriately. -->
### 📝 Checklist
<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->
- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [x] I have linked a relevant issue or discussion.
- [x] I have created tests covering the changes.
- [x] I have updated the documentation accordingly.
### ⌛ Dependencies
<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->
<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
URL: #35855
Reported by: Marie Bonboire
Reviewer(s): Vincent Neiger
0 commit comments