Skip to content

Commit 92bd273

Browse files
author
Release Manager
committed
Trac #33138: Fix SAGE_FAT_BINARY regression for numpy ("Ignoring --build-option when building numpy using PEP 517")
Seen in https://trac.sagemath.org/attachment/ticket/33070/numpy-1.21.4.log The change made as part of #32046, using `pip wheel --build-option ...` (instead of `setup.py bdist_wheel...`) seems to have broken the use of said build options when the package is a PEP 517 package (i.e., has `pyproject.toml`) Among the packages found by `git grep sdh_prefix`, only **numpy** is affected (the others, `python_igraph`, `jupyter_jsmol`, `pillow`, do not have `pyproject.toml`). The build options for numpy are in particular needed for `SAGE_FAT_BINARY=yes` builds. This would explain the segfaults (again!) in the multi-stage Cygwin build, triggered by plots in doctests - https://github.com/sagemath/sage/runs/4768915607?check_suite_focus=true (Hence "blocker" for Sage 9.5.) Also fixes a build problem on `alpine-standard` (#33083) URL: https://trac.sagemath.org/33138 Reported by: mkoeppe Ticket author(s): Matthias Koeppe Reviewer(s): Dima Pasechnik
2 parents 1646859 + 455e1fa commit 92bd273

File tree

1 file changed

+3
-1
lines changed

1 file changed

+3
-1
lines changed

build/pkgs/numpy/spkg-install.in

Lines changed: 3 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
# -*- shell-script -*-
12
cd src
23

34
set -e
@@ -39,6 +40,7 @@ fi
3940

4041
################################################
4142

42-
eval sdh_pip_install \
43+
# Trac #33138: numpy is a PEP 517 package, so the crucial "--build-option"s would be ignored.
44+
eval sdh_pip_install --no-use-pep517 \
4345
$(eval sdh_prefix_args "--build-option" build ${NUMPY_CONFIG} ${NUMPY_FCONFIG}) \
4446
.

0 commit comments

Comments
 (0)