Trac #34443: less exclamation marks in error messages

Release Manager · Release Manager · commit 9b4c61aecba0 · 2022-08-30T08:46:28.000+02:00
URL: https://trac.sagemath.org/34443 Reported by: chapoton Ticket author(s): Frédéric Chapoton Reviewer(s): Kwankyu Lee
diff --git a/src/sage/categories/crystals.py b/src/sage/categories/crystals.py
@@ -1583,12 +1583,12 @@ def to_highest_weight(self, index_set=None):
                 sage: t.to_highest_weight()
                 Traceback (most recent call last):
                 ...
-                ValueError: This is not a highest weight crystals!
+                ValueError: this is not a highest weight crystal
             """
             from sage.categories.highest_weight_crystals import HighestWeightCrystals
             if index_set is None:
                 if HighestWeightCrystals() not in self.parent().categories():
-                    raise ValueError("This is not a highest weight crystals!")
+                    raise ValueError("this is not a highest weight crystal")
                 index_set = self.index_set()
             for i in index_set:
                 next = self.e(i)
@@ -1624,12 +1624,12 @@ def to_lowest_weight(self, index_set=None):
                 sage: t.to_lowest_weight()
                 Traceback (most recent call last):
                 ...
-                ValueError: This is not a highest weight crystals!
+                ValueError: this is not a highest weight crystal
             """
             from sage.categories.highest_weight_crystals import HighestWeightCrystals
             if index_set is None:
                 if HighestWeightCrystals() not in self.parent().categories():
-                    raise ValueError("This is not a highest weight crystals!")
+                    raise ValueError("this is not a highest weight crystal")
                 index_set = self.index_set()
             for i in index_set:
                 next = self.f(i)
diff --git a/src/sage/categories/finite_coxeter_groups.py b/src/sage/categories/finite_coxeter_groups.py
@@ -14,6 +14,7 @@
 from sage.categories.category_with_axiom import CategoryWithAxiom
 from sage.categories.coxeter_groups import CoxeterGroups
 
+
 class FiniteCoxeterGroups(CategoryWithAxiom):
     r"""
     The category of finite Coxeter groups.
@@ -828,11 +829,11 @@ def coxeter_knuth_neighbor(self, w):
                 sage: w.coxeter_knuth_neighbor(word)
                 Traceback (most recent call last):
                 ...
-                NotImplementedError: This has only been implemented in finite type A so far!
+                NotImplementedError: this has only been implemented in finite type A so far
             """
             C = self.parent().cartan_type()
             if not C[0] == 'A':
-                raise NotImplementedError("This has only been implemented in finite type A so far!")
+                raise NotImplementedError("this has only been implemented in finite type A so far")
             d = []
             for i in range(2,len(w)):
                 v = [j for j in w]
@@ -890,7 +891,7 @@ def coxeter_knuth_graph(self):
                 sage: w.coxeter_knuth_graph()
                 Traceback (most recent call last):
                 ...
-                NotImplementedError: This has only been implemented in finite type A so far!
+                NotImplementedError: this has only been implemented in finite type A so far
             """
             from sage.graphs.graph import Graph
             R = [tuple(v) for v in self.reduced_words()]
diff --git a/src/sage/categories/finite_groups.py b/src/sage/categories/finite_groups.py
@@ -134,7 +134,7 @@ def cayley_graph_disabled(self, connecting_set=None):
             else:
                 for g in connecting_set:
                     if g not in self:
-                        raise RuntimeError("Each element of the connecting set must be in the group!")
+                        raise RuntimeError("each element of the connecting set must be in the group")
                 connecting_set = [self(g) for g in connecting_set]
             from sage.graphs.digraph import DiGraph
             arrows = {}
diff --git a/src/sage/coding/binary_code.pyx b/src/sage/coding/binary_code.pyx
@@ -777,7 +777,8 @@ cdef class BinaryCode:
             self.nwords = 2 * other_nwords
             nrows = self.nrows
             nwords = self.nwords
-        else: raise NotImplementedError("!")
+        else:
+            raise NotImplementedError
 
         if self.nrows >= self.radix or self.ncols > self.radix:
             raise NotImplementedError("Columns and rows are stored as ints. This code is too big.")
diff --git a/src/sage/combinat/designs/incidence_structures.py b/src/sage/combinat/designs/incidence_structures.py
@@ -1383,7 +1383,7 @@ def relabel(self, perm=None, inplace=True):
             raise ValueError("perm argument must be None, a list or a dictionary")
 
         if len(set(perm.values())) != len(perm):
-            raise ValueError("Two points are getting relabelled with the same name !")
+            raise ValueError("two points are getting relabelled with the same name")
 
         self._points = [perm[x] for x in self._points]
         if self._points == list(range(self.num_points())):
diff --git a/src/sage/combinat/designs/steiner_quadruple_systems.py b/src/sage/combinat/designs/steiner_quadruple_systems.py
@@ -741,10 +741,10 @@ def steiner_quadruple_system(n, check = False):
         nn = (n+10) // 12
         sqs = twelve_n_minus_ten(steiner_quadruple_system(nn, check = False))
     else:
-        raise ValueError("This shouldn't happen !")
+        raise ValueError("this should never happen")
 
     if check and not sqs.is_t_design(3,n,4,1):
-        raise RuntimeError("Something is very very wrong.")
+        raise RuntimeError("something is very very wrong")
 
     return sqs
 
diff --git a/src/sage/databases/sql_db.py b/src/sage/databases/sql_db.py
@@ -1254,8 +1254,7 @@ def get_skeleton(self, check=False):
             d = construct_skeleton(self)
             if d == self.__skeleton__:
                 return d
-            else:
-                raise RuntimeError("Skeleton structure is out of whack!")
+            raise RuntimeError("skeleton structure is out of whack")
         return self.__skeleton__
 
     def query(self, *args, **kwds):
diff --git a/src/sage/groups/cubic_braid.py b/src/sage/groups/cubic_braid.py
@@ -1872,7 +1872,7 @@ def classical_invariant_form(self):
             self._create_classical_realization()
 
         if self._classical_invariant_form is None:
-            raise ValueError("no classical invariant form defined!")
+            raise ValueError("no classical invariant form defined")
 
         return self._classical_invariant_form
 
diff --git a/src/sage/groups/generic.py b/src/sage/groups/generic.py
@@ -1140,7 +1140,7 @@ def linear_relation(P, Q, operation='+', identity=None, inverse=None, op=None):
                     m1 * h)
         except ValueError:
             pass  # to next h
-    raise ValueError("No solution found in linear_relation!")
+    raise ValueError("no solution found in linear_relation")
 
 ################################################################
 #
diff --git a/src/sage/libs/glpk/error.pyx b/src/sage/libs/glpk/error.pyx
@@ -29,10 +29,10 @@ class GLPKError(MIPSolverException):
     EXAMPLES::
 
         sage: from sage.libs.glpk.error import GLPKError
-        sage: raise GLPKError("trouble!")
+        sage: raise GLPKError("trouble")
         Traceback (most recent call last):
         ...
-        GLPKError: trouble!
+        GLPKError: trouble
     """
     pass
 
diff --git a/src/sage/matrix/matrix_integer_dense_hnf.py b/src/sage/matrix/matrix_integer_dense_hnf.py
@@ -617,7 +617,7 @@ def hnf_square(A, proof):
             # weird cases where the det is large.
             # E.g., matrix all of whose rows but 1 are multiplied by some
             # fixed scalar n.
-            raise NotImplementedError("fallback to PARI!")
+            raise NotImplementedError("fallback to PARI")
             # H = W.hermite_form(algorithm='pari')
     else:
         H = W._hnf_mod(2 * g)
diff --git a/src/sage/misc/dev_tools.py b/src/sage/misc/dev_tools.py
@@ -292,7 +292,7 @@ def find_object_modules(obj):
 
     if module_name:
         if module_name not in sys.modules:
-            raise ValueError("This should not happen!")
+            raise ValueError("this should never happen")
         d = sys.modules[module_name].__dict__
         matching = sorted(key for key in d if d[key] is obj)
         if matching:
diff --git a/src/sage/misc/lazy_format.py b/src/sage/misc/lazy_format.py
@@ -31,7 +31,7 @@ class LazyFormat(str):
 
         sage: class IDontLikeBeingPrinted():
         ....:     def __repr__(self):
-        ....:         raise ValueError("Don't ever try to print me !")
+        ....:         raise ValueError("do not ever try to print me")
 
     There is no error when binding a lazy format with the broken object::
 
@@ -40,7 +40,7 @@ class LazyFormat(str):
     The error only occurs upon printing::
 
         sage: lf
-        <repr(<sage.misc.lazy_format.LazyFormat at 0x...>) failed: ValueError: Don't ever try to print me !>
+        <repr(<sage.misc.lazy_format.LazyFormat at 0x...>) failed: ValueError: do not ever try to print me>
 
     .. rubric:: Common use case:
 
@@ -63,7 +63,7 @@ class LazyFormat(str):
         ....:                "%s doesn't contain 0"%IDontLikeBeingPrinted())
         Traceback (most recent call last):
         ...
-        ValueError: Don't ever try to print me !
+        ValueError: do not ever try to print me
 
     This behavior can induce major performance penalties when testing.
     Note that this issue does not impact the usual assert::
diff --git a/src/sage/modules/free_module.py b/src/sage/modules/free_module.py
@@ -727,7 +727,7 @@ def span(gens, base_ring=None, check=True, already_echelonized=False):
             gens = list(gens)
             R = base_ring
     except TypeError:
-        raise TypeError("generators must be given as an iterable structure!")
+        raise TypeError("generators must be given as an iterable structure")
 
     if R not in PrincipalIdealDomains():
         raise TypeError("The base_ring (= %s) must be a principal ideal "
diff --git a/src/sage/numerical/backends/generic_sdp_backend.pyx b/src/sage/numerical/backends/generic_sdp_backend.pyx
@@ -717,13 +717,12 @@ cpdef GenericSDPBackend get_solver(solver=None, base_ring=None):
         sage: from sage.numerical.backends.generic_sdp_backend import GenericSDPBackend
         sage: class MockSDPBackend(GenericSDPBackend):
         ....:     def solve(self):
-        ....:         raise RuntimeError("SDP is too slow!")
+        ....:         raise RuntimeError("SDP is too slow")
         sage: P = SemidefiniteProgram(solver=MockSDPBackend)
         sage: P.solve()
         Traceback (most recent call last):
         ...
-        RuntimeError: SDP is too slow!
-
+        RuntimeError: SDP is too slow
     """
     if solver is None:
         solver = default_sdp_solver()
diff --git a/src/sage/numerical/optimize.py b/src/sage/numerical/optimize.py
@@ -926,7 +926,7 @@ def binpacking(items, maximum=1, k=None, solver=None, verbose=0,
         sage: binpacking([0.2,0.3,0.8,0.9], k=2)
         Traceback (most recent call last):
         ...
-        ValueError: this problem has no solution !
+        ValueError: this problem has no solution
 
     We can also provide a dictionary keyed by items and associating to each item
     its weight. Then, the bins contain the name of the items inside it ::
@@ -953,7 +953,7 @@ def binpacking(items, maximum=1, k=None, solver=None, verbose=0,
         raise TypeError("parameter items must be a list or a dictionary.")
 
     if max(weight.values()) > maximum:
-        raise ValueError("this problem has no solution !")
+        raise ValueError("this problem has no solution")
 
     if k is None:
         from sage.functions.other import ceil
@@ -983,7 +983,7 @@ def binpacking(items, maximum=1, k=None, solver=None, verbose=0,
     try:
         p.solve(log=verbose)
     except MIPSolverException:
-        raise ValueError("this problem has no solution !")
+        raise ValueError("this problem has no solution")
 
     box = p.get_values(box, convert=bool, tolerance=integrality_tolerance)
 
diff --git a/src/sage/quivers/representation.py b/src/sage/quivers/representation.py
@@ -776,7 +776,7 @@ def create_object(self, version, key, **extra_args):
             Representation with dimension vector (0, 0)
         """
         if len(key) < 4:
-            raise ValueError("invalid key used in QuiverRepFactory!")
+            raise ValueError("invalid key used in QuiverRepFactory")
 
         # Get the quiver
         P = key[1]
@@ -807,8 +807,7 @@ def create_object(self, version, key, **extra_args):
             # Create and return the module
             return QuiverRep_with_dual_path_basis(key[0], P, key[3])
 
-        else:
-            raise ValueError("invalid key used in QuiverRepFactory!")
+        raise ValueError("invalid key used in QuiverRepFactory")
 
 
 QuiverRep = QuiverRepFactory("sage.quivers.representation.QuiverRep")
diff --git a/src/sage/schemes/toric/divisor_class.pyx b/src/sage/schemes/toric/divisor_class.pyx
@@ -33,7 +33,7 @@ They behave much like ordinary vectors::
     sage: D * E
     Traceback (most recent call last):
     ...
-    TypeError: cannot multiply two divisor classes!
+    TypeError: cannot multiply two divisor classes
 
 The only special method is :meth:`~ToricRationalDivisorClass.lift` to get a
 divisor representing a divisor class::
@@ -163,7 +163,7 @@ cdef class ToricRationalDivisorClass(Vector_rational_dense):
             sage: D * D
             Traceback (most recent call last):
             ...
-            TypeError: cannot multiply two divisor classes!
+            TypeError: cannot multiply two divisor classes
 
         We test standard behaviour::
 
@@ -223,13 +223,13 @@ cdef class ToricRationalDivisorClass(Vector_rational_dense):
             sage: c[0]._dot_product_(c[1])
             Traceback (most recent call last):
             ...
-            TypeError: cannot multiply two divisor classes!
+            TypeError: cannot multiply two divisor classes
             sage: c[0] * c[1]      # indirect doctest
             Traceback (most recent call last):
             ...
-            TypeError: cannot multiply two divisor classes!
+            TypeError: cannot multiply two divisor classes
         """
-        raise TypeError("cannot multiply two divisor classes!")
+        raise TypeError("cannot multiply two divisor classes")
 
     def _latex_(self):
         r"""
diff --git a/src/sage/sets/family.py b/src/sage/sets/family.py
@@ -326,7 +326,7 @@ def Family(indices, function=None, hidden_keys=[], hidden_function=None, lazy=Fa
         sage: f = Family({1:'a', 2:'b', 3:'c'}, lazy=True)
         Traceback (most recent call last):
         ...
-        ValueError: lazy keyword only makes sense together with function keyword !
+        ValueError: lazy keyword only makes sense together with function keyword
 
     ::
 
@@ -386,7 +386,7 @@ def Family(indices, function=None, hidden_keys=[], hidden_function=None, lazy=Fa
                              "together with hidden_keys keyword !")
         if function is None:
             if lazy:
-                raise ValueError("lazy keyword only makes sense together with function keyword !")
+                raise ValueError("lazy keyword only makes sense together with function keyword")
             if isinstance(indices, dict):
                 return FiniteFamily(indices)
             if isinstance(indices, (list, tuple) ):
@@ -407,13 +407,14 @@ def Family(indices, function=None, hidden_keys=[], hidden_function=None, lazy=Fa
 
         return LazyFamily(indices, function, name)
     if lazy:
-        raise ValueError("lazy keyword is incompatible with hidden keys !")
+        raise ValueError("lazy keyword is incompatible with hidden keys")
     if hidden_function is None:
         hidden_function = function
     return FiniteFamilyWithHiddenKeys({i: function(i) for i in indices},
                                       hidden_keys, hidden_function,
                                       keys=indices)
 
+
 class AbstractFamily(Parent):
     """
     The abstract class for family
diff --git a/src/sage/structure/coerce.pyx b/src/sage/structure/coerce.pyx
@@ -962,7 +962,7 @@ cdef class CoercionModel:
                 all.append("Coercion on right operand via")
                 all.append(y_mor)
                 if res is not None and res is not y_mor.codomain():
-                    raise RuntimeError("BUG in coercion model: codomains not equal!", x_mor, y_mor)
+                    raise RuntimeError("BUG in coercion model: codomains not equal", x_mor, y_mor)
                 res = y_mor.codomain()
             all.append("Arithmetic performed after coercions.")
             if op is truediv and isinstance(res, Parent):

Original file line number	Diff line number	Diff line change
`@@ -1140,7 +1140,7 @@ def linear_relation(P, Q, operation='+', identity=None, inverse=None, op=None):`
`1140`	`1140`	`m1 * h)`
`1141`	`1141`	`except ValueError:`
`1142`	`1142`	`pass # to next h`
`1143`		`- raise ValueError("No solution found in linear_relation!")`
	`1143`	`+ raise ValueError("no solution found in linear_relation")`
`1144`	`1144`
`1145`	`1145`	`################################################################`
`1146`	`1146`	`#`