gh-35819: advance the linter (add more checks)
    
<!-- Please provide a concise, informative and self-explanatory title.
-->
<!-- Don't put issue numbers in the title. Put it in the Description
below. -->
<!-- For example, instead of "Fixes #12345", use "Add a new method to
multiply two integers" -->

### 📚 Description

this is adding a few checks to the pycodestyle linter, both for .py and
.pyx files

<!-- Describe your changes here in detail. -->
<!-- Why is this change required? What problem does it solve? -->
<!-- If this PR resolves an open issue, please link to it here. For
example "Fixes #12345". -->
<!-- If your change requires a documentation PR, please link it
appropriately. -->

### 📝 Checklist

<!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x
]`. -->

- [x] The title is concise, informative, and self-explanatory.
- [x] The description explains in detail what this PR is about.
- [ ] I have linked a relevant issue or discussion.
- [ ] I have created tests covering the changes.
- [ ] I have updated the documentation accordingly.

### ⌛ Dependencies

<!-- List all open PRs that this PR logically depends on
- #12345: short description why this is a dependency
- #34567: ...
-->

<!-- If you're unsure about any of these, don't hesitate to ask. We're
here to help! -->
    
URL: #35819
Reported by: Frédéric Chapoton
Reviewer(s): Matthias Köppe

Author: Release Manager

.vscode/settings.json

@@ -27,7 +27,7 @@
     "python.linting.enabled": true,
     // The following pycodestyle arguments are the same as the pycodestyle-minimal
     // tox environnment, see the file SAGE_ROOT/src/tox.ini
-    "python.linting.pycodestyleArgs": ["--select= E111,E211,E271,E303,E306,E401,E502,E701,E702,E703,E714,W291,W293,W391,W605,E711,E712,E713,E721,E722"],
+    "python.linting.pycodestyleArgs": ["--select= E111,E21,E222,E227,E251,E271,E303,E306,E401,E502,E701,E702,E703,E71,E72,W291,W293,W391,W605"],
     "cSpell.words": [
         "furo",
         "Conda",

src/doc/en/website/conf.py

@@ -21,7 +21,7 @@
 html_static_path = [] + html_common_static_path
 
 # General information about the project.
-project =  "Documentation"
+project = "Documentation"
 
 # The name for this set of Sphinx documents.
 html_title = project
@@ -33,8 +33,8 @@
 # Grouping the document tree into LaTeX files. List of tuples
 # (source start file, target name, title, author, document class [howto/manual]).
 latex_documents = [
-  ('index', 'sage_documentation.tex', 'Documentation',
-   'The Sage Development Team', 'manual'),
+    ('index', 'sage_documentation.tex', 'Documentation',
+     'The Sage Development Team', 'manual'),
 ]
 
 # Note that this effectively replaces the index.html generated from index.rst.

src/sage_docbuild/conf.py

@@ -716,7 +716,7 @@ def call_intersphinx(app, env, node, contnode):
     """
     debug_inf(app, "???? Trying intersphinx for %s" % node['reftarget'])
     builder = app.builder
-    res =  intersphinx.missing_reference(
+    res = intersphinx.missing_reference(
         app, env, node, contnode)
     if res:
         # Replace absolute links to $SAGE_DOC by relative links: this
@@ -738,7 +738,7 @@ def find_sage_dangling_links(app, env, node, contnode):
     debug_inf(app, "==================== find_sage_dangling_links ")
 
     reftype = node['reftype']
-    reftarget  = node['reftarget']
+    reftarget = node['reftarget']
     try:
         doc = node['refdoc']
     except KeyError:
@@ -754,17 +754,18 @@ def find_sage_dangling_links(app, env, node, contnode):
 
     res = call_intersphinx(app, env, node, contnode)
     if res:
-        debug_inf(app, "++ DONE %s"%(res['refuri']))
+        debug_inf(app, "++ DONE %s" % (res['refuri']))
         return res
 
-    if node.get('refdomain') != 'py': # not a python file
+    if node.get('refdomain') != 'py':  # not a python file
         return None
 
     try:
         module = node['py:module']
-        cls    = node['py:class']
+        cls = node['py:class']
     except KeyError:
-        debug_inf(app, "-- no module or class for :%s:%s"%(reftype, reftarget))
+        debug_inf(app, "-- no module or class for :%s:%s" % (reftype,
+                                                             reftarget))
         return None
 
     basename = reftarget.split(".")[0]
@@ -790,10 +791,10 @@ def find_sage_dangling_links(app, env, node, contnode):
     # adapted  from sphinx/domains/python.py
     builder = app.builder
     searchmode = node.hasattr('refspecific') and 1 or 0
-    matches =  builder.env.domains['py'].find_obj(
+    matches = builder.env.domains['py'].find_obj(
         builder.env, module, cls, newtarget, reftype, searchmode)
     if not matches:
-        debug_inf(app, "?? no matching doc for %s"%newtarget)
+        debug_inf(app, "?? no matching doc for %s" % newtarget)
         return call_intersphinx(app, env, node, contnode)
     elif len(matches) > 1:
         env.warn(target_module,

src/sage_setup/autogen/giacpy-mkkeywords.py

@@ -73,14 +73,14 @@
 s+='\n     You almost certainly want to use one of the derived class\n     :class:`Pygen`  instead.\n     """\n\n'
 Mi.write(s)
 
-for i in mostkeywords+moremethods:
+for i in mostkeywords + moremethods:
     p = Popen(["cas_help", i], stdout=PIPE, stderr=PIPE, universal_newlines=True)
     doc = p.communicate()[0]
 
     doc = doc.replace("\n", "\n        ")  # Indent doc
-    s =  "     def "+i+"(self,*args):\n"
-    s += "        r'''From Giac's documentation:\n        "+doc+"\n        '''\n"
-    s += "        return GiacMethods['"+i+"'](self,*args)\n\n"
+    s = "     def " + i + "(self,*args):\n"
+    s += "        r'''From Giac's documentation:\n        " + doc + "\n        '''\n"
+    s += "        return GiacMethods['" + i + "'](self,*args)\n\n"
     Mi.write(s)
 
 Mi.close()

src/tox.ini

@@ -126,8 +126,8 @@ description =
     # W605: invalid escape sequence ‘x’
     # See https://pycodestyle.pycqa.org/en/latest/intro.html#error-codes
 deps = pycodestyle
-commands = pycodestyle --select E111,E21,E227,E271,E303,E306,E401,E502,E701,E702,E703,E71,E72,W291,W293,W391,W605 {posargs:{toxinidir}/sage/}
-       pycodestyle --select E111,E306,E401,E703,W29,W391,W605,E712,E713,E714,E721,E722 --filename *.pyx {posargs:{toxinidir}/sage/}
+commands = pycodestyle --select E111,E21,E222,E227,E251,E271,E303,E306,E401,E502,E701,E702,E703,E71,E72,W291,W293,W391,W605 {posargs:{toxinidir}/sage/}
+       pycodestyle --select E111,E271,E306,E401,E703,E712,E713,E714,E72,W29,W391,W605, --filename *.pyx {posargs:{toxinidir}/sage/}
 
 [pycodestyle]
 max-line-length = 160