Skip to content

Commit a7252a6

Browse files
committed
suggested details
1 parent 8f37350 commit a7252a6

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

src/sage/plot/plot3d/parametric_plot3d.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -990,7 +990,7 @@ def g(x, y): return x, y+sin(y), x**2 + y**2
990990
f = tuple(f)
991991

992992
if isinstance(f, (list, tuple)) and f and isinstance(f[0], (list, tuple)):
993-
return sum([parametric_plot3d(v, urange, vrange, plot_points=plot_points, **kwds) for v in f])
993+
return sum(parametric_plot3d(v, urange, vrange, plot_points=plot_points, **kwds) for v in f)
994994

995995
if not isinstance(f, (tuple, list)) or len(f) != 3:
996996
raise ValueError("f must be a list, tuple, or vector of length 3")

src/sage/plot/plot3d/plot3d.py

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -190,8 +190,12 @@ def __init__(self, dep_var, indep_vars):
190190
Arbitrary Coordinates coordinate transform (z in terms of x, y)
191191
"""
192192
all_vars = sage_getargspec(self.transform).args[1:]
193-
if set(all_vars) != set(indep_vars + [dep_var]):
194-
raise ValueError('variables were specified incorrectly for this coordinate system; incorrect variables were %s' % list(set(all_vars).symmetric_difference(set(indep_vars + [dep_var]))))
193+
A = set(all_vars)
194+
B = set(indep_vars + [dep_var])
195+
if A != B:
196+
raise ValueError('variables were specified incorrectly for this '
197+
'coordinate system; incorrect variables '
198+
'were %s' % list(A.symmetric_difference(B)))
195199
self.dep_var = dep_var
196200
self.indep_vars = indep_vars
197201

src/sage/plot/plot3d/plot_field3d.py

Lines changed: 4 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -150,10 +150,12 @@ def cm(x):
150150
scaled_vectors = [v / max_len for v in vectors]
151151

152152
if center_arrows:
153-
G = sum([plot(v, color=cm(v.norm()), **kwds).translate(p - v / 2) for v, p in zip(scaled_vectors, points)])
153+
G = sum(plot(v, color=cm(v.norm()), **kwds).translate(p - v / 2)
154+
for v, p in zip(scaled_vectors, points))
154155
G._set_extra_kwds(kwds)
155156
return G
156157
else:
157-
G = sum([plot(v, color=cm(v.norm()), **kwds).translate(p) for v, p in zip(scaled_vectors, points)])
158+
G = sum(plot(v, color=cm(v.norm()), **kwds).translate(p)
159+
for v, p in zip(scaled_vectors, points))
158160
G._set_extra_kwds(kwds)
159161
return G

0 commit comments

Comments
 (0)