Skip to content

Commit a96a2a3

Browse files
author
Release Manager
committed
gh-39568: simplify empty sets by using `set()` ### 📝 Checklist - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. URL: #39568 Reported by: Frédéric Chapoton Reviewer(s): David Coudert
2 parents ea2ae54 + ab7ee7d commit a96a2a3

File tree

21 files changed

+60
-62
lines changed

21 files changed

+60
-62
lines changed

src/sage/algebras/orlik_solomon.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -192,7 +192,7 @@ def one_basis(self):
192192
193193
sage: M = matroids.Wheel(3)
194194
sage: OS = M.orlik_solomon_algebra(QQ)
195-
sage: OS.one_basis() == frozenset([])
195+
sage: OS.one_basis() == frozenset()
196196
True
197197
"""
198198
return frozenset({})
@@ -347,7 +347,7 @@ def subset_image(self, S):
347347
[[(1, 2), (1, 4), (2, 3), (3, 4)],
348348
[(3, 5), (3, 6), (5, 6)]]
349349
sage: OSMG = MG.orlik_solomon_algebra(QQ, ordering=s)
350-
sage: OSMG.subset_image(frozenset([]))
350+
sage: OSMG.subset_image(frozenset())
351351
OS{}
352352
sage: OSMG.subset_image(frozenset([(1,2),(3,4),(1,4),(2,3)]))
353353
0
@@ -375,7 +375,7 @@ def subset_image(self, S):
375375
[0, 3, 5], [1, 2, 4], [1, 2, 5], [1, 3, 4],
376376
[1, 3, 5], [2, 3], [4, 5]]
377377
sage: OSMG = MG.orlik_solomon_algebra(QQ)
378-
sage: OSMG.subset_image(frozenset([]))
378+
sage: OSMG.subset_image(frozenset())
379379
OS{}
380380
sage: OSMG.subset_image(frozenset([1, 2, 3]))
381381
0
@@ -394,7 +394,7 @@ def subset_image(self, S):
394394
sage: sorted([sorted(c) for c in MG.circuits()])
395395
[[0, 1], [2, 3, 4]]
396396
sage: OSMG = MG.orlik_solomon_algebra(QQ)
397-
sage: OSMG.subset_image(frozenset([]))
397+
sage: OSMG.subset_image(frozenset())
398398
OS{}
399399
sage: OSMG.subset_image(frozenset([1, 3, 4]))
400400
-OS{0, 2, 3} + OS{0, 2, 4}

src/sage/algebras/orlik_terao.py

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -242,7 +242,7 @@ def one_basis(self):
242242
243243
sage: M = matroids.Wheel(3)
244244
sage: OT = M.orlik_terao_algebra(QQ)
245-
sage: OT.one_basis() == frozenset([])
245+
sage: OT.one_basis() == frozenset()
246246
True
247247
"""
248248
return frozenset({})
@@ -391,7 +391,7 @@ def subset_image(self, S):
391391
[[(1, 2), (1, 4), (2, 3), (3, 4)],
392392
[(3, 5), (3, 6), (5, 6)]]
393393
sage: OT = M.orlik_terao_algebra(QQ, ordering=s)
394-
sage: OT.subset_image(frozenset([]))
394+
sage: OT.subset_image(frozenset())
395395
OT{}
396396
sage: OT.subset_image(frozenset([(1,2),(3,4),(1,4),(2,3)]))
397397
0
@@ -419,7 +419,7 @@ def subset_image(self, S):
419419
[0, 3, 5], [1, 2, 4], [1, 2, 5], [1, 3, 4],
420420
[1, 3, 5], [2, 3], [4, 5]]
421421
sage: OT = M.orlik_terao_algebra()
422-
sage: OT.subset_image(frozenset([]))
422+
sage: OT.subset_image(frozenset())
423423
OT{}
424424
sage: OT.subset_image(frozenset([1, 2, 3]))
425425
0
@@ -438,7 +438,7 @@ def subset_image(self, S):
438438
sage: sorted([sorted(c) for c in M.circuits()])
439439
[[0, 1], [2, 3, 4]]
440440
sage: OT = M.orlik_terao_algebra(QQ)
441-
sage: OT.subset_image(frozenset([]))
441+
sage: OT.subset_image(frozenset())
442442
OT{}
443443
sage: OT.subset_image(frozenset([1, 3, 4]))
444444
-OT{0, 2, 3} + OT{0, 2, 4}

src/sage/calculus/desolvers.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -913,7 +913,7 @@ def desolve_system(des, vars, ics=None, ivar=None, algorithm='maxima'):
913913

914914
if len(des) == 1 and algorithm == "maxima":
915915
return desolve_laplace(des[0], vars[0], ics=ics, ivar=ivar)
916-
ivars = set([])
916+
ivars = set()
917917
for i, de in enumerate(des):
918918
if not (isinstance(de, Expression) and de.is_relational()):
919919
des[i] = de == 0
@@ -1440,11 +1440,10 @@ def desolve_system_rk4(des, vars, ics=None, ivar=None, end_points=None, step=0.1
14401440
14411441
- Robert Marik (10-2009)
14421442
"""
1443-
14441443
if ics is None:
14451444
raise ValueError("No initial conditions, specify with ics=[x0,y01,y02,...].")
14461445

1447-
ivars = set([])
1446+
ivars = set()
14481447

14491448
for de in des:
14501449
ivars = ivars.union(set(de.variables()))

src/sage/combinat/root_system/pieri_factors.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -519,7 +519,7 @@ class PieriFactors_type_A_affine(PieriFactors_affine_type):
519519

520520
@staticmethod
521521
def __classcall__(cls, W, min_length=0, max_length=infinity,
522-
min_support=frozenset([]), max_support=None):
522+
min_support=frozenset(), max_support=None):
523523
r"""
524524
TESTS::
525525

src/sage/doctest/util.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -606,7 +606,7 @@ def make_recording_dict(D, st, gt):
606606
EXAMPLES::
607607
608608
sage: from sage.doctest.util import make_recording_dict
609-
sage: D = make_recording_dict({'a':4,'d':42},set([]),set(['not_here']))
609+
sage: D = make_recording_dict({'a':4,'d':42},set(),set(['not_here']))
610610
sage: sorted(D.items())
611611
[('a', 4), ('d', 42)]
612612
sage: D.got

src/sage/geometry/fan.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -636,7 +636,7 @@ def result():
636636
(len(cones), len(generating_cones)))
637637
elif discard_faces:
638638
cones = _discard_faces(cones)
639-
ray_set = set([])
639+
ray_set = set()
640640
for cone in cones:
641641
ray_set.update(cone.rays())
642642
if rays: # Preserve the initial order of rays, if they were given

src/sage/geometry/hasse_diagram.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -146,7 +146,7 @@ def default_face_constructor(atoms, coatoms, **kwds):
146146
atoms = atoms.intersection(coatom_to_atoms[coatom])
147147
H[atom] = (atoms, coatoms)
148148
# 8: compute the set G of minimal sets in H
149-
minimals = set([])
149+
minimals = set()
150150
while candidates:
151151
candidate = candidates.pop()
152152
atoms = H[candidate][0]

src/sage/geometry/hyperplane_arrangement/arrangement.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2199,7 +2199,7 @@ def poset_of_regions(self, B=None, numbered_labels=True):
21992199
while R:
22002200
# Transfer the "next step" to the "current step"
22012201
curTest = list(nextTest)
2202-
nextTest = set([])
2202+
nextTest = set()
22032203
# we want to test each region that we haven't hit yet
22042204
for r in R:
22052205
# Since it's graded, it suffices to look at the regions of the previous rank

src/sage/geometry/lattice_polytope.py

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -3945,11 +3945,10 @@ def skeleton_points(self, k=1):
39453945
"""
39463946
if k >= self.dim():
39473947
return list(range(self.npoints()))
3948-
skeleton = set([])
3948+
skeleton = set()
39493949
for face in self.faces(dim=k):
39503950
skeleton.update(face.ambient_point_indices())
3951-
skeleton = sorted(skeleton)
3952-
return skeleton
3951+
return sorted(skeleton)
39533952

39543953
def skeleton_show(self, normal=None):
39553954
r"""Show the graph of one-skeleton of this polytope.

src/sage/geometry/polyhedral_complex.py

Lines changed: 9 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -370,7 +370,7 @@ def cells(self, subcomplex=None) -> dict:
370370
for k in range(self._dim, -1, -1):
371371
if k in maximal_cells:
372372
if k not in cells:
373-
cells[k] = set([])
373+
cells[k] = set()
374374
cells[k].update(maximal_cells[k])
375375
if k in cells:
376376
for cell in cells[k]:
@@ -382,7 +382,7 @@ def cells(self, subcomplex=None) -> dict:
382382
covers[p] = []
383383
covers[p].append(cell)
384384
if (k-1) not in cells:
385-
cells[k-1] = set([])
385+
cells[k-1] = set()
386386
cells[k-1].add(p)
387387
self._face_poset = Poset(covers)
388388
self._cells = cells
@@ -1055,7 +1055,7 @@ def is_subcomplex(self, other) -> bool:
10551055
"""
10561056
other_cells = other.cells()
10571057
for (d, stratum) in self.maximal_cells().items():
1058-
if not stratum.issubset(other_cells.get(d, set([]))):
1058+
if not stratum.issubset(other_cells.get(d, set())):
10591059
return False
10601060
return True
10611061

@@ -1594,9 +1594,9 @@ def is_convex(self) -> bool:
15941594
# After making sure that the affine hulls of the cells are the same,
15951595
# it does not matter that is not full dimensional.
15961596
boundaries = self.relative_boundary_cells()
1597-
vertices = set([])
1598-
rays = set([])
1599-
lines = set([])
1597+
vertices = set()
1598+
rays = set()
1599+
lines = set()
16001600
for cell in boundaries:
16011601
# it suffices to consider only vertices on the boundaries
16021602
# Note that a line (as polyhedron) has vertex too
@@ -2055,7 +2055,7 @@ def add_cell(self, cell):
20552055
for facet in c.facets():
20562056
p = facet.as_polyhedron()
20572057
if d not in cells:
2058-
cells[d] = set([])
2058+
cells[d] = set()
20592059
if p not in cells[d]:
20602060
cells[d].add(p)
20612061
covers[p] = [c]
@@ -2358,7 +2358,7 @@ def subdivide(self, make_simplicial=False,
23582358
if new_rays:
23592359
raise ValueError("rays/lines cannot be used for subdivision")
23602360
# bounded version of `fan.subdivide`; not require rational.
2361-
vertices = set([])
2361+
vertices = set()
23622362
if make_simplicial and not self.is_simplicial_complex():
23632363
for p in self.maximal_cell_iterator():
23642364
for v in p.vertices_list():
@@ -2390,7 +2390,7 @@ def subdivide(self, make_simplicial=False,
23902390
raise ValueError("new vertices cannot be used for subdivision")
23912391
# mimic :meth:`~sage.geometry.fan <RationalPolyhedralFan>.subdivide`
23922392
# but here we allow for non-pointed cones, and we subdivide them.
2393-
rays_normalized = set([])
2393+
rays_normalized = set()
23942394
self_rays = []
23952395
cones = []
23962396
for p in self.maximal_cell_iterator():

0 commit comments

Comments
 (0)