Skip to content

Commit ad6faea

Browse files
Bruno-TTdimpase
authored andcommitted
fix cyclotomic field embedding bug + linter fix
1 parent 927ca2b commit ad6faea

File tree

1 file changed

+14
-6
lines changed

1 file changed

+14
-6
lines changed

src/sage/groups/matrix_gps/finitely_generated_gap.py

Lines changed: 14 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -904,10 +904,18 @@ def invariants_of_degree(self, deg, chi=None, R=None):
904904
if len(inv) == ms[deg]:
905905
break
906906
return list(inv)
907-
908-
def _new_invariant_is_linearly_independent(F, inv, R):
909-
if len(inv)==0: return True
910-
try:
911-
return PolynomialSequence(R, inv).coefficient_matrix()[0].rank() != PolynomialSequence(R, list(inv)+[F]).coefficient_matrix()[0].rank()
912-
except ValueError:
907+
908+
def _new_invariant_is_linearly_independent(F, invariants, R):
909+
"""
910+
EXAMPLES ::
911+
sage: gens = [matrix(QQ, [[-1,1],[-1,0]]), matrix(QQ, [[0,1],[1,0]])]
912+
sage: G = MatrixGroup(gens)
913+
sage: s = Sequence(G.invariants_of_degree(14))
914+
sage: s.coefficient_matrix()[0].rank()
915+
3
916+
sage: len(s)
917+
3
918+
"""
919+
if len(invariants)==0:
913920
return True
921+
return PolynomialSequence(invariants).coefficient_matrix()[0].rank() != PolynomialSequence(list(invariants)+[F]).coefficient_matrix()[0].rank()

0 commit comments

Comments
 (0)