Speed up binomial

Author: user202729

src/sage/arith/misc.py

@@ -3959,7 +3959,7 @@ def binomial(x, m, **kwds):
     P = parent(x)
     x = py_scalar_to_element(x)
 
-    # case 1: native binomial implemented on x
+    # case 1: native binomial implemented on x (see also dont_call_method_on_arg)
     try:
         return P(x.binomial(m, **kwds))
     except (AttributeError, TypeError):

src/sage/functions/other.py

@@ -1715,6 +1715,17 @@ def _binomial_sym(self, n, k):
         from sage.misc.misc_c import prod
         return prod(n - i for i in range(k)) / factorial(k)
 
+    def _method_arguments(self, n, k):
+        """
+        See :meth:`sage.symbolic.function.BuiltinFunction._method_arguments`.
+
+        TESTS::
+
+            sage: binomial._method_arguments(10, 5)
+            (10, 5)
+        """
+        return (n, k)
+
     def _eval_(self, n, k):
         """
         EXAMPLES::

src/sage/functions/transcendental.py

@@ -390,7 +390,7 @@ def _evalf_(self, n, x, parent=None, algorithm=None):
         """
         return _mpmath_utils_call(_mpmath_zeta, x, 1, n, parent=parent)
 
-    def _method_arguments(self, k, x, **args):
+    def _method_arguments(self, k, x):
         r"""
         TESTS::
 

src/sage/symbolic/function.pxd

@@ -12,7 +12,7 @@ cdef class Function(SageObject):
     cdef _register_function(self)
 
 cdef class BuiltinFunction(Function):
-    cdef object _preserved_arg
+    cdef int _preserved_arg  # 0 if none, otherwise in [1.._nargs], see function.pyx
     cdef _is_registered(self)
 
 cdef class GinacFunction(BuiltinFunction):

src/sage/symbolic/function.pyx

@@ -886,7 +886,7 @@ cdef class BuiltinFunction(Function):
             sage: c(pi/2)                                                               # needs sage.symbolic
             0
         """
-        self._preserved_arg = preserved_arg
+        self._preserved_arg = 0 if preserved_arg is None else preserved_arg
         if preserved_arg and (preserved_arg < 1 or preserved_arg > nargs):
             raise ValueError("preserved_arg must be between 1 and nargs")
 
@@ -913,6 +913,13 @@ cdef class BuiltinFunction(Function):
         univariate functions. Multivariate symbolic functions should override
         it as appropriate.
 
+        Note that it is mandatory for multivariate symbolic functions to
+        override this function in order to allow delegating to the method
+        implemented on the element.
+        For example, ``binomial(n, k)`` tries to call ``n.binomial(k)``
+        because :meth:`sage.functions.other.Function_binomial._method_arguments`
+        is implemented.
+
         EXAMPLES::
 
             sage: zeta._method_arguments(1)
@@ -983,7 +990,7 @@ cdef class BuiltinFunction(Function):
             'foo'
         """
         res = None
-        if args and not hold:
+        if args and not hold and not all(isinstance(arg, Element) for arg in args):
             # try calling the relevant math, cmath, mpmath or numpy function.
             # And as a fallback try the custom self._eval_numpy_ or
             # self._eval_mpmath_
@@ -1046,8 +1053,6 @@ cdef class BuiltinFunction(Function):
                 res = super().__call__(
                         *args, coerce=coerce, hold=hold)
 
-        # Convert the output back to the corresponding
-        # Python type if possible.
         if any(isinstance(x, Element) for x in args):
             if (self._preserved_arg
                     and isinstance(args[self._preserved_arg-1], Element)):
@@ -1072,6 +1077,8 @@ cdef class BuiltinFunction(Function):
         if not isinstance(res, Element):
             return res
 
+        # Convert the output back to the corresponding
+        # Python type if possible.
         p = res.parent()
         from sage.rings.complex_double import CDF
         from sage.rings.integer_ring import ZZ