Trac #32969: some better join in interfaces

by not creating the list inside

URL: https://trac.sagemath.org/32969
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Travis Scrimshaw

Author: Release Manager

build/pkgs/configure/checksums.ini

@@ -1,4 +1,4 @@
 tarball=configure-VERSION.tar.gz
-sha1=057437b5e5bab8926f67bd7432313de683cc63e6
-md5=56ad13309a61651f6bfeeec6ed49f7fb
-cksum=6130847
+sha1=e91d5d21b1f380ffc009a982d7901bcf3ecc1b9c
+md5=c966742e8e0366a77a701676271871d1
+cksum=1159564180

build/pkgs/configure/package-version.txt

@@ -1 +1 @@
-d4c93a599a2ead241667eb099f64b0bb218c3cbc
+cd2e194635d95e9f3d1337e842265ba9175fd797

src/sage/interfaces/gap.py

@@ -1516,9 +1516,9 @@ def __getitem__(self, n):
         """
         self._check_valid()
         if not isinstance(n, tuple):
-            return self.parent().new('%s[%s]'%(self._name, n))
-        else:
-            return self.parent().new('%s%s'%(self._name, ''.join(['[%s]'%x for x in n])))
+            return self.parent().new('%s[%s]' % (self._name, n))
+        return self.parent().new('%s%s' % (self._name,
+                                           ''.join('[%s]' % x for x in n)))
 
     def str(self, use_file=False):
         """

src/sage/interfaces/gap3.py

@@ -725,9 +725,9 @@ def __getitem__(self, n):
         """
         gap3_session = self._check_valid()
         if not isinstance(n, tuple):
-            return gap3_session.new('%s[%s]'%(self.name(), n))
-        else:
-            return gap3_session.new('%s%s'%(self.name(), ''.join(['[%s]'%x for x in n])))
+            return gap3_session.new('%s[%s]' % (self.name(), n))
+        return gap3_session.new('%s%s' % (self.name(),
+                                          ''.join('[%s]' % x for x in n)))
 
     def _latex_(self):
         r"""

src/sage/interfaces/lie.py

@@ -717,7 +717,7 @@ def function_call(self, function, args=None, kwds=None):
         # than a LiEElement
         if function in ['diagram', 'setdefault', 'print_tab', 'type', 'factor', 'void', 'gcol']:
             args, kwds = self._convert_args_kwds(args, kwds)
-            cmd = "%s(%s)" % (function, ",".join([s.name() for s in args]))
+            cmd = "%s(%s)" % (function, ",".join(s.name() for s in args))
             return AsciiArtString(self.eval(cmd))
 
         return Expect.function_call(self, function, args, kwds)

src/sage/interfaces/lisp.py

@@ -381,7 +381,7 @@ def function_call(self, function, args=None, kwds=None):
         """
         args, kwds = self._convert_args_kwds(args, kwds)
         self._check_valid_function_name(function)
-        return self.new("(%s %s)"%(function, ",".join([s.name() for s in args])))
+        return self.new("(%s %s)" % (function, ",".join(s.name() for s in args)))
 
 
 # Inherit from RingElement to make __pow__ work

src/sage/interfaces/macaulay2.py

@@ -694,7 +694,7 @@ def ideal(self, *gens):
                 gens2.append(self(g))
             else:
                 gens2.append(g)
-        return self('ideal {%s}'%(",".join([g.name() for g in gens2])))
+        return self('ideal {%s}' % (",".join(g.name() for g in gens2)))
 
     def ring(self, base_ring='ZZ', vars='[x]', order='Lex'):
         r"""

src/sage/interfaces/magma.py

@@ -1154,10 +1154,10 @@ def function_call(self, function, args=[], params={}, nvals=1):
         if len(params) == 0:
             par = ''
         else:
-            par = ' : ' + ','.join(['%s:=%s' % (a, b.name())
-                                    for a, b in params.items()])
+            par = ' : ' + ','.join('%s:=%s' % (a, b.name())
+                                   for a, b in params.items())
 
-        fun = "%s(%s%s)" % (function, ",".join([s.name() for s in args]), par)
+        fun = "%s(%s%s)" % (function, ",".join(s.name() for s in args), par)
 
         return self._do_call(fun, nvals)
 
@@ -1266,9 +1266,9 @@ def bar_call(self, left, name, gens, nvals=1):
         magma = self
         # coerce each arg to be a Magma element
         if isinstance(gens, (list, tuple)):
-            gens = [magma(z) for z in gens]
+            gens = (magma(z) for z in gens)
             # make comma separated list of names (in Magma) of each of the gens
-            v = ', '.join([w.name() for w in gens])
+            v = ', '.join(w.name() for w in gens)
         else:
             gens = magma(gens)
             v = gens.name()

src/sage/interfaces/maxima_abstract.py

@@ -709,7 +709,7 @@ def plot2d(self, *args):
 
         The eps file is saved in the current directory.
         """
-        self('plot2d(%s)'%(','.join([str(x) for x in args])))
+        self('plot2d(%s)' % (','.join(str(x) for x in args)))
 
     def plot2d_parametric(self, r, var, trange, nticks=50, options=None):
         r"""
@@ -780,7 +780,7 @@ def plot3d(self, *args):
 
         The eps file is saved in the current working directory.
         """
-        self('plot3d(%s)'%(','.join([str(x) for x in args])))
+        self('plot3d(%s)' % (','.join(str(x) for x in args)))
 
     def plot3d_parametric(self, r, vars, urange, vrange, options=None):
         r"""

src/sage/interfaces/maxima_lib.py

@@ -91,8 +91,8 @@
 #
 #  The full text of the GPL is available at:
 #
-#                  http://www.gnu.org/licenses/
-#*****************************************************************************
+#                  https://www.gnu.org/licenses/
+# ****************************************************************************
 
 from sage.symbolic.ring import SR
 
@@ -105,8 +105,8 @@
 from sage.env import MAXIMA_FAS
 
 
-## We begin here by initializing Maxima in library mode
-## i.e. loading it into ECL
+# We begin here by initializing Maxima in library mode
+# i.e. loading it into ECL
 ecl_eval("(setf *load-verbose* NIL)")
 if MAXIMA_FAS:
     ecl_eval("(require 'maxima \"{}\")".format(MAXIMA_FAS))
@@ -119,7 +119,7 @@
 ecl_eval("(set-pathnames)")
 ecl_eval("(defun add-lineinfo (x) x)")
 ecl_eval('(defun principal nil (cond ($noprincipal (diverg)) ((not pcprntd) (merror "Divergent Integral"))))')
-ecl_eval("(remprop 'mfactorial 'grind)") # don't use ! for factorials (#11539)
+ecl_eval("(remprop 'mfactorial 'grind)")  # don't use ! for factorials (#11539)
 ecl_eval("(setf $errormsg nil)")
 
 # The following is an adaptation of the "retrieve" function in maxima
@@ -1695,7 +1695,7 @@ def max_to_sr(expr):
             max_sym_dict[expr]=sage_symbol
         return max_sym_dict[expr]
     else:
-        e=expr.python()
-        if isinstance(e,float):
+        e = expr.python()
+        if isinstance(e, float):
             return sage.rings.real_double.RealDoubleElement(e)
         return e