Skip to content

Commit bcb02fe

Browse files
author
Release Manager
committed
gh-35099: sage.{coding,groups}: Replace imports from sage.*.all for namespace packages <!-- ^^^^^ Please provide a concise, informative and self-explanatory title. Don't put issue numbers in there, do this in the PR body below. For example, instead of "Fixes #1234" use "Introduce new method to calculate 1+1" --> ### 📚 Description Fixes #34948 <!-- Describe your changes here in detail --> <!-- Why is this change required? What problem does it solve? --> <!-- If it resolves an open issue, please link to the issue here. For example "Closes #1337" --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> <!-- If your change requires a documentation PR, please link it appropriately --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> - [x] I have made sure that the title is self-explanatory and the description concisely explains the PR. - [x] I have linked an issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open pull requests that this PR logically depends on --> <!-- - #xyz: short description why this is a dependency - #abc: ... --> URL: #35099 Reported by: Matthias Köppe Reviewer(s): Dima Pasechnik
2 parents 2f2ed01 + cec7c2f commit bcb02fe

22 files changed

+91
-83
lines changed

src/sage/coding/bch_code.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -27,8 +27,8 @@
2727
from sage.modules.free_module_element import vector
2828
from sage.misc.misc_c import prod
2929
from sage.categories.fields import Fields
30-
from sage.arith.all import gcd
31-
from sage.rings.all import Zmod
30+
from sage.arith.misc import gcd
31+
from sage.rings.finite_rings.integer_mod_ring import IntegerModRing as Zmod
3232

3333
from .cyclic_code import CyclicCode
3434
from .grs_code import GeneralizedReedSolomonCode

src/sage/coding/binary_code.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4103,7 +4103,7 @@ cdef class BinaryCodeClassifier:
41034103
m = BinaryCode(matrix(ZZ, rs))
41044104

41054105
m_aut_gp_gens, m_labeling, m_size, m_base = self._aut_gp_and_can_label(m)
4106-
from sage.arith.all import factorial
4106+
from sage.arith.misc import factorial
41074107
if True: # size*factorial(n-B.ncols) == m_size:
41084108

41094109
if len(m_aut_gp_gens) == 0:

src/sage/coding/code_bounds.py

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -173,11 +173,14 @@
173173
# https://www.gnu.org/licenses/
174174
# ****************************************************************************
175175

176+
from sage.arith.misc import binomial, is_prime_power
176177
from sage.libs.gap.libgap import libgap
177-
from sage.rings.all import QQ, RR, ZZ, RDF
178-
from sage.arith.misc import is_prime_power
179-
from sage.arith.all import binomial
180178
from sage.misc.functional import sqrt, log
179+
from sage.rings.integer_ring import ZZ
180+
from sage.rings.rational_field import QQ
181+
from sage.rings.real_double import RDF
182+
from sage.rings.real_mpfr import RR
183+
181184
from .delsarte_bounds import (delsarte_bound_hamming_space,
182185
delsarte_bound_additive_hamming_space)
183186
from sage.features.gap import GapPackage

src/sage/coding/code_constructions.py

Lines changed: 6 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -40,20 +40,17 @@
4040
# https://www.gnu.org/licenses/
4141
# ****************************************************************************
4242

43-
from sage.misc.misc_c import prod
44-
from sage.arith.all import quadratic_residues, gcd
45-
46-
from sage.structure.sequence import Sequence, Sequence_generic
47-
48-
from sage.matrix.matrix_space import MatrixSpace
43+
from sage.arith.misc import gcd, quadratic_residues
4944
from sage.matrix.constructor import matrix
45+
from sage.matrix.matrix_space import MatrixSpace
5046
from sage.matrix.special import random_matrix
51-
47+
from sage.misc.misc_c import prod
5248
from sage.rings.finite_rings.finite_field_constructor import FiniteField as GF
5349
from sage.rings.finite_rings.integer_mod import Mod
5450
from sage.rings.finite_rings.integer_mod_ring import IntegerModRing
55-
from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
5651
from sage.rings.integer import Integer
52+
from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
53+
from sage.structure.sequence import Sequence, Sequence_generic
5754

5855
from .linear_code import LinearCode
5956

@@ -753,7 +750,7 @@ def ToricCode(P,F):
753750
754751
- David Joyner (07-2006)
755752
"""
756-
from sage.combinat.all import Tuples
753+
from sage.combinat.tuple import Tuples
757754
mset = [x for x in F if x != 0]
758755
d = len(P[0])
759756
pts = Tuples(mset, d).list()

src/sage/coding/cyclic_code.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -41,11 +41,11 @@
4141
from copy import copy
4242
from sage.rings.integer import Integer
4343
from sage.categories.homset import Hom
44-
from sage.arith.all import gcd
44+
from sage.arith.misc import gcd
4545
from sage.modules.free_module_element import vector
4646
from sage.matrix.constructor import matrix
4747
from sage.misc.cachefunc import cached_method
48-
from sage.rings.all import Zmod
48+
from sage.rings.finite_rings.integer_mod_ring import IntegerModRing as Zmod
4949

5050

5151
def find_generator_polynomial(code, check=True):

src/sage/coding/delsarte_bounds.py

Lines changed: 3 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -102,7 +102,7 @@ def krawtchouk(n, q, l, x, check=True):
102102
...
103103
TypeError: no conversion of this rational to integer
104104
"""
105-
from sage.arith.all import binomial
105+
from sage.arith.misc import binomial
106106
from sage.arith.srange import srange
107107
# Use the expression in equation (55) of MacWilliams & Sloane, pg 151
108108
# We write jth term = some_factor * (j-1)th term
@@ -171,7 +171,7 @@ def eberlein(n, w, k, u, check=True):
171171
TypeError: either m or x-m must be an integer
172172
173173
"""
174-
from sage.arith.all import binomial
174+
from sage.arith.misc import binomial
175175
from sage.arith.srange import srange
176176

177177
if 2*w > n:
@@ -275,7 +275,7 @@ def _delsarte_cwc_LP_building(n, d, w, solver, isinteger):
275275
276276
"""
277277
from sage.numerical.mip import MixedIntegerLinearProgram
278-
from sage.arith.all import binomial
278+
from sage.arith.misc import binomial
279279

280280
p = MixedIntegerLinearProgram(maximization=True, solver=solver)
281281
A = p.new_variable(integer=isinteger, nonnegative=True)
@@ -602,7 +602,6 @@ def _delsarte_Q_LP_building(q, d, solver, isinteger):
602602
EXAMPLES::
603603
604604
sage: from sage.coding.delsarte_bounds import _delsarte_Q_LP_building
605-
sage: from sage.all import *
606605
sage: q = Matrix([[codes.bounds.krawtchouk(6,2,i,j) for j in range(7)] for i in range(7)])
607606
sage: _, p = _delsarte_Q_LP_building(q, 2, "PPL", False)
608607
sage: p.show()

src/sage/coding/information_set_decoder.py

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,11 @@
4040
# http://www.gnu.org/licenses/
4141
#******************************************************************************
4242

43-
from sage.all import ZZ, Integer, vector, SageObject, binomial
43+
from sage.rings.integer_ring import ZZ
44+
from sage.rings.integer import Integer
45+
from sage.modules.free_module_element import free_module_element as vector
46+
from sage.structure.sage_object import SageObject
47+
from sage.functions.other import binomial
4448
from .decoder import Decoder
4549

4650

src/sage/coding/linear_code.py

Lines changed: 18 additions & 17 deletions
Original file line numberDiff line numberDiff line change
@@ -205,32 +205,33 @@ class should inherit from this class. Also ``AbstractLinearCode`` should never
205205
import os
206206
import subprocess
207207

208-
from io import StringIO
209208
from copy import copy
209+
from io import StringIO
210210

211-
from sage.cpython.string import bytes_to_str
211+
from sage.arith.misc import binomial, GCD
212212
from sage.categories.cartesian_product import cartesian_product
213213
from sage.categories.fields import Fields
214+
from sage.coding.decoder import Decoder
215+
from sage.coding.encoder import Encoder
216+
from sage.coding.linear_code_no_metric import AbstractLinearCodeNoMetric
217+
from sage.combinat.subset import Subsets
218+
from sage.cpython.string import bytes_to_str
219+
from sage.features.gap import GapPackage
220+
from sage.groups.all import SymmetricGroup
221+
from sage.groups.perm_gps.permgroup import PermutationGroup
222+
from sage.interfaces.gap import gap
214223
from sage.matrix.matrix_space import MatrixSpace
224+
from sage.misc.cachefunc import cached_method
225+
from sage.misc.functional import is_even
226+
from sage.misc.misc_c import prod
227+
from sage.misc.randstate import current_randstate
215228
from sage.modules.free_module import VectorSpace
216229
from sage.modules.free_module_element import vector
217-
from sage.arith.all import GCD, binomial
218-
from sage.groups.all import SymmetricGroup
219-
from sage.groups.perm_gps.permgroup import PermutationGroup
220-
from sage.rings.rational_field import QQ
230+
from sage.rings.finite_rings.finite_field_constructor import FiniteField as GF
231+
from sage.rings.integer import Integer
221232
from sage.rings.integer_ring import ZZ
222233
from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
223-
from sage.rings.integer import Integer
224-
from sage.rings.finite_rings.finite_field_constructor import FiniteField as GF
225-
from sage.misc.misc_c import prod
226-
from sage.misc.functional import is_even
227-
from sage.misc.cachefunc import cached_method
228-
from sage.misc.randstate import current_randstate
229-
from sage.combinat.subset import Subsets
230-
from sage.features.gap import GapPackage
231-
from sage.coding.linear_code_no_metric import AbstractLinearCodeNoMetric
232-
from .encoder import Encoder
233-
from .decoder import Decoder
234+
from sage.rings.rational_field import QQ
234235

235236
# *****************************************************************************
236237
# coding theory functions

src/sage/groups/abelian_gps/abelian_group.py

Lines changed: 11 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -202,21 +202,22 @@
202202
# https://www.gnu.org/licenses/
203203
# ****************************************************************************
204204

205-
from sage.rings.integer import Integer
206-
from sage.rings.integer_ring import ZZ
207-
from sage.structure.category_object import normalize_names
208-
from sage.structure.unique_representation import UniqueRepresentation
209-
from sage.rings.infinity import infinity
210-
from sage.arith.all import divisors, gcd, lcm
205+
from sage.arith.functions import lcm
206+
from sage.arith.misc import divisors, gcd
207+
from sage.categories.groups import Groups
211208
from sage.groups.abelian_gps.abelian_group_element import AbelianGroupElement
212-
from sage.misc.cachefunc import cached_method
213-
from sage.misc.misc_c import prod
214-
from sage.misc.mrange import mrange, cartesian_product_iterator
215209
from sage.groups.group import AbelianGroup as AbelianGroupBase
216-
from sage.categories.groups import Groups
217210
from sage.matrix.constructor import matrix
218211
from sage.matrix.special import diagonal_matrix
212+
from sage.misc.cachefunc import cached_method
213+
from sage.misc.misc_c import prod
214+
from sage.misc.mrange import cartesian_product_iterator, mrange
219215
from sage.modules.free_module_element import vector
216+
from sage.rings.infinity import infinity
217+
from sage.rings.integer import Integer
218+
from sage.rings.integer_ring import ZZ
219+
from sage.structure.category_object import normalize_names
220+
from sage.structure.unique_representation import UniqueRepresentation
220221

221222

222223
# TODO: this uses perm groups - the AbelianGroupElement instance method

src/sage/groups/abelian_gps/dual_abelian_group_element.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -52,7 +52,7 @@
5252
# (at your option) any later version.
5353
# https://www.gnu.org/licenses/
5454
# ****************************************************************************
55-
from sage.arith.all import LCM
55+
from sage.arith.functions import lcm as LCM
5656
from sage.groups.abelian_gps.element_base import AbelianGroupElementBase
5757

5858

0 commit comments

Comments
 (0)