Skip to content

Commit bcd9128

Browse files
author
Release Manager
committed
gh-35752: Clarification on the MAX_MODULUS of float matrices modulo `n` <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description <!-- Describe your changes here in detail. --> Improves the documentation to give more precisions on the upper limit MAX_MODULUS of `matrix_modn_dense_float.pyx` for performances sake. <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> Fixes #35365 <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35752 Reported by: Marie Bonboire Reviewer(s): Vincent Neiger
2 parents 7272357 + a6d92ef commit bcd9128

File tree

2 files changed

+8
-6
lines changed

2 files changed

+8
-6
lines changed

src/sage/matrix/matrix_modn_dense_double.pyx

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -51,8 +51,9 @@ cdef class Matrix_modn_dense_double(Matrix_modn_dense_template):
5151
5252
These are matrices with integer entries mod ``n`` represented as
5353
floating-point numbers in a 64-bit word for use with LinBox routines.
54-
This allows for ``n`` up to `2^{23}`. The analogous
55-
``Matrix_modn_dense_float`` class is used for smaller moduli.
54+
This allows for ``n`` up to `2^{23}`. By default, the analogous
55+
``Matrix_modn_dense_float`` class is used for smaller moduli, specifically
56+
for ``n`` up to `2^{8}`.
5657
5758
Routines here are for the most basic access, see the
5859
``matrix_modn_dense_template.pxi`` file for higher-level routines.

src/sage/matrix/matrix_modn_dense_float.pyx

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@
33
# distutils: library_dirs = CBLAS_LIBDIR
44
# distutils: include_dirs = CBLAS_INCDIR
55
r"""
6-
Dense matrices over `\ZZ/n\ZZ` for `n < 2^{11}` using LinBox's ``Modular<float>``
6+
Dense matrices over `\ZZ/n\ZZ` for `n < 2^{8}` using LinBox's ``Modular<float>``
77
88
AUTHORS:
99
- Burcin Erocal
@@ -44,12 +44,13 @@ include "matrix_modn_dense_template.pxi"
4444

4545
cdef class Matrix_modn_dense_float(Matrix_modn_dense_template):
4646
r"""
47-
Dense matrices over `\ZZ/n\ZZ` for `n < 2^{11}` using LinBox's ``Modular<float>``
47+
Dense matrices over `\ZZ/n\ZZ` for `n < 2^{8}` using LinBox's ``Modular<float>``
4848
4949
These are matrices with integer entries mod ``n`` represented as
5050
floating-point numbers in a 32-bit word for use with LinBox routines.
51-
This allows for ``n`` up to `2^{11}`. The
52-
``Matrix_modn_dense_double`` class is used for larger moduli.
51+
This could allow for ``n`` up to `2^{11}`, but for performance reasons
52+
this is limited to ``n`` up to `2^{8}`, and for larger moduli the
53+
``Matrix_modn_dense_double`` class is used.
5354
5455
Routines here are for the most basic access, see the
5556
``matrix_modn_dense_template.pxi`` file for higher-level routines.

0 commit comments

Comments
 (0)