Skip to content

Commit c0e33fd

Browse files
author
Matthias Koeppe
committed
src/sage/rings/finite_rings/finite_field_base.pyx: Remove deprecated keyword, change default per #28481 (2019)
1 parent c91d21e commit c0e33fd

File tree

1 file changed

+1
-10
lines changed

1 file changed

+1
-10
lines changed

src/sage/rings/finite_rings/finite_field_base.pyx

Lines changed: 1 addition & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -1173,7 +1173,7 @@ cdef class FiniteField(Field):
11731173
else:
11741174
return PolynomialRing(GF(self.characteristic()), variable_name)
11751175

1176-
def free_module(self, base=None, basis=None, map=None, subfield=None):
1176+
def free_module(self, base=None, basis=None, map=True):
11771177
"""
11781178
Return the vector space over the subfield isomorphic to this
11791179
finite field as a vector space, along with the isomorphisms.
@@ -1253,15 +1253,6 @@ cdef class FiniteField(Field):
12531253
sage: all(to_V(h(c) * e) == c * to_V(e) for e in E for c in F)
12541254
True
12551255
"""
1256-
if subfield is not None:
1257-
if base is not None:
1258-
raise ValueError
1259-
deprecation(28481, "The subfield keyword argument has been renamed to base")
1260-
base = subfield
1261-
if map is None:
1262-
deprecation(28481, "The default value for map will be changing to True. To keep the current behavior, explicitly pass map=False.")
1263-
map = False
1264-
12651256
if base is None and self.__vector_space is not None and not map:
12661257
# A very common case: return as early as possible.
12671258
return self.__vector_space

0 commit comments

Comments
 (0)