Skip to content

Commit cb6ca56

Browse files
author
Release Manager
committed
gh-39003: CI Fix: Do not upload logs artifact for the default job in CI Linux <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> fixes the failure seen in https://github.com/sagemath/sage/actions/runs/ 11869791506/job/33080484685 The cause is duplicate uploading of artifacts of the same name. Test: https://github.com/kwankyu/sage/actions/runs/11906298470/job/33178163324 ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #39003 Reported by: Kwankyu Lee Reviewer(s):
2 parents 4076bce + 8377403 commit cb6ca56

File tree

2 files changed

+7
-2
lines changed

2 files changed

+7
-2
lines changed

.github/workflows/ci-linux.yml

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -50,6 +50,7 @@ jobs:
5050
tox_packages_factors: >-
5151
["standard"]
5252
docker_push_repository: ghcr.io/${{ github.repository }}/
53+
logs_artifact: false
5354

5455
# All platforms. This duplicates the default platform, but why not,
5556
# it makes it more robust regarding random timeouts.

.github/workflows/docker.yml

Lines changed: 6 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -85,6 +85,9 @@ on:
8585
description: 'Elapsed time (seconds) at which to kill the build'
8686
default: 20000
8787
type: number
88+
logs_artifact:
89+
default: true
90+
type: boolean
8891
#
8992
# Publishing to GitHub Packages
9093
#
@@ -260,11 +263,12 @@ jobs:
260263
cp -r .tox/$TOX_ENV/* "artifacts/$LOGS_ARTIFACT_NAME"
261264
rm -rf "artifacts/$LOGS_ARTIFACT_NAME"/{bin,lib,pyvenv.cfg}
262265
if: always()
263-
- uses: actions/upload-artifact@v4
266+
- name: Upload logs artifact
267+
uses: actions/upload-artifact@v4
264268
with:
265269
path: artifacts
266270
name: ${{ env.LOGS_ARTIFACT_NAME }}
267-
if: always()
271+
if: always() && inputs.logs_artifact
268272
- name: Print out logs for immediate inspection
269273
# and markup the output with GitHub Actions logging commands
270274
run: |

0 commit comments

Comments
 (0)