Skip to content

Commit cbf22d6

Browse files
author
Release Manager
committed
gh-37023: Parent in plural Using `Parent` and `CommutativeRing` in the plural file This is a little move towards getting rid of the old coercion framework. ### 📝 Checklist - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. URL: #37023 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
2 parents baed34c + 1f95cb0 commit cbf22d6

File tree

1 file changed

+5
-5
lines changed

1 file changed

+5
-5
lines changed

src/sage/rings/polynomial/plural.pyx

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -126,7 +126,7 @@ from sage.rings.polynomial.multi_polynomial_libsingular cimport MPolynomialRing_
126126
from sage.rings.polynomial.multi_polynomial_ideal import NCPolynomialIdeal
127127

128128
from sage.rings.polynomial.polydict import ETuple
129-
from sage.rings.ring import check_default_category, Ring
129+
from sage.rings.ring import check_default_category, CommutativeRing
130130
from sage.structure.element cimport CommutativeRingElement, Element, RingElement
131131
from sage.structure.factory import UniqueFactory
132132
from sage.structure.richcmp cimport rich_to_bool
@@ -334,7 +334,7 @@ cdef class NCPolynomialRing_plural(Ring):
334334
self._ngens = n
335335
self._term_order = order
336336

337-
Ring.__init__(self, base_ring, names, category=category)
337+
Parent.__init__(self, base=base_ring, names=names, category=category)
338338
self._populate_coercion_lists_()
339339

340340
assert n == len(self._names)
@@ -2878,8 +2878,8 @@ cpdef MPolynomialRing_libsingular new_CRing(RingWrap rw, base_ring) noexcept:
28782878
self._term_order = TermOrder(rw.ordering_string(), force=True)
28792879

28802880
names = tuple(rw.var_names())
2881-
Ring.__init__(self, base_ring, names, category=Algebras(base_ring),
2882-
normalize=False)
2881+
CommutativeRing.__init__(self, base_ring, names, category=Algebras(base_ring),
2882+
normalize=False)
28832883

28842884
self._has_singular = True
28852885

@@ -2946,7 +2946,7 @@ cpdef NCPolynomialRing_plural new_NRing(RingWrap rw, base_ring) noexcept:
29462946
self._ngens = rw.ngens()
29472947
self._term_order = TermOrder(rw.ordering_string(), force=True)
29482948

2949-
Ring.__init__(self, base_ring, rw.var_names(), category=Algebras(base_ring))
2949+
Parent.__init__(self, base=base_ring, names=rw.var_names(), category=Algebras(base_ring))
29502950

29512951
self._has_singular = True
29522952
self._relations = self.relations()

0 commit comments

Comments
 (0)