Skip to content

Commit cdd42d4

Browse files
author
Release Manager
committed
gh-37223: Remove invariants commands in global namespace This PR removes the depreciated invariants from #28064 (2019). It's been long enough and we should declutter the tab-autocomplete from these very specific functions. As an aside, I'm not sure why we have: ```py from . import monsky_washnitzer ``` Instead of importing objects from this module, but I have not worked with this myself so am loathed to modify this without further input from the community. URL: #37223 Reported by: Giacomo Pope Reviewer(s): Frédéric Chapoton
2 parents 9e9acfe + 5453456 commit cdd42d4

File tree

2 files changed

+1
-41
lines changed

2 files changed

+1
-41
lines changed
Lines changed: 0 additions & 41 deletions
Original file line numberDiff line numberDiff line change
@@ -1,45 +1,4 @@
1-
"""
2-
Tests for deprecations of imports in global namespace from :trac:`28064`::
3-
4-
sage: igusa_clebsch_invariants
5-
doctest:warning...:
6-
DeprecationWarning:
7-
Importing igusa_clebsch_invariants from here is deprecated;
8-
please use "from sage.schemes.hyperelliptic_curves.invariants import igusa_clebsch_invariants" instead.
9-
See https://github.com/sagemath/sage/issues/28064 for details.
10-
...
11-
12-
sage: absolute_igusa_invariants_kohel
13-
doctest:warning...:
14-
DeprecationWarning:
15-
Importing absolute_igusa_invariants_kohel from here is deprecated;
16-
please use "from sage.schemes.hyperelliptic_curves.invariants import absolute_igusa_invariants_kohel" instead.
17-
See https://github.com/sagemath/sage/issues/28064 for details.
18-
...
19-
20-
sage: absolute_igusa_invariants_wamelen
21-
doctest:warning...:
22-
DeprecationWarning:
23-
Importing absolute_igusa_invariants_wamelen from here is deprecated;
24-
please use "from sage.schemes.hyperelliptic_curves.invariants import absolute_igusa_invariants_wamelen" instead.
25-
See https://github.com/sagemath/sage/issues/28064 for details.
26-
...
27-
28-
sage: clebsch_invariants
29-
doctest:warning...:
30-
DeprecationWarning:
31-
Importing clebsch_invariants from here is deprecated;
32-
please use "from sage.schemes.hyperelliptic_curves.invariants import clebsch_invariants" instead.
33-
See https://github.com/sagemath/sage/issues/28064 for details.
34-
...
35-
"""
36-
from sage.misc.lazy_import import lazy_import
37-
381
from .constructor import HyperellipticCurve
392
from .kummer_surface import KummerSurface
40-
lazy_import('sage.schemes.hyperelliptic_curves.invariants',
41-
['igusa_clebsch_invariants', 'absolute_igusa_invariants_kohel',
42-
'absolute_igusa_invariants_wamelen', 'clebsch_invariants'],
43-
deprecation=28064)
443
from .mestre import (Mestre_conic, HyperellipticCurve_from_invariants)
454
from . import monsky_washnitzer

src/sage/schemes/hyperelliptic_curves/invariants.py

Lines changed: 1 addition & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -322,6 +322,7 @@ def igusa_clebsch_invariants(f):
322322
sage: igusa_clebsch_invariants(x^5 + a*x^4 + b*x^3 + c*x^2 + d*x + e)[0]
323323
6*b^2 - 16*a*c + 40*d
324324
325+
sage: from sage.schemes.hyperelliptic_curves.invariants import absolute_igusa_invariants_wamelen
325326
sage: absolute_igusa_invariants_wamelen(GF(5)['x'](x^6 - 2*x))
326327
Traceback (most recent call last):
327328
...

0 commit comments

Comments
 (0)