Skip to content

Commit ce6b4ab

Browse files
author
Release Manager
committed
gh-40792: Typo in meridians for projective curves <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> Due to a typo the method `meridians` does not work for `ProjectivePlaneCurveArrangement`. It is corrected. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #40792 Reported by: Enrique Manuel Artal Bartolo Reviewer(s): Martin Rubey
2 parents 60a52ec + 08cf667 commit ce6b4ab

File tree

1 file changed

+3
-3
lines changed

1 file changed

+3
-3
lines changed

src/sage/schemes/curves/plane_curve_arrangement.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -954,19 +954,19 @@ def meridians(self, simplified=True) -> dict:
954954
sage: A.meridians()
955955
{0: [x0, x1*x0*x1^-1], 1: [x0^-1*x1^-1*x0^-1], 2: [x1]}
956956
sage: A = H(y^2 + x*z, z*x, y)
957+
sage: A.meridians()
958+
{0: [x0, x2*x0*x2^-1], 1: [x2, x0^-1*x2^-1*x1^-1*x0^-1], 2: [x1]}
957959
sage: A.fundamental_group()
958960
Finitely presented group < x0, x1, x2 | x2*x0*x1*x0^-1*x2^-1*x1^-1,
959961
x1*(x2*x0)^2*x2^-1*x1^-1*x0^-1*x2^-1*x0^-1 >
960-
sage: A.meridians()
961-
{0: [x0, x2*x0*x2^-1], 1: [x2, x0^-1*x2^-1*x1^-1*x0^-1], 2: [x1]}
962962
"""
963963
if simplified:
964964
computed = self._meridians_simpl
965965
else:
966966
computed = self._meridians_nonsimpl
967967
if computed:
968968
return dict(computed)
969-
self._fundamental_group(simplified=simplified)
969+
self.fundamental_group(simplified=simplified)
970970
if simplified:
971971
return dict(self._meridians_simpl)
972972
else:

0 commit comments

Comments
 (0)