Skip to content

Commit cf58964

Browse files
author
Release Manager
committed
gh-37630: Enhance documentation of Drinfeld module Potemine j-invariants
<!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> The definition of $j$-invariants, *basic* $j$-invariants and $j_k$-invariants defer in [Potemine's article](https://link.springer.com/article/10.1023/A:1009724323513) and [Papikian's book](https://link.springer.com/book/10.1007/978-3-031-19707-9). Thanks to @DavidAyotte, we follow Potemine's convention. Seeing however the growing popularity of Papikian's book, I reckon it is a good idea to add a note in the documentation addressing those differences. Also, I fixed a typo. ### Potemine: ![image](https://github.com/sagemath/sage/assets/31312212/5e09f13c-782d- 4665-b5a6-c0c8947cb74f) ![image](https://github.com/sagemath/sage/assets/31312212/65c6e812-3f93- 4a4c-9bb7-ce84ca1dcf10) ### Papikian: ![image](https://github.com/sagemath/sage/assets/31312212/eb811d6f-5a3c- 4764-b9f8-d12d562309b3) ![image](https://github.com/sagemath/sage/assets/31312212/d100c393-dd6d- 47b0-b39b-edfd02cda7a6) ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [x] The title is concise and informative. - [x] The description explains in detail what this PR is about. - [x] I have linked a relevant issue or discussion. - [x] I have created tests covering the changes. - [x] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #37630 Reported by: Antoine Leudière Reviewer(s): David Ayotte
2 parents d3ce9d0 + 77314e0 commit cf58964

File tree

4 files changed

+29
-10
lines changed

4 files changed

+29
-10
lines changed

build/pkgs/configure/checksums.ini

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
11
tarball=configure-VERSION.tar.gz
2-
sha1=16786ab29c5625c411bee47d25d62d628477e9dc
3-
md5=f37ca4623241cad2846b45122d180cc3
4-
cksum=536361291
2+
sha1=25a360e4892317526249e50eaa51297891511d61
3+
md5=0fd34b91fc06199e6c3672ad969472ee
4+
cksum=1226224895
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1 +1 @@
1-
b0343d194ea320a6ea030d6b1274fbacdac0d7ac
1+
d13f6164a314f330071fe2a99112e78de03347f0

src/doc/en/reference/references/index.rst

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -5133,6 +5133,10 @@ REFERENCES:
51335133
B46f,
51345134
https://eudml.org/doc/121696
51355135
5136+
.. [Pap2023] Mihran Papikian, *Drinfeld modules*.
5137+
Graduate Texts in Mathematics, 206,
5138+
Springer International Publishing, Cham, 2023.
5139+
51365140
.. [PALP] Maximilian Kreuzer, Harald Skarke: "PALP: A Package for
51375141
Analyzing Lattice Polytopes with Applications to Toric
51385142
Geometry" omput.Phys.Commun. 157 (2004) 87-106

src/sage/rings/function_field/drinfeld_modules/drinfeld_module.py

Lines changed: 21 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -1489,7 +1489,7 @@ def j_invariant(self, parameter=None, check=True):
14891489
.. MATH::
14901490
14911491
j_{k_1, \ldots, k_n}^{d_1, \ldots, d_n, d_r}(\phi)
1492-
:= \frac{1}{g_r^{d_q}}\prod_{i = 1}^n g_{k_i}^{d_i}
1492+
:= \frac{1}{g_r^{d_r}}\prod_{i = 1}^n g_{k_i}^{d_i}
14931493
14941494
where `1\leqslant k_1 < k_2 < \ldots < k_n \leqslant r - 1` and
14951495
the integers `d_i` satisfy the *weight-0 condition*:
@@ -1510,6 +1510,26 @@ def j_invariant(self, parameter=None, check=True):
15101510
:meth:`basic_j_invariant_parameters` for computing the list of
15111511
all basic `j`-invariant parameters.
15121512
1513+
.. NOTE::
1514+
1515+
In [Pap2023]_, Papikian follows a slightly different
1516+
convention:
1517+
1518+
- His `j`-invariants (see Definition 3.8.7) correspond to
1519+
our basic `j`-invariants, as defined above.
1520+
- His *basic* `j`-invariant (see Example 3.8.10) correspond
1521+
to our `j_k`-invariants, as implemented in
1522+
:meth:`jk_invariants`.
1523+
1524+
We chose to follow Potemine's convention, as he introduced
1525+
those objects in [Pot1998]_. Theorem 2.2 of [Pot1998]_ or
1526+
Theorem 3.8.11 of [Pap2023]_ assert that two Drinfeld
1527+
`\mathbb F_q[T]`-modules over `K` are isomorphic over the
1528+
separable closure of `K` if and only if their basic
1529+
`j`-invariants (as implemented here) coincide for any
1530+
well-defined couple of tuples `((k_1, k_2, \ldots, k_n),
1531+
(d_1, d_2, \ldots, d_n, d_r))`, .
1532+
15131533
INPUT:
15141534
15151535
- ``parameter`` (tuple or list, integer or NoneType; default:
@@ -1536,11 +1556,6 @@ def j_invariant(self, parameter=None, check=True):
15361556
15371557
OUTPUT: the `j`-invariant of ``self`` for the given parameter.
15381558
1539-
REFERENCE:
1540-
1541-
The notion of basic `j`-invariant was introduced by Potemine in
1542-
[Pot1998]_.
1543-
15441559
EXAMPLES::
15451560
15461561
sage: Fq = GF(25)

0 commit comments

Comments
 (0)