fix suggested details

Author: fchapoton

src/sage/interfaces/magma.py

@@ -1305,30 +1305,28 @@ def _left_list_delim(self):
         """
         Return the left sequence delimiter in Magma.
 
-        Despite the name in
-        this function, this is really the least painful choice.
+        Despite the name in this function, this is really the least
+        painful choice.
 
         EXAMPLES::
 
             sage: magma._left_list_delim()
             '['
         """
-        # return "[*"
         return "["
 
     def _right_list_delim(self):
         """
         Return the right sequence delimiter in Magma.
 
-        Despite the name in
-        this function, this is really the least painful choice.
+        Despite the name in this function, this is really the least
+        painful choice.
 
         EXAMPLES::
 
             sage: magma._right_list_delim()
             ']'
         """
-        # return "*]"
         return "]"
 
     def _assign_symbol(self):

src/sage/interfaces/matlab.py

@@ -137,7 +137,7 @@
                8           1           1
 """
 
-##############################################################################
+# ****************************************************************************
 #       Copyright (C) 2006 William Stein <[email protected]>
 #
 #  Distributed under the terms of the GNU General Public License (GPL).
@@ -150,7 +150,7 @@
 #  The full text of the GPL is available at:
 #
 #                  https://www.gnu.org/licenses/
-##############################################################################
+# ****************************************************************************
 
 import os
 

src/sage/interfaces/mupad.py

@@ -84,14 +84,14 @@
 
 """
 
-#############################################################################
+# **************************************************************************
 #       Copyright (C) 2008 Mike Hansen <[email protected]>
 #                          William Stein <[email protected]>
 #
 #  Distributed under the terms of the GNU General Public License (GPL)
 #
 #                  https://www.gnu.org/licenses/
-#############################################################################
+# **************************************************************************
 
 import os
 

src/sage/interfaces/polymake.py

@@ -283,10 +283,11 @@ def convert(y):
                 k = convert(k)
                 v = convert(v)
                 z[k] = v
-                A.append("{}=>{}".format(k.name(), v.name()))
+                A.append(f"{k.name()}=>{v.name()}")
             r = self.new("{" + ",".join(A) + "}")
-            r.__sage_dict = z
+
             # this to avoid having the entries of the list be garbage collected
+            r.__sage_dict = z
             return r
 
         import sage.rings.abc
@@ -849,8 +850,9 @@ def new_object(self, name, *args, **kwds):
         return f(*args, **kwds)
 
 
-########################################
-#  Elements
+# --------
+# Elements
+# --------
 
 class PolymakeElement(ExtraTabCompletion, InterfaceElement):
     """

src/sage/interfaces/r.py

@@ -258,7 +258,7 @@
 - Emmanuel Charpentier (2015-12-12, RPy2 interface)
 """
 
-##########################################################################
+# ************************************************************************
 #
 #       Copyright (C) 2007 William Stein <[email protected]>
 #                     2007 Mike Hansen   <[email protected]>
@@ -268,7 +268,7 @@
 #
 #                  https://www.gnu.org/licenses/
 #
-##########################################################################
+# ************************************************************************
 import os
 
 from .interface import Interface, InterfaceElement, InterfaceFunction, InterfaceFunctionElement
@@ -486,8 +486,8 @@ def __init__(self,
             True
         """
         Interface.__init__(
-                self,
-                name='r',  # The capitalized version of this is used for printing.
+            self,
+            name='r',  # The capitalized version of this is used for printing.
         )
         self._seed = seed
         self._initialized = False  # done lazily
@@ -1075,7 +1075,7 @@ def function_call(self, function, args=None, kwds=None):
         args, kwds = self._convert_args_kwds(args, kwds)
         self._check_valid_function_name(function)
         return self.new("%s(%s)" % (function, ",".join([s.name() for s in args] +
-                                                       [self._sage_to_r_name(key)+'='+kwds[key].name() for key in kwds])))
+                                                       [self._sage_to_r_name(key) + '=' + kwds[key].name() for key in kwds])))
 
     def call(self, function_name, *args, **kwds):
         r"""
@@ -1118,10 +1118,8 @@ def set(self, var, value):
             sage: r.set('a', '2 + 3')  # optional - rpy2
             sage: r.get('a')  # optional - rpy2
             '[1] 5'
-
         """
-        cmd = '%s <- %s' % (var, value)
-        out = self.eval(cmd)
+        _ = self.eval(f'{var} <- {value}')
 
     def get(self, var):
         """
@@ -1822,8 +1820,7 @@ def _sage_(self):
         P = self.parent()
 
         with localconverter(P._r_to_sage_converter) as cv:
-            parsed = robjects.r(self.name())
-            return parsed
+            return robjects.r(self.name())
 
     def _latex_(self):
         r"""

src/sage/interfaces/scilab.py

@@ -176,10 +176,10 @@
 
 AUTHORS:
 
-   -- Ronan Paixao (2008-11-26), based on the MATLAB tutorial by
-      William Stein (2006-10-11)
+- Ronan Paixao (2008-11-26), based on the MATLAB tutorial by
+  William Stein (2006-10-11)
 """
-##############################################################################
+# ****************************************************************************
 #       Copyright (C) 2006 William Stein <[email protected]>
 #       Copyright (C) 2008 Ronan Paixao <[email protected]>
 #
@@ -193,7 +193,7 @@
 #  The full text of the GPL is available at:
 #
 #                  https://www.gnu.org/licenses/
-##############################################################################
+# ****************************************************************************
 
 import os
 

src/sage/interfaces/tests.py

@@ -59,7 +59,7 @@ def manyvars(s, num=70000, inlen=1, step=2000):
         v = []
         for i in range(num):
             if not i % step:
-                sys.stdout.write('{i} ')
+                sys.stdout.write(f'{i} ')
                 sys.stdout.flush()
             v.append(s(t))
         print('\nsuccess -- time = cpu: %s, wall: %s' % (cputime(t),

src/sage/interfaces/tides.py

@@ -12,14 +12,14 @@
 
 ::
 
-    ##########################################################################
+    # ************************************************************************
     #  Copyright (C) 2014 Miguel Marco <[email protected]>, Marcos Rodriguez
     #   <[email protected]>
     #
     #  Distributed under the terms of the GNU General Public License (GPL):
     #
     #                  https://www.gnu.org/licenses/
-    ##########################################################################
+    # ************************************************************************
 
 AUTHORS: