cython-lint for imports in rings

Author: fchapoton

src/sage/libs/flint/nmod_poly_linkage.pxi

@@ -22,7 +22,7 @@ from cysignals.memory cimport sig_malloc, sig_free
 
 from sage.libs.flint.nmod_poly cimport *
 from sage.libs.flint.ulong_extras cimport *
-
+from sage.structure.factorization import Factorization
 
 cdef inline celement *celement_new(unsigned long n):
     cdef celement *g = <celement *>sig_malloc(sizeof(nmod_poly_t))

src/sage/rings/bernoulli_mod_p.pyx

@@ -15,27 +15,25 @@ AUTHOR:
 - David Harvey (2007-08-31): algorithm for a single Bernoulli number mod p
 - David Harvey (2008-06): added interface to bernmm, removed old code
 """
-
-#*****************************************************************************
+# ****************************************************************************
 #       Copyright (C) 2006 William Stein <[email protected]>
 #                     2006 David Harvey <[email protected]>
 #
 #  Distributed under the terms of the GNU General Public License (GPL)
-#                  http://www.gnu.org/licenses/
-#*****************************************************************************
+#                  https://www.gnu.org/licenses/
+# ****************************************************************************
 
 cimport sage.rings.fast_arith
 import sage.rings.fast_arith
 cdef sage.rings.fast_arith.arith_int arith_int
-arith_int  = sage.rings.fast_arith.arith_int()
+arith_int = sage.rings.fast_arith.arith_int()
 
 ctypedef long long llong
 
 import sage.arith.all
 
 from sage.libs.ntl import all as ntl
 from sage.libs.ntl.ntl_ZZ_pX cimport ntl_ZZ_pX
-from sage.rings.finite_rings.integer_mod_ring import Integers
 from sage.rings.bernmm import bernmm_bern_modp
 
 
@@ -133,9 +131,7 @@ def bernoulli_mod_p(int p):
     AUTHOR:
 
     - David Harvey (2006-08-06)
-
     """
-
     if p <= 2:
         raise ValueError("p (=%s) must be a prime >= 3" % p)
 
@@ -303,7 +299,6 @@ def bernoulli_mod_p_single(long p, long k):
 
     - David Harvey (2007-08-31)
     - David Harvey (2008-06): rewrote to use bernmm library
-
     """
     if p <= 2:
         raise ValueError("p (=%s) must be a prime >= 3" % p)

src/sage/rings/polynomial/polynomial_zmod_flint.pyx

@@ -40,7 +40,6 @@ AUTHORS:
 # ****************************************************************************
 
 from sage.libs.ntl.ntl_lzz_pX import ntl_zz_pX
-from sage.structure.factorization import Factorization  # removing breaks build
 from sage.structure.element cimport parent
 from sage.structure.element import coerce_binop
 from sage.rings.polynomial.polynomial_integer_dense_flint cimport Polynomial_integer_dense_flint

src/sage/rings/rational.pyx

@@ -92,8 +92,6 @@ import sage.rings.real_double
 from libc.stdint cimport uint64_t
 from sage.libs.gmp.binop cimport mpq_add_z, mpq_mul_z, mpq_div_zz
 
-from cpython.int cimport PyInt_AS_LONG
-
 cimport sage.rings.fast_arith
 import sage.rings.fast_arith