Merge branch 'develop' into p/36144

Author: kwankyu

.github/sync_labels.py

@@ -56,7 +56,7 @@ class ReviewDecision(Enum):
     """
     changes_requested = 'CHANGES_REQUESTED'
     approved = 'APPROVED'
-    unclear = 'COMMENTED'
+    unclear = 'UNCLEAR'
 
 class Priority(Enum):
     r"""
@@ -319,12 +319,15 @@ def get_review_decision(self):
             return None
 
         if self._review_decision is not None:
+            if self._review_decision == ReviewDecision.unclear:
+                return None
             return self._review_decision
 
         data = self.view('reviewDecision')
         if data:
             self._review_decision = ReviewDecision(data)
         else:
+            # To separate a not supplied value from not cached (see https://github.com/sagemath/sage/pull/36177#issuecomment-1704022893 ff)
             self._review_decision = ReviewDecision.unclear
         info('Review decision for %s: %s' % (self._issue, self._review_decision.value))
         return self._review_decision
@@ -349,9 +352,9 @@ def get_reviews(self, complete=False):
             self.get_commits()
 
         date = self._commit_date
-        no_rev = ReviewDecision.unclear.value
+        unproper_rev = RevState.commented.value
         new_revs = [rev for rev in self._reviews if rev['submittedAt'] > date]
-        proper_new_revs = [rev for rev in new_revs if rev['state'] != no_rev]
+        proper_new_revs = [rev for rev in new_revs if rev['state'] != unproper_rev]
         info('Proper reviews after %s for %s: %s' % (date, self._issue, proper_new_revs))
         return proper_new_revs
 
@@ -463,11 +466,6 @@ def approve_allowed(self):
         r"""
         Return if the actor has permission to approve this PR.
         """
-        revs = self.get_reviews(complete=True)
-        if not any(rev['authorAssociation'] in ('MEMBER', 'OWNER') for rev in revs):
-            info('PR %s can\'t be approved because of missing member review' % (self._issue))
-            return False
-
         revs = self.get_reviews()
         revs = [rev for rev in revs if rev['author']['login'] != self._actor]
         ch_req = ReviewDecision.changes_requested

.github/workflows/build.yml

@@ -30,7 +30,7 @@ jobs:
     steps:
       - name: Checkout
         id: checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Update system packages
         id: prepare

.github/workflows/ci-conda.yml

@@ -49,7 +49,7 @@ jobs:
         conda-env: [environment]
 
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - name: Check for Miniconda
         id: check_conda

.github/workflows/ci-linux-incremental.yml

@@ -43,7 +43,7 @@ jobs:
       uninstall_targets: ${{ steps.build-targets.outputs.uninstall_targets }}
       build_targets:     ${{ steps.build-targets.outputs.build_targets }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Get all packages that have changed
         id: changed-packages
         uses: tj-actions/changed-files@v38
@@ -83,10 +83,9 @@ jobs:
       tox_system_factors: >-
         ["ubuntu-focal",
          "ubuntu-jammy",
-         "ubuntu-mantic,
+         "ubuntu-mantic",
          "debian-bullseye",
          "debian-bookworm",
-         "ubuntu-mantic,
          "fedora-30",
          "fedora-38",
          "gentoo-python3.11",

.github/workflows/ci-macos.yml

@@ -47,7 +47,7 @@ jobs:
       LOCAL_ARTIFACT_NAME: sage-local-commit-${{ github.sha }}-tox-local-${{ matrix.tox_env }}-${{ matrix.os }}-xcode_${{ matrix.xcode_version_factor }}
       LOGS_ARTIFACT_NAME: logs-commit-${{ github.sha }}-tox-local-${{ matrix.tox_env }}--${{ matrix.os }}-xcode_${{ matrix.xcode_version_factor }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Select Xcode version
         run: |
           if [ ${{ matrix.xcode_version_factor }} != default ]; then sudo xcode-select -s /Applications/Xcode_${{ matrix.xcode_version_factor }}.app; fi
@@ -118,7 +118,7 @@ jobs:
 
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         with:
           fetch-depth: 500
       - name: fetch tags
@@ -160,7 +160,7 @@ jobs:
       TOX_ENV: local-${{ matrix.tox_system_factor }}-${{ matrix.tox_packages_factor }}
       LOGS_ARTIFACT_NAME: logs-commit-${{ github.sha }}-tox-local-${{ matrix.tox_system_factor }}-${{ matrix.tox_packages_factor }}-xcode_${{ matrix.xcode_version_factor }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
         if: "!contains(matrix.tox_system_factor, 'nobootstrap')"
       - uses: actions/download-artifact@v3
         with:

.github/workflows/ci-wsl.yml

@@ -17,7 +17,7 @@ jobs:
     steps:
     - name: Configure git
       run: git config --global core.symlinks true
-    - uses: actions/checkout@v3
+    - uses: actions/checkout@v4
     - name: Install Ubuntu 20.04 (in WSL)
       run: |
         (New-Object System.Net.WebClient).DownloadFile("https://aka.ms/wslubuntu2004", "Ubuntu.appx")

.github/workflows/cygwin.yml

@@ -73,14 +73,14 @@ jobs:
         choco install git python39 python39-pip --source cygwin
 
     - name: Check out SageMath
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         repository: ${{ inputs.sage_repo }}
         ref: ${{ inputs.sage_ref }}
         fetch-depth: 2000
 
     - name: Check out git-trac-command
-      uses: actions/checkout@v3
+      uses: actions/checkout@v4
       with:
         repository: sagemath/git-trac-command
         path: git-trac-command

.github/workflows/dist.yml

@@ -32,7 +32,7 @@ jobs:
 
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Install bootstrap prerequisites
         run: |
           sudo DEBIAN_FRONTEND=noninteractive apt-get update
@@ -51,7 +51,7 @@ jobs:
     env:
       CAN_DEPLOY: ${{ secrets.SAGEMATH_PYPI_API_TOKEN != '' }}
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
       - name: Install bootstrap prerequisites
         run: |
           sudo DEBIAN_FRONTEND=noninteractive apt-get update
@@ -106,7 +106,7 @@ jobs:
       # Use 'build', not 'pip wheel'
       CIBW_BUILD_FRONTEND: build
     steps:
-      - uses: actions/checkout@v3
+      - uses: actions/checkout@v4
 
       - uses: actions/download-artifact@v3
         with:

.github/workflows/doc-build-pdf.yml

@@ -19,7 +19,7 @@ jobs:
     container: ghcr.io/sagemath/sage/sage-docker-fedora-31-maximal-with-targets:dev
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Prepare
         run: |

.github/workflows/doc-build.yml

@@ -17,7 +17,7 @@ jobs:
     container: ghcr.io/sagemath/sage/sage-ubuntu-focal-standard-with-targets:dev
     steps:
       - name: Checkout
-        uses: actions/checkout@v3
+        uses: actions/checkout@v4
 
       - name: Update system packages
         run: |