Trac #32756: fix E713 and E714 in combinat

abot negative comparison using "is not"

URL: https://trac.sagemath.org/32756
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Matthias Koeppe

Author: Release Manager

src/sage/combinat/affine_permutation.py

@@ -1707,15 +1707,15 @@ def apply_simple_reflection_right(self, i):
         EXAMPLES::
 
             sage: G = AffinePermutationGroup(['G',2,1])
-            sage: p=G([2, 10, -5, 12, -3, 5])
+            sage: p = G([2, 10, -5, 12, -3, 5])
             sage: p.apply_simple_reflection_right(0)
             Type G affine permutation with window [-9, -1, -5, 12, 8, 16]
             sage: p.apply_simple_reflection_right(1)
             Type G affine permutation with window [10, 2, 12, -5, 5, -3]
             sage: p.apply_simple_reflection_right(2)
             Type G affine permutation with window [2, -5, 10, -3, 12, 5]
         """
-        if not i in self.parent().index_set():
+        if i not in self.parent().index_set():
             raise ValueError('index not in index set')
         j = i
         l = self[:]

src/sage/combinat/baxter_permutations.py

@@ -117,7 +117,7 @@ def __contains__(self, x):
             sage: sorted([p for p in Permutations(6) if p in BaxterPermutations(6)]) == sorted(BaxterPermutations(6).list())
             True
         """
-        if not x in Permutations(self._n):
+        if x not in Permutations(self._n):
             return False
         for i in range(1, len(x) - 1):
             a = x[i]
@@ -299,7 +299,7 @@ def __contains__(self, x):
             sage: 42 in BaxterPermutations()
             False
         """
-        if not x in Permutations():
+        if x not in Permutations():
             return False
         return x in BaxterPermutations(len(x))
 

src/sage/combinat/cluster_algebra_quiver/mutation_type.py

@@ -120,7 +120,7 @@ def _triangles(dg):
     for e in E:
         v1, v2 = e
         for v in V:
-            if not v in e:
+            if v not in e:
                 if (v, v1) in E:
                     if (v2, v) in E:
                         flat_trian = sorted([v,v1,v2])
@@ -1165,7 +1165,7 @@ def _connected_mutation_type_AAtildeD(dg, ret_conn_vert=False):
                 connecting_vertices.append( v )
             # if a vertex is of valence two and contained in an oriented 3-cycle, it is a connecting vertex
             elif w[0] == 1 and w[1] == 1:
-                if v in o_trian_verts and not v in long_cycle_verts:
+                if v in o_trian_verts and v not in long_cycle_verts:
                     connecting_vertices.append( v )
 
     # post-parsing 1: if we are in the affine type A case, the two parameters for the non-oriented long cycle are computed

src/sage/combinat/composition_tableau.py

@@ -409,7 +409,7 @@ def __classcall_private__(cls, *args, **kwargs):
         if shape is not None:
             # use in (and not isinstance) below so that lists can be used as
             # shorthand
-            if not shape in Compositions():
+            if shape not in Compositions():
                 raise ValueError("shape must be a composition")
             if any(i == 0 for i in shape):
                 raise ValueError("shape must have non-zero parts")
@@ -475,8 +475,8 @@ def _element_constructor_(self, t):
             ...
             ValueError: [[1], [1, 2]] is not an element of Composition Tableaux of size 3 and maximum entry 3.
         """
-        if not t in self:
-            raise ValueError("%s is not an element of %s."%(t, self))
+        if t not in self:
+            raise ValueError("%s is not an element of %s." % (t, self))
 
         return self.element_class(self, t)
 

src/sage/combinat/crystals/generalized_young_walls.py

@@ -711,7 +711,7 @@ def in_highest_weight_crystal(self,La):
             sage: x.in_highest_weight_crystal(La)
             False
         """
-        if not La in self.parent().weight_lattice_realization():
+        if La not in self.parent().weight_lattice_realization():
             raise TypeError("Must be an element in the weight lattice realization")
         ac = self.parent().weight_lattice_realization().simple_coroots()
         n = self.cartan_type().classical().rank()

src/sage/combinat/designs/bibd.py

@@ -958,7 +958,7 @@ def PBD_4_5_8_9_12(v, check=True):
         sage: for v in (0,1,4,5,8,9,12,13,16,17,20,21,24,25):
         ....:     _ = PBD_4_5_8_9_12(v)
     """
-    if not v%4 in [0,1]:
+    if v % 4 not in [0, 1]:
         raise ValueError
     if v <= 1:
         PBD = []

src/sage/combinat/designs/block_design.py

@@ -676,7 +676,7 @@ def projective_plane_to_OA(pplane, pt=None, check=True):
     assert all(len(B) == n+1 for B in pplane), "pplane is not a projective plane"
 
     pplane = _relabel_bibd(pplane,n**2+n+1,p=n**2+n)
-    OA = [[x%n for x in sorted(X)] for X in pplane if not n**2+n in X]
+    OA = [[x % n for x in sorted(X)] for X in pplane if n**2+n not in X]
 
     assert len(OA) == n**2, "pplane is not a projective plane"
 
@@ -686,6 +686,7 @@ def projective_plane_to_OA(pplane, pt=None, check=True):
 
     return OA
 
+
 def projective_plane(n, check=True, existence=False):
     r"""
     Return a projective plane of order ``n`` as a 2-design.

src/sage/combinat/designs/orthogonal_arrays_build_recursive.py

@@ -545,7 +545,7 @@ def construction_q_x(k,q,x,check=True,explain_construction=False):
     relabel = {i:j for j,i in enumerate(points_to_keep)}
 
     # PBD is a (n,[q,q-x-1,q-x+1,x+2])-PBD
-    PBD = [[relabel[xx] for xx in B if not xx in points_to_delete] for B in TD]
+    PBD = [[relabel[xx] for xx in B if xx not in points_to_delete] for B in TD]
 
     # Taking the unique block of size x+2
     assert list(map(len,PBD)).count(x+2)==1

src/sage/combinat/designs/steiner_quadruple_systems.py

@@ -545,14 +545,15 @@ def _missing_pair(n,l):
         sage: _missing_pair(6, [(0,1), (4,5)])
         (2, 3)
     """
-    l = [x for X in l for x in X]
+    l = set(x for X in l for x in X)
     for x in range(n):
-        if not x in l:
+        if x not in l:
             break
 
-    assert not x in l
-    assert not x+1 in l
-    return (x,x+1)
+    assert x not in l
+    assert x + 1 not in l
+    return (x, x + 1)
+
 
 def barP(eps, m):
     r"""

src/sage/combinat/diagram_algebras.py

@@ -2771,7 +2771,7 @@ def s(self, i):
             sage: P2h.s(1)
             P{{-3, 3}, {-2, 1}, {-1, 2}}
         """
-        if not i in ZZ or i <= 0 or i >= self._k:
+        if i not in ZZ or i <= 0 or i >= self._k:
             raise ValueError("i must be an integer between 1 and {}".format(self._k-1))
         B = self.basis()
         SP = B.keys()