Skip to content

Commit e950129

Browse files
author
Release Manager
committed
gh-35675: cylint: remove unused imports in matrix folder <!-- Please provide a concise, informative and self-explanatory title. --> <!-- Don't put issue numbers in the title. Put it in the Description below. --> <!-- For example, instead of "Fixes #12345", use "Add a new method to multiply two integers" --> ### 📚 Description remove all unused imports in pyx files in the `matrix` folder found using `cython-lint` <!-- Describe your changes here in detail. --> <!-- Why is this change required? What problem does it solve? --> <!-- If this PR resolves an open issue, please link to it here. For example "Fixes #12345". --> <!-- If your change requires a documentation PR, please link it appropriately. --> ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. It should be `[x]` not `[x ]`. --> - [x] The title is concise, informative, and self-explanatory. - [x] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation accordingly. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on - #12345: short description why this is a dependency - #34567: ... --> <!-- If you're unsure about any of these, don't hesitate to ask. We're here to help! --> URL: #35675 Reported by: Frédéric Chapoton Reviewer(s): Matthias Köppe
2 parents 6d48a78 + 6b6a50e commit e950129

19 files changed

+19
-56
lines changed

src/sage/matrix/matrix0.pyx

Lines changed: 1 addition & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -30,13 +30,11 @@ import sage.misc.latex
3030
import sage.rings.integer
3131

3232
from sage.arith.power cimport generic_power
33-
from sage.misc.verbose import verbose, get_verbose
3433
from sage.structure.sequence import Sequence
3534
from sage.structure.parent cimport Parent
3635

3736
cimport sage.structure.element
38-
from sage.structure.element cimport ModuleElement, Element, RingElement, Vector
39-
from sage.structure.mutability cimport Mutability
37+
from sage.structure.element cimport Element, Vector
4038
from sage.misc.misc_c cimport normalize_index
4139

4240
from sage.categories.fields import Fields

src/sage/matrix/matrix2.pyx

Lines changed: 2 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -80,19 +80,18 @@ from cpython cimport *
8080
from cysignals.signals cimport sig_check
8181

8282
from sage.misc.lazy_string import lazy_string
83-
from sage.misc.randstate cimport randstate, current_randstate
83+
from sage.misc.randstate cimport current_randstate
8484
from sage.structure.coerce cimport py_scalar_parent
8585
from sage.structure.sequence import Sequence
8686
from sage.structure.coerce cimport coercion_model
8787
from sage.structure.element import is_Vector
8888
from sage.structure.element cimport have_same_parent
89-
from sage.misc.verbose import verbose, get_verbose
89+
from sage.misc.verbose import verbose
9090
from sage.categories.fields import Fields
9191
from sage.categories.integral_domains import IntegralDomains
9292
from sage.rings.ring import is_Ring
9393
from sage.rings.number_field.number_field_base import NumberField
9494
from sage.rings.integer_ring import ZZ, is_IntegerRing
95-
from sage.rings.integer import Integer
9695
from sage.rings.rational_field import QQ, is_RationalField
9796
import sage.rings.abc
9897
from sage.arith.numerical_approx cimport digits_to_bits

src/sage/matrix/matrix_cyclo_dense.pyx

Lines changed: 3 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -47,13 +47,13 @@ from cysignals.signals cimport sig_on, sig_off
4747

4848
include "sage/libs/ntl/decl.pxi"
4949

50-
from sage.structure.element cimport ModuleElement, RingElement, Element, Vector
50+
from sage.structure.element cimport Element
5151
from sage.misc.randstate cimport randstate, current_randstate
5252
from sage.libs.gmp.randomize cimport *
5353

5454
from sage.libs.flint.types cimport fmpz_t, fmpq
55-
from sage.libs.flint.fmpz cimport fmpz_init, fmpz_clear, fmpz_set, fmpz_set_mpz, fmpz_one, fmpz_get_mpz, fmpz_add, fmpz_mul, fmpz_sub, fmpz_mul_si, fmpz_mul_si, fmpz_mul_si, fmpz_divexact, fmpz_lcm
56-
from sage.libs.flint.fmpq cimport fmpq_is_zero, fmpq_get_mpq, fmpq_set_mpq, fmpq_canonicalise
55+
from sage.libs.flint.fmpz cimport fmpz_init, fmpz_clear, fmpz_set_mpz, fmpz_one, fmpz_get_mpz, fmpz_add, fmpz_mul, fmpz_sub, fmpz_mul_si, fmpz_mul_si, fmpz_mul_si, fmpz_divexact, fmpz_lcm
56+
from sage.libs.flint.fmpq cimport fmpq_is_zero, fmpq_set_mpq, fmpq_canonicalise
5757
from sage.libs.flint.fmpq_mat cimport fmpq_mat_entry_num, fmpq_mat_entry_den, fmpq_mat_entry
5858

5959
from .args cimport MatrixArgs_init
@@ -70,14 +70,12 @@ from sage.rings.rational_field import QQ
7070
from sage.rings.integer_ring import ZZ
7171
from sage.rings.real_mpfr import create_RealNumber as RealNumber
7272
from sage.rings.integer cimport Integer
73-
from sage.rings.rational cimport Rational
7473
from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
7574
from sage.rings.number_field.number_field_element cimport NumberFieldElement
7675
from sage.rings.number_field.number_field_element_quadratic cimport NumberFieldElement_quadratic
7776

7877
from sage.structure.proof.proof import get_flag as get_proof_flag
7978
from sage.misc.verbose import verbose
80-
import math
8179

8280
from sage.matrix.matrix_modn_dense_double import MAX_MODULUS as MAX_MODULUS_modn_dense_double
8381
from sage.arith.multi_modular import MAX_MODULUS as MAX_MODULUS_multi_modular

src/sage/matrix/matrix_dense.pyx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -10,7 +10,6 @@ TESTS::
1010

1111
cimport sage.matrix.matrix as matrix
1212

13-
from sage.structure.element cimport Element, RingElement
1413
from sage.structure.richcmp cimport richcmp_item, rich_to_bool
1514
import sage.matrix.matrix_space
1615
import sage.structure.sequence

src/sage/matrix/matrix_gap.pyx

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -12,7 +12,6 @@ Wrappers on GAP matrices
1212
# ****************************************************************************
1313

1414
from sage.libs.gap.libgap import libgap
15-
from . import matrix_space
1615
from sage.structure.element cimport Matrix
1716
from .args cimport MatrixArgs_init
1817

src/sage/matrix/matrix_generic_sparse.pyx

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -52,14 +52,10 @@ EXAMPLES::
5252
sage: c.is_sparse()
5353
True
5454
"""
55-
56-
cimport sage.matrix.matrix as matrix
5755
cimport sage.matrix.matrix_sparse as matrix_sparse
5856
cimport sage.structure.element
59-
from sage.structure.element cimport ModuleElement
6057
from .args cimport MatrixArgs_init
6158

62-
import sage.misc.misc as misc
6359

6460
cdef class Matrix_generic_sparse(matrix_sparse.Matrix_sparse):
6561
r"""

src/sage/matrix/matrix_gf2e_dense.pyx

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -83,11 +83,11 @@ REFERENCES:
8383
# https://www.gnu.org/licenses/
8484
#*****************************************************************************
8585

86-
from cysignals.signals cimport sig_check, sig_on, sig_off
86+
from cysignals.signals cimport sig_on, sig_off
8787

8888
cimport sage.matrix.matrix_dense as matrix_dense
89-
from sage.structure.element cimport Matrix, Vector
90-
from sage.structure.element cimport ModuleElement, Element, RingElement
89+
from sage.structure.element cimport Matrix
90+
from sage.structure.element cimport Element
9191
from sage.structure.richcmp cimport rich_to_bool
9292
from sage.rings.finite_rings.element_base cimport Cache_base
9393

@@ -97,7 +97,7 @@ from sage.misc.randstate cimport randstate, current_randstate
9797
from sage.matrix.matrix_mod2_dense cimport Matrix_mod2_dense
9898
from .args cimport SparseEntry, MatrixArgs_init
9999

100-
from sage.libs.m4ri cimport m4ri_word, mzd_copy, mzd_init
100+
from sage.libs.m4ri cimport m4ri_word, mzd_copy
101101
from sage.libs.m4rie cimport *
102102
from sage.libs.m4rie cimport mzed_t
103103

src/sage/matrix/matrix_gfpn_dense.pyx

Lines changed: 1 addition & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -34,14 +34,11 @@ AUTHORS:
3434
# (at your option) any later version.
3535
# https://www.gnu.org/licenses/
3636
# ***************************************************************************
37-
3837
from cysignals.memory cimport check_realloc, check_malloc, sig_free
3938
from cpython.bytes cimport PyBytes_AsString, PyBytes_FromStringAndSize
4039
from cysignals.signals cimport sig_on, sig_off, sig_check
4140
cimport cython
4241

43-
import os
44-
4542
####################
4643
#
4744
# import sage types
@@ -53,12 +50,10 @@ from sage.cpython.string import FS_ENCODING
5350
from sage.rings.integer import Integer
5451
from sage.rings.finite_rings.finite_field_constructor import GF
5552
from sage.rings.finite_rings.integer_mod import IntegerMod_int
56-
from sage.matrix.constructor import random_matrix
5753
from sage.matrix.matrix_space import MatrixSpace
5854
from sage.misc.randstate import current_randstate
5955
from sage.misc.randstate cimport randstate
60-
from sage.misc.cachefunc import cached_method, cached_function
61-
from sage.structure.element cimport Element, ModuleElement, RingElement, Matrix
56+
from sage.structure.element cimport Element, Matrix
6257
from sage.structure.richcmp import rich_to_bool
6358
from .args cimport MatrixArgs_init
6459

src/sage/matrix/matrix_integer_dense.pyx

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -86,7 +86,6 @@ from sage.structure.proof.proof import get_flag as get_proof_flag
8686
from sage.structure.richcmp cimport rich_to_bool
8787
from sage.misc.randstate cimport randstate, current_randstate
8888

89-
from sage.matrix.matrix_rational_dense cimport Matrix_rational_dense
9089
from .args cimport SparseEntry, MatrixArgs_init
9190

9291
#########################################################
@@ -114,7 +113,6 @@ from sage.rings.polynomial.polynomial_ring_constructor import PolynomialRing
114113
from sage.rings.polynomial.polynomial_integer_dense_flint cimport Polynomial_integer_dense_flint
115114
from sage.structure.element cimport Element, Vector
116115
from sage.structure.element import is_Vector
117-
from sage.structure.sequence import Sequence
118116

119117
from .matrix_modn_dense_float cimport Matrix_modn_dense_template
120118
from .matrix_modn_dense_float cimport Matrix_modn_dense_float

src/sage/matrix/matrix_integer_sparse.pyx

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,7 +62,7 @@ from sage.libs.flint.fmpz_poly cimport fmpz_poly_fit_length, fmpz_poly_set_coeff
6262
from sage.libs.flint.fmpz_mat cimport fmpz_mat_entry
6363

6464
from .matrix_modn_sparse cimport Matrix_modn_sparse
65-
from sage.structure.element cimport ModuleElement, RingElement, Element, Vector
65+
from sage.structure.element cimport Element
6666

6767
import sage.matrix.matrix_space as matrix_space
6868

0 commit comments

Comments
 (0)