Trac #34588: fix some E251 in modular

URL: https://trac.sagemath.org/34588
Reported by: chapoton
Ticket author(s): Frédéric Chapoton
Reviewer(s): Matthias Koeppe

Author: Release Manager

src/sage/algebras/clifford_algebra.py

@@ -666,7 +666,7 @@ def _basis_index_function(self, x):
         # if the input is a tuple, assume that it has
         # entries in {0, ..., 2**Q.dim()-1}
         if isinstance(x, tuple):
-            return FrozenBitset(x, capacity = Q.dim())
+            return FrozenBitset(x, capacity=Q.dim())
 
         # slice the output of format in order to make conventions
         # of format and FrozenBitset agree.

src/sage/modular/abvar/cuspidal_subgroup.py

@@ -241,10 +241,11 @@ def lattice(self):
         try:
             return self.__lattice
         except AttributeError:
-            lattice = self._compute_lattice(rational_only = False)
+            lattice = self._compute_lattice(rational_only=False)
             self.__lattice = lattice
             return lattice
 
+
 class RationalCuspSubgroup(CuspidalSubgroup_generic):
     """
     EXAMPLES::
@@ -292,10 +293,11 @@ def lattice(self):
         try:
             return self.__lattice
         except AttributeError:
-            lattice = self._compute_lattice(rational_only = True)
+            lattice = self._compute_lattice(rational_only=True)
             self.__lattice = lattice
             return lattice
 
+
 class RationalCuspidalSubgroup(CuspidalSubgroup_generic):
     """
     EXAMPLES::
@@ -342,7 +344,7 @@ def lattice(self):
         try:
             return self.__lattice
         except AttributeError:
-            lattice = self._compute_lattice(rational_subgroup = True)
+            lattice = self._compute_lattice(rational_subgroup=True)
             self.__lattice = lattice
             return lattice
 

src/sage/modular/abvar/finite_subgroup.py

@@ -461,7 +461,7 @@ def __mul__(self, right):
         """
         lattice = self.lattice().scale(right)
         return FiniteSubgroup_lattice(self.abelian_variety(), lattice,
-                                      field_of_definition = self.field_of_definition())
+                                field_of_definition=self.field_of_definition())
 
     def __rmul__(self, left):
         """

src/sage/modular/abvar/morphism.py

@@ -546,7 +546,7 @@ def _image_of_finite_subgroup(self, G):
         B = G._relative_basis_matrix() * self.restrict_domain(G.abelian_variety()).matrix() * self.codomain().lattice().basis_matrix()
         lattice = B.row_module(ZZ)
         return self.codomain().finite_subgroup(lattice,
-                             field_of_definition = G.field_of_definition())
+                             field_of_definition=G.field_of_definition())
 
     def _image_of_abvar(self, A):
         """

src/sage/modular/arithgroup/arithgroup_generic.py

@@ -744,7 +744,7 @@ def _find_cusps(self):
         so this should usually be overridden in subclasses; but it doesn't have
         to be.
         """
-        i = Cusp([1,0])
+        i = Cusp([1, 0])
         L = [i]
         for a in self.coset_reps():
             ai = i.apply([a.a(), a.b(), a.c(), a.d()])
@@ -757,11 +757,12 @@ def _find_cusps(self):
                 L.append(ai)
         return L
 
-    def are_equivalent(self, x, y, trans = False):
+    def are_equivalent(self, x, y, trans=False):
         r"""
-        Test whether or not cusps x and y are equivalent modulo self.  If self
-        has a reduce_cusp() method, use that; otherwise do a slow explicit
-        test.
+        Test whether or not cusps x and y are equivalent modulo self.
+
+        If self has a reduce_cusp() method, use that; otherwise do a
+        slow explicit test.
 
         If trans = False, returns True or False. If trans = True, then return
         either False or an element of self mapping x onto y.

src/sage/modular/hecke/submodule.py

@@ -27,7 +27,6 @@
 from . import module
 
 
-
 def is_HeckeSubmodule(x):
     r"""
     Return True if x is of type HeckeSubmodule.
@@ -553,8 +552,8 @@ def dual_free_module(self, bound=None, anemic=True, use_star=True):
             # then we compute the dual on each eigenspace, then put them
             # together.
             if len(self.star_eigenvalues()) == 2:
-                V = self.plus_submodule(compute_dual = False).dual_free_module() + \
-                    self.minus_submodule(compute_dual = False).dual_free_module()
+                V = self.plus_submodule(compute_dual=False).dual_free_module() + \
+                    self.minus_submodule(compute_dual=False).dual_free_module()
                 return V
 
             # At this point, we know that self is an eigenspace for star.

src/sage/modular/local_comp/type_space.py

@@ -33,7 +33,7 @@
 
 
 @cached_function
-def example_type_space(example_no = 0):
+def example_type_space(example_no=0):
     r"""
     Quickly return an example of a type space. Used mainly to speed up
     doctesting.

src/sage/modular/modform/ambient_eps.py

@@ -198,9 +198,9 @@ def change_ring(self, base_ring):
         """
         if self.base_ring() == base_ring:
             return self
-        return ambient_R.ModularFormsAmbient_R(self, base_ring = base_ring)
+        return ambient_R.ModularFormsAmbient_R(self, base_ring=base_ring)
 
-    @cached_method(key=lambda self,sign: rings.Integer(sign)) # convert sign to an Integer before looking this up in the cache
+    @cached_method(key=lambda self, sign: rings.Integer(sign)) # convert sign to an Integer before looking this up in the cache
     def modular_symbols(self, sign=0):
         """
         Return corresponding space of modular symbols with given sign.
@@ -222,9 +222,9 @@ def modular_symbols(self, sign=0):
         """
         sign = rings.Integer(sign)
         return modsym.ModularSymbols(self.character(),
-                                     weight = self.weight(),
-                                     sign = sign,
-                                     base_ring = self.base_ring())
+                                     weight=self.weight(),
+                                     sign=sign,
+                                     base_ring=self.base_ring())
 
     @cached_method
     def eisenstein_submodule(self):

src/sage/modular/modform/constructor.py

@@ -153,12 +153,13 @@ def ModularForms_clear_cache():
     global _cache
     _cache = {}
 
-def ModularForms(group  = 1,
-                 weight = 2,
-                 base_ring = None,
+
+def ModularForms(group=1,
+                 weight=2,
+                 base_ring=None,
                  eis_only=False,
-                 use_cache = True,
-                 prec = defaults.DEFAULT_PRECISION):
+                 use_cache=True,
+                 prec=defaults.DEFAULT_PRECISION):
     r"""
     Create an ambient space of modular forms.
 
@@ -346,8 +347,8 @@ def ModularForms(group  = 1,
         eps = eps.minimize_base_ring()
         if eps.is_trivial():
             return ModularForms(eps.modulus(), weight, base_ring,
-                                use_cache = use_cache,
-                                prec = prec)
+                                use_cache=use_cache,
+                                prec=prec)
         M = ModularFormsAmbient_eps(eps, weight, eis_only=eis_only)
         if base_ring != eps.base_ring():
             M = M.base_extend(base_ring) # ambient_R.ModularFormsAmbient_R(M, base_ring)
@@ -360,11 +361,11 @@ def ModularForms(group  = 1,
     return M
 
 
-def CuspForms(group  = 1,
-              weight = 2,
-              base_ring = None,
-              use_cache = True,
-              prec = defaults.DEFAULT_PRECISION):
+def CuspForms(group=1,
+              weight=2,
+              base_ring=None,
+              use_cache=True,
+              prec=defaults.DEFAULT_PRECISION):
     """
     Create a space of cuspidal modular forms.
 
@@ -380,13 +381,13 @@ def CuspForms(group  = 1,
                         use_cache=use_cache, prec=prec).cuspidal_submodule()
 
 
-def EisensteinForms(group  = 1,
-              weight = 2,
-              base_ring = None,
-              use_cache = True,
-              prec = defaults.DEFAULT_PRECISION):
+def EisensteinForms(group=1,
+              weight=2,
+              base_ring=None,
+              use_cache=True,
+              prec=defaults.DEFAULT_PRECISION):
     """
-    Create a space of eisenstein modular forms.
+    Create a space of Eisenstein modular forms.
 
     See the documentation for the ModularForms command for a
     description of the input parameters.
@@ -396,15 +397,14 @@ def EisensteinForms(group  = 1,
         sage: EisensteinForms(11,2)
         Eisenstein subspace of dimension 1 of Modular Forms space of dimension 2 for Congruence Subgroup Gamma0(11) of weight 2 over Rational Field
     """
-    if weight==1:
+    if weight == 1:
         return ModularForms(group, weight, base_ring,
                         use_cache=use_cache, eis_only=True, prec=prec).eisenstein_submodule()
     else:
         return ModularForms(group, weight, base_ring,
                         use_cache=use_cache, prec=prec).eisenstein_submodule()
 
 
-
 def Newforms(group, weight=2, base_ring=None, names=None):
     r"""
     Returns a list of the newforms of the given weight and level (or weight,

src/sage/modular/modform/cuspidal_submodule.py

@@ -236,7 +236,7 @@ def _compute_q_expansion_basis(self, prec=None):
             prec = Integer(prec)
         if self.dimension() == 0:
             return []
-        M = self.modular_symbols(sign = 1)
+        M = self.modular_symbols(sign=1)
         return M.q_expansion_basis(prec)
 
     def _compute_hecke_matrix_prime(self, p):