Skip to content

Commit f93e0a7

Browse files
author
Release Manager
committed
Trac #34926: Fix tests with giac>=1.9.0.35
A warning `argument is not an equation` has been removed in 1.9.0.35, which breaks a few tests. URL: https://trac.sagemath.org/34926 Reported by: arojas Ticket author(s): Antonio Rojas Reviewer(s): Matthias Koeppe
2 parents 81ae887 + f28961e commit f93e0a7

File tree

2 files changed

+6
-12
lines changed

2 files changed

+6
-12
lines changed

src/sage/libs/giac/giac.pyx

Lines changed: 1 addition & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -374,8 +374,7 @@ def _giac(s):
374374
375375
sage: x = libgiac('x')
376376
sage: (1+2*sin(3*x)).solve(x).simplify()
377-
Warning, argument is not an equation, solving 1+2*sin(3*x)=0
378-
list[-pi/18,7*pi/18]
377+
...list[-pi/18,7*pi/18]
379378
380379
sage: libgiac.solve('sin(3*x)>2*sin(x)',x)
381380
Traceback (most recent call last):

src/sage/symbolic/relation.py

Lines changed: 5 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -935,8 +935,7 @@ def solve(f, *args, **kwds):
935935
936936
sage: f = (sin(x) - 8*cos(x)*sin(x))*(sin(x)^2 + cos(x)) - (2*cos(x)*sin(x) - sin(x))*(-2*sin(x)^2 + 2*cos(x)^2 - cos(x))
937937
sage: solve(f, x, algorithm='giac')
938-
...
939-
[-2*arctan(sqrt(2)), 0, 2*arctan(sqrt(2)), pi]
938+
...[-2*arctan(sqrt(2)), 0, 2*arctan(sqrt(2)), pi]
940939
941940
sage: x, y = SR.var('x,y')
942941
sage: solve([x+y-4,x*y-3],[x,y],algorithm='giac')
@@ -1440,19 +1439,15 @@ def _giac_solver(f, x, solution_dict=False):
14401439
EXAMPLES::
14411440
14421441
sage: solve([(2/3)^x-2], [x], algorithm='giac')
1443-
...
1444-
[[-log(2)/(log(3) - log(2))]]
1442+
...[[-log(2)/(log(3) - log(2))]]
14451443
sage: solve([(2/3)^x-2], [x], algorithm='giac', solution_dict=True)
1446-
...
1447-
[{x: -log(2)/(log(3) - log(2))}]
1444+
...[{x: -log(2)/(log(3) - log(2))}]
14481445
14491446
sage: f = (sin(x) - 8*cos(x)*sin(x))*(sin(x)^2 + cos(x)) - (2*cos(x)*sin(x) - sin(x))*(-2*sin(x)^2 + 2*cos(x)^2 - cos(x))
14501447
sage: solve(f, x, algorithm='giac')
1451-
...
1452-
[-2*arctan(sqrt(2)), 0, 2*arctan(sqrt(2)), pi]
1448+
...[-2*arctan(sqrt(2)), 0, 2*arctan(sqrt(2)), pi]
14531449
sage: solve(f, x, algorithm='giac', solution_dict=True)
1454-
...
1455-
[{x: -2*arctan(sqrt(2))}, {x: 0}, {x: 2*arctan(sqrt(2))}, {x: pi}]
1450+
...[{x: -2*arctan(sqrt(2))}, {x: 0}, {x: 2*arctan(sqrt(2))}, {x: pi}]
14561451
14571452
sage: x, y = SR.var('x,y')
14581453
sage: solve([x+y-7,x*y-10],[x,y],algorithm='giac')

0 commit comments

Comments
 (0)