Skip to content

Commit f998da7

Browse files
committed
fix the base ring, tweak the category
1 parent 7df421d commit f998da7

File tree

1 file changed

+8
-4
lines changed

1 file changed

+8
-4
lines changed

src/sage/rings/padics/witt_vector_ring.py

Lines changed: 8 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -25,6 +25,7 @@
2525
from typing import Iterator
2626

2727
from sage.categories.commutative_rings import CommutativeRings
28+
from sage.categories.integral_domains import IntegralDomains
2829
from sage.categories.fields import Fields
2930
from sage.misc.latex import latex
3031
from sage.rings.integer import Integer
@@ -278,8 +279,11 @@ def __init__(self, coefficient_ring, prec, prime) -> None:
278279
self._prec = prec
279280
self._prime = prime
280281

281-
Parent.__init__(self, base=coefficient_ring,
282-
category=CommutativeRings())
282+
if self._coefficient_ring in IntegralDomains():
283+
cat = IntegralDomains()
284+
else:
285+
cat = CommutativeRings()
286+
Parent.__init__(self, base=ZZ, category=cat)
283287

284288
def __iter__(self) -> Iterator:
285289
"""
@@ -385,7 +389,7 @@ def _generate_sum_and_product_polynomials(self, coefficient_ring, prec, p):
385389
#
386390
# Remark: Since when is SIXTEEN bits sufficient for anyone???
387391
#
388-
if p**(prec-1) >= 2**16:
392+
if p**(prec - 1) >= 2**16:
389393
implementation = 'generic'
390394
else:
391395
implementation = 'singular'
@@ -811,7 +815,7 @@ def __init__(self, coefficient_ring, prec, prime) -> None:
811815
sage: type(W)
812816
<class 'sage.rings.padics.witt_vector_ring.WittVectorRing_phantom_with_category'>
813817
814-
sage: TestSuite(W).run()
818+
sage: TestSuite(W).run(skip="_test_fraction_field")
815819
"""
816820
if not (coefficient_ring.characteristic() == prime
817821
and (coefficient_ring in Fields().Finite()

0 commit comments

Comments
 (0)