Skip to content

Commit fedfcdc

Browse files
committed
fix in other similar places
1 parent 3bbf8aa commit fedfcdc

File tree

4 files changed

+24
-12
lines changed

4 files changed

+24
-12
lines changed

src/sage/rings/polynomial/polynomial_element.pyx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -7667,9 +7667,12 @@ cdef class Polynomial(CommutativePolynomial):
76677667

76687668
cdef unsigned long d
76697669
if degree is not None:
7670-
d = degree
7671-
if d != degree:
7672-
raise ValueError("degree argument must be a non-negative integer, got %s"%(degree))
7670+
if degree <= 0:
7671+
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
7672+
try:
7673+
d = degree
7674+
except ValueError:
7675+
raise ValueError("degree argument must be a non-negative inte ger, got %s" % (degree))
76737676
if len(v) < degree+1:
76747677
v.reverse()
76757678
v = [self.base_ring().zero()]*(degree+1-len(v)) + v

src/sage/rings/polynomial/polynomial_integer_dense_flint.pyx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1827,9 +1827,12 @@ cdef class Polynomial_integer_dense_flint(Polynomial):
18271827
cdef Polynomial_integer_dense_flint res = self._new()
18281828
cdef unsigned long d
18291829
if degree is not None:
1830-
d = degree
1831-
if d != degree:
1832-
raise ValueError("degree argument must be a non-negative integer, got %s" % degree)
1830+
if degree <= 0:
1831+
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
1832+
try:
1833+
d = degree
1834+
except ValueError:
1835+
raise ValueError("degree argument must be a non-negative inte ger, got %s" % (degree))
18331836
# FLINT expects length
18341837
fmpz_poly_reverse(res._poly, self._poly, d+1)
18351838
else:

src/sage/rings/polynomial/polynomial_zmod_flint.pyx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -815,9 +815,12 @@ cdef class Polynomial_zmod_flint(Polynomial_template):
815815
cdef Polynomial_zmod_flint res = self._new()
816816
cdef unsigned long d
817817
if degree is not None:
818-
d = degree
819-
if d != degree:
820-
raise ValueError("degree argument must be a non-negative integer, got %s"%(degree))
818+
if degree <= 0:
819+
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
820+
try:
821+
d = degree
822+
except ValueError:
823+
raise ValueError("degree argument must be a non-negative inte ger, got %s" % (degree))
821824
nmod_poly_reverse(&res.x, &self.x, d+1) # FLINT expects length
822825
else:
823826
nmod_poly_reverse(&res.x, &self.x, nmod_poly_length(&self.x))

src/sage/rings/polynomial/polynomial_zz_pex.pyx

Lines changed: 6 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -538,9 +538,12 @@ cdef class Polynomial_ZZ_pEX(Polynomial_template):
538538
# When a degree has been supplied, ensure it is a valid input
539539
cdef unsigned long d
540540
if degree is not None:
541-
d = degree
542-
if d != degree:
543-
raise ValueError("degree argument must be a non-negative integer, got %s"%(degree))
541+
if degree <= 0:
542+
raise ValueError("degree argument must be a non-negative integer, got %s" % (degree))
543+
try:
544+
d = degree
545+
except ValueError:
546+
raise ValueError("degree argument must be a non-negative inte ger, got %s" % (degree))
544547
ZZ_pEX_reverse_hi(r.x, (<Polynomial_ZZ_pEX> self).x, d)
545548
else:
546549
ZZ_pEX_reverse(r.x, (<Polynomial_ZZ_pEX> self).x)

0 commit comments

Comments
 (0)