Skip to content

Commit ffb5410

Browse files
author
Release Manager
committed
gh-39031: Remove pipfile <!-- ^ Please provide a concise and informative title. --> <!-- ^ Don't put issue numbers in the title, do this in the PR description below. --> <!-- ^ For example, instead of "Fixes #12345" use "Introduce new method to calculate 1 + 2". --> <!-- v Describe your changes below in detail. --> <!-- v Why is this change required? What problem does it solve? --> <!-- v If this PR resolves an open issue, please link to it here. For example, "Fixes #12345". --> A few years ago I made some experiements with pipenv and added these `pipfile`'s in the progress. I no longer think this is a valuable strategy for sage (e.g `uv` seems to better align with the current philosohpy). Thus, the pipfiles can be deleted again. ### 📝 Checklist <!-- Put an `x` in all the boxes that apply. --> - [ ] The title is concise and informative. - [ ] The description explains in detail what this PR is about. - [ ] I have linked a relevant issue or discussion. - [ ] I have created tests covering the changes. - [ ] I have updated the documentation and checked the documentation preview. ### ⌛ Dependencies <!-- List all open PRs that this PR logically depends on. For example, --> <!-- - #12345: short description why this is a dependency --> <!-- - #34567: ... --> URL: #39031 Reported by: Tobias Diez Reviewer(s): Frédéric Chapoton
2 parents 63a510b + 5773e0b commit ffb5410

File tree

6 files changed

+2
-70
lines changed

6 files changed

+2
-70
lines changed

.ci/write-dockerfile.sh

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -275,11 +275,11 @@ cat <<EOF
275275
FROM with-system-packages AS bootstrapped
276276
#:bootstrapping:
277277
RUN rm -rf /new /sage/.git
278-
$ADD Makefile VERSION.txt COPYING.txt condarc.yml README.md bootstrap bootstrap-conda configure.ac sage .homebrew-build-env tox.ini Pipfile.m4 .gitignore /new/
278+
$ADD Makefile VERSION.txt COPYING.txt condarc.yml README.md bootstrap bootstrap-conda configure.ac sage .homebrew-build-env tox.ini .gitignore /new/
279279
$ADD config/config.rpath /new/config/config.rpath
280280
$ADD src/doc/bootstrap /new/src/doc/bootstrap
281281
$ADD src/bin /new/src/bin
282-
$ADD src/Pipfile.m4 src/pyproject.toml src/requirements.txt.m4 src/setup.cfg.m4 src/VERSION.txt /new/src/
282+
$ADD src/pyproject.toml src/requirements.txt.m4 src/setup.cfg.m4 src/VERSION.txt /new/src/
283283
$ADD m4 /new/m4
284284
$ADD pkgs /new/pkgs
285285
$ADD build /new/build

.gitignore

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -56,10 +56,6 @@
5656

5757
/src/setup.cfg
5858
/src/requirements.txt
59-
/src/Pipfile
60-
/src/Pipfile.lock
61-
/Pipfile
62-
/Pipfile.lock
6359

6460
# Various editors
6561
*~

Makefile

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -175,7 +175,6 @@ bootstrap-clean:
175175
rm -f src/doc/en/installation/*.txt
176176
find src/doc/en/reference/spkg -name index.rst -prune -o -maxdepth 1 -name "*.rst" -exec rm -f {} \+
177177
for a in environment environment-optional src/environment src/environment-dev src/environment-optional; do rm -f $$a.yml $$a-3.[89].yml $$a-3.1[0-9].yml; done
178-
rm -f src/Pipfile
179178
rm -f src/requirements.txt
180179
rm -f src/setup.cfg
181180
rm -f build/pkgs/cypari/version_requirements.txt

Pipfile.m4

Lines changed: 0 additions & 40 deletions
This file was deleted.

bootstrap

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -227,7 +227,6 @@ save () {
227227
src/doc/en/installation/*.txt \
228228
$(find src/doc/en/reference/spkg -name index.rst -prune -o -maxdepth 1 -name "*.rst" -print) \
229229
environment-3.[89].yml environment-3.1[0-9].yml \
230-
src/Pipfile \
231230
src/pyproject.toml \
232231
src/requirements.txt \
233232
src/setup.cfg \

src/Pipfile.m4

Lines changed: 0 additions & 22 deletions
This file was deleted.

0 commit comments

Comments
 (0)