Skip to content

harmonize xxx_number #40935

@mantepse

Description

@mantepse

Here is a table of the odd method names, together with proposed aliases

file future alias new standard
abstract_tree node_number_at_depth number_of_nodes_at_depth #40939
abstract_tree node_number_to_the_right number_of_nodes_right (not sure) #40939
abstract_tree node_number number_of_nodes, n_nodes #40939
alternating_sign_matrix inversion_number number_of_inversions (as in Permutation) #40940
binary_tree left_children_node_number number_of_left_nodes #40939
permutation longest_increasing_subsequences_number number_of_longest_increasing_subsequences #40941
posets/posets relations_number number_of_relations, n_relations #40942
posets/posets jump_number keep
graphs/connectivity connected_components_number number_of_connected_components #40943
tableau inversion_number ???
tableau standard_number_of_descents number_of_standard_descents

There is particularly sad accident with Tableau: this class, unfortunately, has methods descents, major_index, and inversions, which have nothing to do with descents and friends as one would expect them for standard and semistandard tableaux. These in turn are named standard_descents, etc. Although I hate them, I think we cannot improve the situation.

@fchapoton, would you support renaming these?

Metadata

Metadata

Assignees

No one assigned

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions