Skip to content

Add lattice utility functions #40571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 16 commits into
base: develop
Choose a base branch
from
Open

Add lattice utility functions #40571

wants to merge 16 commits into from

Conversation

whoami730
Copy link

@whoami730 whoami730 commented Aug 11, 2025 •
edited
Loading

This PR adds two lattice utility functions, namely, gaussian_heuristic and hadamard_ratio. These are useful when evaluating how good the approx CVP/SVP solutions are to the exact CVP/SVP solutions.

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

@github-actions GitHub Actions
Copy link

github-actions bot commented Aug 14, 2025 •
edited
Loading

Documentation preview for this PR (built with commit b4cdf87; changes) is ready! 🎉
This preview will update shortly after each push to this PR.

@whoami730 whoami730 marked this pull request as ready for review August 16, 2025 09:43
user202729
user202729 reviewed Aug 17, 2025
View reviewed changes
@user202729
Copy link
Contributor

@roed314 if you have permission to approve workflows please approve for this commit, thanks.

@tscrim
Copy link
Collaborator

tscrim commented Aug 21, 2025

@user202729 I've approved the workflows.

@whoami730
Copy link
Author

@tscrim requesting workflows approval yet again 😅

@roed314
Copy link
Contributor

roed314 commented Aug 24, 2025

Done.

@whoami730 whoami730 requested a review from user202729 August 26, 2025 03:50
@fchapoton
Copy link
Contributor

do not merge once you got a positive review, never

@user202729
Copy link
Contributor

user202729 commented Aug 29, 2025 •
edited
Loading

I'm reasonably confident that if the merge is clean and the change is just adding some new functions then tests cannot fail... 🥶

alternatively someone can modify the GitHub workflow to detect the "clean merge" case and avoid re-setting the labels. (might have some false positive however, I guess the burden would be on the release manger, but then the exact same issue happens if the PR weren't merged in the first place)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@user202729 user202729 Awaiting requested review from user202729

Assignees
No one assigned
Labels
s: positive review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@whoami730 @user202729 @tscrim @roed314 @fchapoton