From aafab7543dc95e1176a6bb8d315c1ecb35fd797c Mon Sep 17 00:00:00 2001 From: user202729 <25191436+user202729@users.noreply.github.com> Date: Thu, 28 Aug 2025 18:50:40 +0700 Subject: [PATCH 1/2] Add a step to doc-build-pdf to check for missing character errors --- .github/workflows/check-latex-build.sh | 8 ++++++++ .github/workflows/doc-build-pdf.yml | 3 +++ 2 files changed, 11 insertions(+) create mode 100755 .github/workflows/check-latex-build.sh diff --git a/.github/workflows/check-latex-build.sh b/.github/workflows/check-latex-build.sh new file mode 100755 index 00000000000..3db26ce351b --- /dev/null +++ b/.github/workflows/check-latex-build.sh @@ -0,0 +1,8 @@ +#!/bin/sh +expected_num_errors=1 + +cd builddir/src/doc/latex +echo "All missing character error messages in LaTeX log files:" +num_errors=$(grep -r "Missing character" --include "*.log" | tee /dev/stderr | wc -l) +echo "In total there are $num_errors missing character errors, expecting $expected_num_errors" +[ $num_errors = $expected_num_errors ] diff --git a/.github/workflows/doc-build-pdf.yml b/.github/workflows/doc-build-pdf.yml index f278dae841e..a2a773f103d 100644 --- a/.github/workflows/doc-build-pdf.yml +++ b/.github/workflows/doc-build-pdf.yml @@ -80,6 +80,9 @@ jobs: env: SAGE_DOCBUILD_OPTS: "--include-tests-blocks" + - name: Check for missing character error messages + run: sh .github/workflows/check-latex-build.sh + - name: Copy doc id: copy run: | From 8418e79e2139cff67ea4e87ee0e7c6a4e4bffd99 Mon Sep 17 00:00:00 2001 From: user202729 <25191436+user202729@users.noreply.github.com> Date: Fri, 29 Aug 2025 07:21:20 +0700 Subject: [PATCH 2/2] Change 1 to 36, add workflow command --- .github/workflows/check-latex-build.sh | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/.github/workflows/check-latex-build.sh b/.github/workflows/check-latex-build.sh index 3db26ce351b..5318384caf7 100755 --- a/.github/workflows/check-latex-build.sh +++ b/.github/workflows/check-latex-build.sh @@ -1,8 +1,9 @@ #!/bin/sh -expected_num_errors=1 +expected_num_errors=36 cd builddir/src/doc/latex echo "All missing character error messages in LaTeX log files:" num_errors=$(grep -r "Missing character" --include "*.log" | tee /dev/stderr | wc -l) echo "In total there are $num_errors missing character errors, expecting $expected_num_errors" +[ $num_errors = $expected_num_errors ] || echo "::error title=Missing character errors introduced in PDF build::In total there are $num_errors missing character errors, expecting $expected_num_errors" [ $num_errors = $expected_num_errors ]