Skip to content

Use the safe method to avoid segfault #41264

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
cxzhong wants to merge 6 commits into
base: develop
Choose a base branch
from
Open

Use the safe method to avoid segfault #41264

cxzhong wants to merge 6 commits into from
+28 −22

Conversation

@cxzhong
Copy link
Contributor

@cxzhong cxzhong commented Dec 5, 2025 •
edited
Loading

Fix #41249 Use the safe method instead of get_unsafe and set_unsafe

📝 Checklist

  • The title is concise and informative.
  • The description explains in detail what this PR is about.
  • I have linked a relevant issue or discussion.
  • I have created tests covering the changes.
  • I have updated the documentation and checked the documentation preview.

⌛ Dependencies

@cxzhong cxzhong mentioned this pull request Dec 5, 2025
Open
2 tasks
@cxzhong cxzhong closed this Dec 5, 2025
@cxzhong
Refactor get/set methods for direct indexing
2238fb9 
Refactor get and set methods to use indexing directly.
@cxzhong cxzhong reopened this Dec 5, 2025
@cxzhong cxzhong changed the title Add a bound check and Avoid segfault Use the safe method to avoid segfault Dec 5, 2025
@cxzhong cxzhong marked this pull request as ready for review December 5, 2025 15:00
@cxzhong cxzhong requested a review from dimpase December 5, 2025 15:19
dimpase
dimpase suggested changes Dec 5, 2025
View reviewed changes
Copy link
Member

@dimpase dimpase left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

get() is an unsafe method, as documented. What's the point of this? Just use __getitem__, which (should be, although I didn't check) is safe

@dimpase
Copy link
Member

dimpase commented Dec 6, 2025

please see my comment in #41249 - the whole point of get is to be as quick as possible. One can wrap the call to get_unsafe in sig_on/sig_off, introducing some overhead, less than your PR. But I don't see much point in it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@dimpase dimpase dimpase requested changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

s: needs review

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Segmentation Fault when trying to get out-of-bounds index of vector

2 participants

@cxzhong @dimpase