course: convert all actions to arrow functions

Author: williamstein

src/packages/frontend/course/actions.ts

@@ -64,34 +64,34 @@ export class CourseActions extends Actions<CourseState> {
     this.export = bind_methods(new ExportActions(this));
   }
 
-  public get_store(): CourseStore {
+  get_store = (): CourseStore => {
     const store = this.redux.getStore<CourseState, CourseStore>(this.name);
     if (store == null) throw Error("store is null");
     if (!this.store_is_initialized())
       throw Error("course store must be initialized");
     this.state = "ready"; // this is pretty dumb for now.
     return store;
-  }
+  };
 
-  public is_closed(): boolean {
+  is_closed = (): boolean => {
     if (this.state == "closed") return true;
     const store = this.redux.getStore<CourseState, CourseStore>(this.name);
     if (store == null) {
       this.state = "closed";
       return true;
     }
     return false;
-  }
+  };
 
-  private is_loaded(): boolean {
+  private is_loaded = (): boolean => {
     if (this.syncdb == null) {
       this.set_error("attempt to set syncdb before loading");
       return false;
     }
     return true;
-  }
+  };
 
-  private store_is_initialized(): boolean {
+  private store_is_initialized = (): boolean => {
     const store = this.redux.getStore<CourseState, CourseStore>(this.name);
     if (store == null) {
       return false;
@@ -107,7 +107,7 @@ export class CourseActions extends Actions<CourseState> {
       return false;
     }
     return true;
-  }
+  };
 
   // Set one object in the syncdb
   set = (obj: SyncDBRecord, commit: boolean = true): void => {
@@ -145,7 +145,7 @@ export class CourseActions extends Actions<CourseState> {
   };
 
   // Get one object from this.syncdb as a Javascript object (or undefined)
-  public get_one(obj: SyncDBRecord): SyncDBRecord | undefined {
+  get_one = (obj: SyncDBRecord): SyncDBRecord | undefined => {
     if (
       this.syncdb != null ? this.syncdb.get_state() === "closed" : undefined
     ) {
@@ -154,9 +154,9 @@ export class CourseActions extends Actions<CourseState> {
     const x: any = this.syncdb.get_one(obj);
     if (x == null) return;
     return x.toJS();
-  }
+  };
 
-  public async save(): Promise<void> {
+  save = async (): Promise<void> => {
     const store = this.get_store();
     if (store == null) {
       return;
@@ -179,9 +179,9 @@ export class CourseActions extends Actions<CourseState> {
       this.update_unsaved_changes();
       setTimeout(this.update_unsaved_changes.bind(this), 1000);
     }
-  }
+  };
 
-  public syncdb_change(changes: TypedMap<SyncDBRecord>[]): void {
+  syncdb_change = (changes: TypedMap<SyncDBRecord>[]): void => {
     let t;
     const store = this.get_store();
     if (store == null) {
@@ -219,18 +219,18 @@ export class CourseActions extends Actions<CourseState> {
       this.setState(t);
     }
     this.update_unsaved_changes();
-  }
+  };
 
-  private update_unsaved_changes(): void {
+  private update_unsaved_changes = (): void => {
     if (this.syncdb == null) {
       return;
     }
     const unsaved = this.syncdb.has_unsaved_changes();
     this.setState({ unsaved });
-  }
+  };
 
   // important that this be bound...
-  public handle_projects_store_update(projects_store: ProjectsStore): void {
+  handle_projects_store_update = (projects_store: ProjectsStore): void => {
     const store = this.redux.getStore<CourseState, CourseStore>(this.name);
     if (store == null) return; // not needed yet.
     let users = projects_store.getIn([
@@ -248,12 +248,12 @@ export class CourseActions extends Actions<CourseState> {
       this.student_projects.configure_all_projects();
     }
     this.last_collaborator_state = users;
-  }
+  };
 
   // Set the error.  Use error="" to explicitly clear the existing set error.
   // If there is an error already set, then the new error is just
   // appended to the existing one.
-  public set_error(error: string): void {
+  set_error = (error: string): void => {
     if (error != "") {
       const store = this.get_store();
       if (store == null) return;
@@ -263,18 +263,18 @@ export class CourseActions extends Actions<CourseState> {
       error = error.trim();
     }
     this.setState({ error });
-  }
+  };
 
   // ACTIVITY ACTIONS
-  public set_activity = (
+  set_activity = (
     opts: { id: number; desc?: string } | { id?: number; desc: string },
   ): number => {
     return this.activity.set_activity(opts);
   };
 
-  public clear_activity(id?: number): void {
+  clear_activity = (id?: number): void => {
     this.activity.clear_activity(id);
-  }
+  };
 
   // CONFIGURATION ACTIONS
   // These hang off of this.configuration
@@ -302,12 +302,12 @@ export class CourseActions extends Actions<CourseState> {
      If something goes wrong and the finish function is defined, then
      it is called with a string describing the error.
     */
-  public resolve(opts: {
+  resolve = (opts: {
     assignment_id?: string;
     student_id?: string;
     handout_id?: string;
     finish?: Function;
-  }) {
+  }) => {
     const r: {
       student?: StudentRecord;
       assignment?: AssignmentRecord;
@@ -359,20 +359,20 @@ export class CourseActions extends Actions<CourseState> {
       }
     }
     return r;
-  }
+  };
 
   // Takes an item_name and the id of the time
   // item_name should be one of
   // ['student', 'assignment', 'peer_config', handout', 'skip_grading']
-  public toggle_item_expansion(
+  toggle_item_expansion = (
     item_name:
       | "student"
       | "assignment"
       | "peer_config"
       | "handout"
       | "skip_grading",
     item_id,
-  ): void {
+  ): void => {
     let adjusted;
     const store = this.get_store();
     if (store == null) {
@@ -391,5 +391,5 @@ export class CourseActions extends Actions<CourseState> {
       }
     }
     this.setState({ [field_name]: adjusted });
-  }
+  };
 }

src/packages/frontend/course/activity/actions.ts

@@ -20,9 +20,9 @@ export class ActivityActions {
     this.actions = actions;
   }
 
-  public set_activity(
+  set_activity = (
     opts: { id: number; desc?: string } | { id?: number; desc: string },
-  ): number {
+  ): number => {
     if (this.actions.is_closed()) return -1;
     if (opts.id == null) {
       this.activity_id += 1;
@@ -41,14 +41,14 @@ export class ActivityActions {
     }
     this.actions.setState({ activity });
     return opts.id;
-  }
+  };
 
-  public clear_activity(id?: number): void {
+  clear_activity = (id?: number): void => {
     if (this.actions.is_closed()) return;
     if (id != null) {
       this.set_activity({ id }); // clears for this id since desc not provided
     } else {
       this.actions.setState({ activity: Map() }); // clear all activity
     }
-  }
+  };
 }